[ https://issues.jboss.org/browse/JBTM-1020?page=com.atlassian.jira.plugin.... ] Paul Robinson updated JBTM-1020: -------------------------------- Summary: Integrate FindBugs into maven build (was: Consider usings a tool for finding common bugs) Assignee: Amos Feng (was: Tom Jenkinson) Description: A recent bug in XTS recovery was found to be caused by the use of == rather than .equals() for String comparison. This type of bug can go unnoticed for a long period of time as == will usually return true for Strings with identical contents. However, it is not guaranteed. We should integrate FindBugs (http://mojo.codehaus.org/findbugs-maven-plugin/) into our build for the Narayana project. FindBugs should run in the test-complie phase. was: A recent bug in XTS recovery was found to be caused by the use of == rather than .equals() for String comparison. This type of bug can go unnoticed for a long period of time as == will usually return true for Strings with identical contents. However, it is not guaranteed. I think it would be handy to run some tool every now and then to look for these types of bugs. I'm not sure how feasible this would be as it may return too many false positives. Component/s: Build System -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.jboss.org/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://issues.jboss.org/browse/JBTM-1020?page=com.atlassian.jira.plugin.... ] Tom Jenkinson updated JBTM-1020: -------------------------------- Component/s: Testing -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira