[
https://issues.jboss.org/browse/JBTM-1430?page=com.atlassian.jira.plugin....
]
Tom Jenkinson commented on JBTM-1430:
-------------------------------------
Hi Mark,
I will take a look and make sure that the "public" methods are no longer
deprecated as you say, we can't really anticipate what users are utilizing and there
could be good reason for them to exist - I don't know why I didn't filter that
before.
-- I will make this change immediately.
I would argue that maintaining code in the internal packages that are purely used by tests
is not ideal as it affects coverage and further gives us more code to maintain, hence I
deprecated that code to ensure new tests were not written using these helper methods when
similar APIs that are utilized heavily were provided.
-- I will review these individually in the context of the test.
Tom
Restore commit method to AtomicAction
-------------------------------------
Key: JBTM-1430
URL:
https://issues.jboss.org/browse/JBTM-1430
Project: JBoss Transaction Manager
Issue Type: Bug
Security Level: Public(Everyone can see)
Components: Transaction Core
Affects Versions: 4.17.3
Reporter: Mark Little
Assignee: Tom Jenkinson
At some point someone deprecated the commit method in AtomicAction and left the following
comment:
@deprecated Only used by tests
This is wrong. Just because we don't use the commit method in the code does not mean
it is invalid in the scope of the public API. The commit method without the boolean
parameter is a helper method to simplify calling the other commit with true all of the
time. This was added years ago based on feedback from the OTS Current implementation,
which had (in C++) a default boolean=true parameter in its signature.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see:
http://www.atlassian.com/software/jira