[
https://issues.redhat.com/browse/JBTM-3132?page=com.atlassian.jira.plugin...
]
Mayank Kunwar commented on JBTM-3132:
-------------------------------------
The intention of pull/283 is to support JBTM-3122, so, the changes required for quickstart
tests to run on JDK9+ versions are done as part of this pull request.
So every module that are required to run their tests over JDK9+ versions, only for them, I
have included the parent in their pom.xml file, so that they could use same properties
defined in parent pom.xml, when ran on JDK9+ versions.
Some of the modules in quickstart were not compiling when I tried adding parent to their
pom.xml file, due to some incompatibility/conflicts specific to particular module with
parent.
Common parent maven module for Narayana quickstarts
---------------------------------------------------
Key: JBTM-3132
URL:
https://issues.redhat.com/browse/JBTM-3132
Project: JBoss Transaction Manager
Issue Type: Enhancement
Components: Testing
Affects Versions: 5.9.5.Final
Reporter: Ondrej Chaloupka
Assignee: Mayank Kunwar
Priority: Major
It would be beneficial to create a common quickstart maven module.
My intention is to have a one place where we can define:
* common profiles could be defined (one of such profile is Arquillian JDK9+ which defines
JVM arguments needed for smooth run of tests, see
https://issues.jboss.org/projects/JBTM/issues/JBTM-3122)
* common properties like arquillian version. This has benefit that quickstarts will run
faster on CI as there won't be multiple versions to be downloaded.
* common repositories like jboss one
* unified checkstyle definition for all the quickstarts would be coded in one way which
makes them easier to read
The quickstarts were designed to be independent on each other. The task is not to unified
them. The proposal is about creating a place where a common stuff can be placed to.
Otherwise the same configuration needs to be copied to multiple places. Which is hard to
maintain
Other projects, e.g. WildFly, use the same approach of common parent, see
https://github.com/wildfly/quickstart/blob/master/app-client/pom.xml
--
This message was sent by Atlassian Jira
(v7.13.8#713008)