[ https://jira.jboss.org/jira/browse/JBTM-664?page=com.atlassian.jira.plugi... ] Olivier BILLIARD updated JBTM-664: ---------------------------------- Attachment: TransactionSynchronizationRegistryImple.java -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: https://jira.jboss.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://jira.jboss.org/jira/browse/JBTM-664?page=com.atlassian.jira.plugi... ] Olivier BILLIARD commented on JBTM-664: --------------------------------------- I'm dealing with a communication problem between Spring and Jboss related to he JTA transaction management. I first thought it was a Spring error but it only seems to be a different way of dealing with the specification. This is too often the case, specification should be enough clear to forbid interpretation. I'm in the middle of the bridge :). You can tell me it's Spring's problem and Spring can tell me it's yours. Using IllegalStateException seem the best way to me. It doesn't change anything if the exception is catched as a RuntimeException elsewhere in the code and it's just a container for the real exception (RollbackException or SystemException). Keep me posted as soon as possible what you decide. At the moment we're still using the 5.0.1 GA version so I must patch myself the 4.5 GA JBTM version to able to use it with Spring in our environment. The 4.6.1 version, that will maybe contain this patch, only work with the 5.1 GA AS version. I want to keep our patched version alike the code of the next version for this problem. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: https://jira.jboss.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://jira.jboss.org/jira/browse/JBTM-664?page=com.atlassian.jira.plugi... ] Mark Little commented on JBTM-664: ---------------------------------- A transaction is still logically active if in the rollback-only state. That status does not signify that the transaction has begun to terminate. If you assume that STATUS_MARKED_ROLLBACK makes the transaction inactive then by that logic it should be illegal to call setRollbackOnly multiple times (it should throw IllegalStateException subsequently). In fact that isn't the case and as long as the transaction has not terminated, or begun to terminate, it's correct to allow that to be called multiple times. A transaction is considered inactive once it begins the two-phase commit protocol (commit is called) or is rolled back. I think the JTA 1.1 update author(s) made the already poorly written JTA worse in this regard: registerInterposedSynchronization should have the same signature in terms of exceptions as registerSynchronization. We should consider raising this with Sun if we haven't already. In the meantime I think Jonathan is right and the best recourse is to subtype IllegalStateException so that information is not lost. There's a reason we chose to throw TRANSACTION_ROLLEBACK in OTS and hence in JTA! -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: https://jira.jboss.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://jira.jboss.org/jira/browse/JBTM-664?page=com.atlassian.jira.plugi... ] Mark Little updated JBTM-664: ----------------------------- Fix Version/s: 4.10.0 -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: https://jira.jboss.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://jira.jboss.org/jira/browse/JBTM-664?page=com.atlassian.jira.plugi... ] Jonathan Halliday reopened JBTM-664: ------------------------------------ Assignee: Jonathan Halliday (was: Mark Little) reopening for backport -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: https://jira.jboss.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://jira.jboss.org/jira/browse/JBTM-664?page=com.atlassian.jira.plugi... ] Jonathan Halliday closed JBTM-664. ---------------------------------- Resolution: Done -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: https://jira.jboss.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira