Author: darran.lofthouse(a)jboss.com Date: 2007-04-26 18:38:29 -0400 (Thu, 26 Apr 2007) New Revision: 2935 Modified: branches/jbossws-1.2.0.GA_JBWS-1610/jbossws-core/src/main/java/org/jboss/ws/core/soap/SOAPFactoryImpl.java branches/jbossws-1.2.0.GA_JBWS-1610/jbossws-tests/src/main/java/org/jboss/test/ws/common/soap/MessageFactoryTestCase.java Log: JBWS-1610 - Prevent soap body elements being added twice. Modified: branches/jbossws-1.2.0.GA_JBWS-1610/jbossws-core/src/main/java/org/jboss/ws/core/soap/SOAPFactoryImpl.java =================================================================== --- branches/jbossws-1.2.0.GA_JBWS-1610/jbossws-core/src/main/java/org/jboss/ws/core/soap/SOAPFactoryImpl.java 2007-04-26 19:01:58 UTC (rev 2934) +++ branches/jbossws-1.2.0.GA_JBWS-1610/jbossws-core/src/main/java/org/jboss/ws/core/soap/SOAPFactoryImpl.java 2007-04-26 22:38:29 UTC (rev 2935) @@ -103,7 +103,8 @@ if (domElement == null) throw new IllegalArgumentException("Source node cannot be null"); - if (domElement instanceof SOAPElement) + // Can only use this optimization if we are doing a deep copy. + if (domElement instanceof SOAPElement && deep==true) return (SOAPElement)domElement; String localName = domElement.getLocalName(); Modified: branches/jbossws-1.2.0.GA_JBWS-1610/jbossws-tests/src/main/java/org/jboss/test/ws/common/soap/MessageFactoryTestCase.java =================================================================== --- branches/jbossws-1.2.0.GA_JBWS-1610/jbossws-tests/src/main/java/org/jboss/test/ws/common/soap/MessageFactoryTestCase.java 2007-04-26 19:01:58 UTC (rev 2934) +++ branches/jbossws-1.2.0.GA_JBWS-1610/jbossws-tests/src/main/java/org/jboss/test/ws/common/soap/MessageFactoryTestCase.java 2007-04-26 22:38:29 UTC (rev 2935) @@ -127,7 +127,7 @@ assertEquals(Constants.NS_SOAP11_ENV, env.getNamespaceURI()); } - public void testSetContentOnSOAPPart() throws Exception + public void testSetContentOnSOAPPart_StreamSource() throws Exception { String expMsg = "<soapenv:Envelope xmlns:soapenv='http://schemas.xmlsoap.org/soap/envelope/'>" + @@ -153,6 +153,34 @@ assertEquals(DOMUtils.parse(expMsg), DOMUtils.parse(wasMsg)); } + public void testSetContentOnSOAPPart_DOMSource() throws Exception + { + String expMsg = + "<soapenv:Envelope xmlns:soapenv='http://schemas.xmlsoap.org/soap/envelope/'>" + + " <soapenv:Header/>" + + " <soapenv:Body>" + + " <HelloResponse xmlns='http://helloservice.org/types\'>" + + " <argument>responseBean</argument>" + + " </HelloResponse>" + + " </soapenv:Body>" + + "</soapenv:Envelope>"; + + MessageFactory factory = new MessageFactoryImpl(); + + ByteArrayInputStream inputStream = new ByteArrayInputStream(expMsg.getBytes()); + SOAPMessage soapMsg = factory.createMessage(null, inputStream); + + SOAPMessage message = factory.createMessage(); + message.getSOAPPart().setContent(soapMsg.getSOAPPart().getContent()); + message.saveChanges(); + + ByteArrayOutputStream baos = new ByteArrayOutputStream(); + message.writeTo(baos); + String wasMsg = new String(baos.toByteArray()); + + assertEquals(DOMUtils.parse(expMsg), DOMUtils.parse(wasMsg)); + } + // [JBWS-1511] MessageFactory does not preserve comments public void testPreserveComments() throws Exception {