Author: asoldano
Date: 2014-11-12 09:21:57 -0500 (Wed, 12 Nov 2014)
New Revision: 19101
Modified:
stack/cxf/trunk/modules/testsuite/cxf-tests/src/test/java/org/jboss/test/ws/jaxws/cxf/jbws3813/JBWS3813AnnotationTestCase.java
stack/cxf/trunk/modules/testsuite/cxf-tests/src/test/java/org/jboss/test/ws/jaxws/cxf/jbws3813/JBWS3813TestCase.java
Log:
[JBWS-3813] Minor fix to the testcase to avoid mislieading failure reports
Modified:
stack/cxf/trunk/modules/testsuite/cxf-tests/src/test/java/org/jboss/test/ws/jaxws/cxf/jbws3813/JBWS3813AnnotationTestCase.java
===================================================================
---
stack/cxf/trunk/modules/testsuite/cxf-tests/src/test/java/org/jboss/test/ws/jaxws/cxf/jbws3813/JBWS3813AnnotationTestCase.java 2014-11-12
04:51:57 UTC (rev 19100)
+++
stack/cxf/trunk/modules/testsuite/cxf-tests/src/test/java/org/jboss/test/ws/jaxws/cxf/jbws3813/JBWS3813AnnotationTestCase.java 2014-11-12
14:21:57 UTC (rev 19101)
@@ -60,16 +60,14 @@
URL wsdlURL = new URL(endPtAddress + "?wsdl");
Service service = Service.create(wsdlURL, serviceName);
EndpointOne proxy = service.getPort(EndpointOne.class);
- boolean isFailed = false;
try
{
proxy.echo("foo");
+ fail("test did not fail as required");
} catch (javax.xml.ws.soap.SOAPFaultException ex) {
String text =
ex.getFault().getDetail().getFirstChild().getFirstChild().getTextContent();
- isFailed = text.startsWith("java.lang.RuntimeException : my error");
- assertTrue("stack data not found", isFailed);
- } finally {
- assertTrue("test did not fail as required", isFailed);
+ assertTrue("stack data not found",
text.contains(EndpointTwoImpl.class.getName()));
+ assertTrue("Root exception name not found",
text.startsWith("java.lang.RuntimeException : my error"));
}
}
}
Modified:
stack/cxf/trunk/modules/testsuite/cxf-tests/src/test/java/org/jboss/test/ws/jaxws/cxf/jbws3813/JBWS3813TestCase.java
===================================================================
---
stack/cxf/trunk/modules/testsuite/cxf-tests/src/test/java/org/jboss/test/ws/jaxws/cxf/jbws3813/JBWS3813TestCase.java 2014-11-12
04:51:57 UTC (rev 19100)
+++
stack/cxf/trunk/modules/testsuite/cxf-tests/src/test/java/org/jboss/test/ws/jaxws/cxf/jbws3813/JBWS3813TestCase.java 2014-11-12
14:21:57 UTC (rev 19101)
@@ -16,20 +16,22 @@
*/
package org.jboss.test.ws.jaxws.cxf.jbws3813;
+import java.io.File;
+import java.net.URL;
+import java.util.LinkedList;
+import java.util.List;
+
+import javax.xml.namespace.QName;
+import javax.xml.ws.Service;
+
import junit.framework.Test;
+
import org.jboss.shrinkwrap.api.asset.FileAsset;
import org.jboss.wsf.test.JBossWSTest;
import org.jboss.wsf.test.JBossWSTestHelper;
import org.jboss.wsf.test.JBossWSTestHelper.BaseDeployment;
import org.jboss.wsf.test.JBossWSTestSetup;
-import javax.xml.namespace.QName;
-import javax.xml.ws.Service;
-import java.io.File;
-import java.net.URL;
-import java.util.LinkedList;
-import java.util.List;
-
public class JBWS3813TestCase extends JBossWSTest
{
public static BaseDeployment<?>[] createDeployments() {
@@ -59,16 +61,14 @@
URL wsdlURL = new URL(endPtAddress + "?wsdl");
Service service = Service.create(wsdlURL, serviceName);
EndpointOne proxy = service.getPort(EndpointOne.class);
- boolean isFailed = false;
try
{
proxy.echo("foo");
+ fail("test did not fail as required");
} catch (javax.xml.ws.soap.SOAPFaultException ex) {
String text =
ex.getFault().getDetail().getFirstChild().getFirstChild().getTextContent();
- isFailed = text.startsWith("java.lang.RuntimeException : my error");
- assertTrue("stack data not found", isFailed);
- } finally {
- assertTrue("test did not fail as required", isFailed);
+ assertTrue("stack data not found",
text.contains(EndpointOneImpl.class.getName()));
+ assertTrue("Root exception name not found",
text.startsWith("java.lang.RuntimeException : my error"));
}
}
}
Show replies by date