JBoss Rich Faces SVN: r16056 - root/cdk/trunk.
by richfaces-svn-commits@lists.jboss.org
Author: Alex.Kolonitsky
Date: 2009-12-03 10:51:56 -0500 (Thu, 03 Dec 2009)
New Revision: 16056
Modified:
root/cdk/trunk/pom.xml
Log:
RFPL-195 Code style policy
Rename checkstyle file and folder
Modified: root/cdk/trunk/pom.xml
===================================================================
--- root/cdk/trunk/pom.xml 2009-12-03 15:50:15 UTC (rev 16055)
+++ root/cdk/trunk/pom.xml 2009-12-03 15:51:56 UTC (rev 16056)
@@ -130,7 +130,7 @@
<execution>
<id>richfaces-checkstyle-report</id>
<configuration>
- <configLocation>exadel-richfaces-checkstyle/exadel+sun-checkstyle.xml</configLocation>
+ <configLocation>richfaces-checkstyle/richfaces-checkstyle.xml</configLocation>
<suppressionsLocation>checkstyle-suppressions.xml</suppressionsLocation>
<failOnViolation>false</failOnViolation>
@@ -154,7 +154,7 @@
<version>2.3</version>
<configuration>
- <configLocation>exadel-richfaces-checkstyle/exadel+sun-checkstyle.xml</configLocation>
+ <configLocation>richfaces-checkstyle/richfaces-checkstyle.xml</configLocation>
<suppressionsLocation>checkstyle-suppressions.xml</suppressionsLocation>
</configuration>
</plugin>
14 years, 5 months
JBoss Rich Faces SVN: r16055 - root/checkstyle/src/main/resources.
by richfaces-svn-commits@lists.jboss.org
Author: Alex.Kolonitsky
Date: 2009-12-03 10:50:15 -0500 (Thu, 03 Dec 2009)
New Revision: 16055
Added:
root/checkstyle/src/main/resources/richfaces-checkstyle/
Removed:
root/checkstyle/src/main/resources/exadel-richfaces-checkstyle/
Log:
RFPL-195 Code style policy
Rename checkstyle folder
Copied: root/checkstyle/src/main/resources/richfaces-checkstyle (from rev 16054, root/checkstyle/src/main/resources/exadel-richfaces-checkstyle)
14 years, 5 months
JBoss Rich Faces SVN: r16054 - root/checkstyle/src/main/resources/exadel-richfaces-checkstyle.
by richfaces-svn-commits@lists.jboss.org
Author: Alex.Kolonitsky
Date: 2009-12-03 10:35:12 -0500 (Thu, 03 Dec 2009)
New Revision: 16054
Added:
root/checkstyle/src/main/resources/exadel-richfaces-checkstyle/richfaces-checkstyle.xml
Removed:
root/checkstyle/src/main/resources/exadel-richfaces-checkstyle/exadel+sun-checkstyle.xml
Log:
RFPL-195 Code style policy
Rename checkstyle file
Deleted: root/checkstyle/src/main/resources/exadel-richfaces-checkstyle/exadel+sun-checkstyle.xml
===================================================================
--- root/checkstyle/src/main/resources/exadel-richfaces-checkstyle/exadel+sun-checkstyle.xml 2009-12-03 15:09:52 UTC (rev 16053)
+++ root/checkstyle/src/main/resources/exadel-richfaces-checkstyle/exadel+sun-checkstyle.xml 2009-12-03 15:35:12 UTC (rev 16054)
@@ -1,316 +0,0 @@
-<?xml version="1.0" encoding="UTF-8"?>
-
-<!DOCTYPE module PUBLIC "-//Puppy Crawl//DTD Check Configuration 1.2//EN"
- "http://www.puppycrawl.com/dtds/configuration_1_2.dtd">
-<module name="Checker">
- <property name="severity" value="error"/>
- <module name="Translation"/>
- <!--<module name="FileLength">-->
- <!--<property name="max" value="1000"/>-->
- <!--<property name="severity" value="warning"/>-->
- <!--</module>-->
-
- <module name="TreeWalker">
- <property name="severity" value="error"/>
-
- <!-- Checks for Javadoc comments. -->
- <!-- See http://checkstyle.sourceforge.net/config_javadoc.html -->
- <module name="JavadocMethod">
- <property name="scope" value="public"/>
- <property name="severity" value="warning"/>
- </module>
- <module name="JavadocType">
- <property name="severity" value="warning"/>
- </module>
- <module name="JavadocVariable">
- <property name="scope" value="public"/>
- <property name="severity" value="warning"/>
- </module>
- <module name="JavadocStyle">
- <property name="checkEmptyJavadoc" value="true"/>
- <property name="checkFirstSentence" value="false"/>
- <property name="severity" value="warning"/>
- </module>
- </module>
-
- <module name="TreeWalker">
- <!-- Checks for Naming Conventions. -->
- <!-- See http://checkstyle.sourceforge.net/config_naming.html -->
- <module name="ConstantName">
- <property name="severity" value="error"/>
- </module>
- <module name="LocalFinalVariableName">
- <property name="severity" value="error"/>
- </module>
- <module name="LocalVariableName">
- <property name="severity" value="error"/>
- </module>
- <module name="MemberName">
- <property name="severity" value="error"/>
- </module>
- <module name="MethodName">
- <property name="severity" value="error"/>
- </module>
- <module name="PackageName">
- <property name="severity" value="error"/>
- </module>
- <module name="ParameterName">
- <property name="severity" value="error"/>
- </module>
- <module name="StaticVariableName">
- <property name="severity" value="error"/>
- </module>
- <module name="TypeName">
- <property name="severity" value="error"/>
- </module>
- </module>
-
- <module name="TreeWalker">
- <!-- Checks for imports -->
- <!-- See http://checkstyle.sourceforge.net/config_import.html -->
- <module name="AvoidStarImport">
- <property name="severity" value="warning"/>
- </module>
- <module name="IllegalImport">
- <property name="severity" value="error"/>
- </module>
- <module name="RedundantImport">
- <property name="severity" value="error"/>
- </module>
- <module name="UnusedImports">
- <property name="severity" value="error"/>
- </module>
- </module>
-
- <module name="TreeWalker">
- <!-- Checks for Size Violations. -->
- <!-- See http://checkstyle.sourceforge.net/config_sizes.html -->
- <module name="LineLength">
- <property name="max" value="120"/>
- <property name="severity" value="warning"/>
- </module>
- <module name="MethodLength">
- <property name="tokens" value="METHOD_DEF"/>
- <property name="max" value="60"/>
- <!-- I think must be 30 -->
- <property name="countEmpty" value="false"/>
- <property name="severity" value="warning"/>
- </module>
- <module name="AnonInnerLength">
- <property name="max" value="40"/>
- <property name="severity" value="error"/>
- </module>
- <module name="ParameterNumber">
- <property name="severity" value="warning"/>
- </module>
- </module>
-
- <module name="TreeWalker">
- <!-- Checks for whitespace -->
- <!-- See http://checkstyle.sourceforge.net/config_whitespace.html -->
- <!--<module name="TabCharacter"/>-->
- <module name="EmptyForIteratorPad">
- <property name="severity" value="info"/>
- </module>
- <module name="MethodParamPad">
- <property name="severity" value="info"/>
- </module>
- <module name="NoWhitespaceAfter">
- <property name="severity" value="info"/>
- </module>
- <module name="NoWhitespaceBefore">
- <property name="severity" value="info"/>
- </module>
- <module name="OperatorWrap">
- <property name="severity" value="info"/>
- </module>
- <module name="ParenPad">
- <property name="severity" value="info"/>
- </module>
- <module name="TypecastParenPad">
- <property name="tokens" value="RPAREN,TYPECAST"/>
- <property name="severity" value="info"/>
- </module>
- <module name="WhitespaceAfter">
- <property name="severity" value="info"/>
- </module>
- <module name="WhitespaceAround">
- <property name="tokens"
- value="ASSIGN,BAND,BAND_ASSIGN,BOR,BOR_ASSIGN,BSR,BSR_ASSIGN,
- BXOR,BXOR_ASSIGN,COLON,DIV,DIV_ASSIGN,EQUAL,GE,GT,LAND,LE,LITERAL_ASSERT,
- LITERAL_CATCH,LITERAL_DO,LITERAL_ELSE,LITERAL_FINALLY,LITERAL_FOR,LITERAL_IF,
- LITERAL_RETURN,LITERAL_SYNCHRONIZED,LITERAL_TRY,LITERAL_WHILE,LOR,LT,MINUS,MINUS_ASSIGN,
- MOD,MOD_ASSIGN,NOT_EQUAL,PLUS,PLUS_ASSIGN,QUESTION,SL,SLIST,SL_ASSIGN,SR,
- SR_ASSIGN,STAR,STAR_ASSIGN,LITERAL_ASSERT,TYPE_EXTENSION_AND"/>
- <property name="severity" value="info"/>
- </module>
- </module>
-
- <module name="TreeWalker">
- <!-- Modifier Checks -->
- <!-- See http://checkstyle.sourceforge.net/config_modifier.html -->
- <module name="ModifierOrder">
- <property name="severity" value="error"/>
- </module>
- <module name="RedundantModifier">
- <property name="severity" value="info"/>
- </module>
-
- <!-- Checks for blocks. You know, those {}'s -->
- <!-- http://checkstyle.sourceforge.net/config_blocks.html -->
- <module name="AvoidNestedBlocks">
- <property name="allowInSwitchCase" value="true"/>
- <property name="severity" value="error"/>
- </module>
- <module name="EmptyBlock">
- <property name="option" value="text"/>
- <property name="severity" value="error"/>
- </module>
- <module name="LeftCurly">
- <property name="severity" value="error"/>
- </module>
- <module name="NeedBraces">
- <property name="severity" value="error"/>
- </module>
- <module name="RightCurly">
- <property name="severity" value="error"/>
- </module>
- </module>
-
- <module name="TreeWalker">
- <!-- Checks for common coding problems -->
- <!-- See http://checkstyle.sourceforge.net/config_coding.html -->
- <module name="CovariantEquals">
- <property name="severity" value="error"/>
- </module>
- <module name="DoubleCheckedLocking">
- <property name="severity" value="error"/>
- </module>
- <module name="EmptyStatement">
- <property name="severity" value="error"/>
- </module>
- <module name="EqualsHashCode">
- <property name="severity" value="error"/>
- </module>
- <module name="IllegalInstantiation">
- <property name="severity" value="error"/>
- </module>
- <module name="InnerAssignment">
- <property name="severity" value="error"/>
- </module>
- <module name="MagicNumber">
- <property name="ignoreNumbers" value="-1, 0, 1"/>
- <property name="severity" value="warning"/>
- <!-- TODO <property name="severity" value="error"/> -->
- </module>
- <module name="MissingSwitchDefault">
- <property name="severity" value="error"/>
- </module>
- <module name="ModifiedControlVariable">
- <property name="severity" value="error"/>
- </module>
- <module name="RedundantThrows">
- <property name="severity" value="warning"/>
- <!-- TODO <property name="severity" value="error"/>-->
- </module>
- <module name="SimplifyBooleanExpression">
- <property name="severity" value="error"/>
- </module>
- <module name="SimplifyBooleanReturn">
- <property name="severity" value="error"/>
- </module>
- <module name="StringLiteralEquality">
- <property name="severity" value="error"/>
- </module>
- <module name="NestedIfDepth">
- <property name="max" value="3"/>
- <property name="severity" value="warning"/>
- </module>
- <module name="NestedTryDepth">
- <property name="max" value="3"/>
- <property name="severity" value="error"/>
- </module>
- <module name="IllegalCatch">
- <property name="illegalClassNames"
- value="java.lang.Throwable, java.lang.RuntimeException, java.lang.Error"/>
- <property name="severity" value="error"/>
- </module>
- <module name="IllegalThrows"/>
- <module name="ParameterAssignment">
- <property name="severity" value="warning"/>
- <!-- TODO <property name="severity" value="error"/>-->
- </module>
- <module name="DefaultComesLast">
- <property name="severity" value="error"/>
- </module>
- <module name="FallThrough">
- <property name="severity" value="error"/>
- </module>
- <module name="MultipleVariableDeclarations">
- <property name="severity" value="error"/>
- </module>
- <module name="UnnecessaryParentheses">
- <property name="severity" value="info"/>
- </module>
- </module>
-
- <module name="TreeWalker">
- <!-- Checks for class design -->
- <!-- See http://checkstyle.sourceforge.net/config_design.html -->
- <module name="FinalClass">
- <property name="severity" value="error"/>
- </module>
- <module name="HideUtilityClassConstructor">
- <property name="severity" value="error"/>
- </module>
- <module name="InterfaceIsType">
- <property name="severity" value="warning"/>
- </module>
- <module name="VisibilityModifier">
- <property name="packageAllowed" value="true"/>
- <property name="protectedAllowed" value="true"/>
- <property name="severity" value="error"/>
- </module>
- </module>
-
- <module name="TreeWalker">
- <!-- Miscellaneous other checks. -->
- <!-- See http://checkstyle.sourceforge.net/config_metrics.html -->
- <module name="CyclomaticComplexity">
- <property name="severity" value="warning"/>
- </module>
-
- <!-- Miscellaneous other checks. -->
- <!-- See http://checkstyle.sf.net/config_misc.html -->
- <module name="ArrayTypeStyle">
- <property name="severity" value="error"/>
- </module>
- <module name="UpperEll">
- <property name="severity" value="error"/>
- </module>
- <module name="ParameterName">
- <property name="severity" value="error"/>
- </module>
- <module name="DeclarationOrder">
- <property name="severity" value="error"/>
- </module>
- <module name="FallThrough">
- <property name="severity" value="error"/>
- </module>
- <module name="HiddenField">
- <property name="tokens" value="VARIABLE_DEF"/>
- <property name="severity" value="info"/>
- </module>
- <module name="UncommentedMain">
- <property name="severity" value="warning"/>
- </module>
- <module name="TodoComment">
- <property name="format" value="TODO"/>
- <property name="severity" value="warning"/>
- </module>
-
- <module name="Indentation">
- <property name="severity" value="error"/>
- </module>
- </module>
-</module>
Copied: root/checkstyle/src/main/resources/exadel-richfaces-checkstyle/richfaces-checkstyle.xml (from rev 16052, root/checkstyle/src/main/resources/exadel-richfaces-checkstyle/exadel+sun-checkstyle.xml)
===================================================================
--- root/checkstyle/src/main/resources/exadel-richfaces-checkstyle/richfaces-checkstyle.xml (rev 0)
+++ root/checkstyle/src/main/resources/exadel-richfaces-checkstyle/richfaces-checkstyle.xml 2009-12-03 15:35:12 UTC (rev 16054)
@@ -0,0 +1,316 @@
+<?xml version="1.0" encoding="UTF-8"?>
+
+<!DOCTYPE module PUBLIC "-//Puppy Crawl//DTD Check Configuration 1.2//EN"
+ "http://www.puppycrawl.com/dtds/configuration_1_2.dtd">
+<module name="Checker">
+ <property name="severity" value="error"/>
+ <module name="Translation"/>
+ <!--<module name="FileLength">-->
+ <!--<property name="max" value="1000"/>-->
+ <!--<property name="severity" value="warning"/>-->
+ <!--</module>-->
+
+ <module name="TreeWalker">
+ <property name="severity" value="error"/>
+
+ <!-- Checks for Javadoc comments. -->
+ <!-- See http://checkstyle.sourceforge.net/config_javadoc.html -->
+ <module name="JavadocMethod">
+ <property name="scope" value="public"/>
+ <property name="severity" value="warning"/>
+ </module>
+ <module name="JavadocType">
+ <property name="severity" value="warning"/>
+ </module>
+ <module name="JavadocVariable">
+ <property name="scope" value="public"/>
+ <property name="severity" value="warning"/>
+ </module>
+ <module name="JavadocStyle">
+ <property name="checkEmptyJavadoc" value="true"/>
+ <property name="checkFirstSentence" value="false"/>
+ <property name="severity" value="warning"/>
+ </module>
+ </module>
+
+ <module name="TreeWalker">
+ <!-- Checks for Naming Conventions. -->
+ <!-- See http://checkstyle.sourceforge.net/config_naming.html -->
+ <module name="ConstantName">
+ <property name="severity" value="error"/>
+ </module>
+ <module name="LocalFinalVariableName">
+ <property name="severity" value="error"/>
+ </module>
+ <module name="LocalVariableName">
+ <property name="severity" value="error"/>
+ </module>
+ <module name="MemberName">
+ <property name="severity" value="error"/>
+ </module>
+ <module name="MethodName">
+ <property name="severity" value="error"/>
+ </module>
+ <module name="PackageName">
+ <property name="severity" value="error"/>
+ </module>
+ <module name="ParameterName">
+ <property name="severity" value="error"/>
+ </module>
+ <module name="StaticVariableName">
+ <property name="severity" value="error"/>
+ </module>
+ <module name="TypeName">
+ <property name="severity" value="error"/>
+ </module>
+ </module>
+
+ <module name="TreeWalker">
+ <!-- Checks for imports -->
+ <!-- See http://checkstyle.sourceforge.net/config_import.html -->
+ <module name="AvoidStarImport">
+ <property name="severity" value="warning"/>
+ </module>
+ <module name="IllegalImport">
+ <property name="severity" value="error"/>
+ </module>
+ <module name="RedundantImport">
+ <property name="severity" value="error"/>
+ </module>
+ <module name="UnusedImports">
+ <property name="severity" value="error"/>
+ </module>
+ </module>
+
+ <module name="TreeWalker">
+ <!-- Checks for Size Violations. -->
+ <!-- See http://checkstyle.sourceforge.net/config_sizes.html -->
+ <module name="LineLength">
+ <property name="max" value="120"/>
+ <property name="severity" value="warning"/>
+ </module>
+ <module name="MethodLength">
+ <property name="tokens" value="METHOD_DEF"/>
+ <property name="max" value="60"/>
+ <!-- I think must be 30 -->
+ <property name="countEmpty" value="false"/>
+ <property name="severity" value="warning"/>
+ </module>
+ <module name="AnonInnerLength">
+ <property name="max" value="40"/>
+ <property name="severity" value="error"/>
+ </module>
+ <module name="ParameterNumber">
+ <property name="severity" value="warning"/>
+ </module>
+ </module>
+
+ <module name="TreeWalker">
+ <!-- Checks for whitespace -->
+ <!-- See http://checkstyle.sourceforge.net/config_whitespace.html -->
+ <!--<module name="TabCharacter"/>-->
+ <module name="EmptyForIteratorPad">
+ <property name="severity" value="info"/>
+ </module>
+ <module name="MethodParamPad">
+ <property name="severity" value="info"/>
+ </module>
+ <module name="NoWhitespaceAfter">
+ <property name="severity" value="info"/>
+ </module>
+ <module name="NoWhitespaceBefore">
+ <property name="severity" value="info"/>
+ </module>
+ <module name="OperatorWrap">
+ <property name="severity" value="info"/>
+ </module>
+ <module name="ParenPad">
+ <property name="severity" value="info"/>
+ </module>
+ <module name="TypecastParenPad">
+ <property name="tokens" value="RPAREN,TYPECAST"/>
+ <property name="severity" value="info"/>
+ </module>
+ <module name="WhitespaceAfter">
+ <property name="severity" value="info"/>
+ </module>
+ <module name="WhitespaceAround">
+ <property name="tokens"
+ value="ASSIGN,BAND,BAND_ASSIGN,BOR,BOR_ASSIGN,BSR,BSR_ASSIGN,
+ BXOR,BXOR_ASSIGN,COLON,DIV,DIV_ASSIGN,EQUAL,GE,GT,LAND,LE,LITERAL_ASSERT,
+ LITERAL_CATCH,LITERAL_DO,LITERAL_ELSE,LITERAL_FINALLY,LITERAL_FOR,LITERAL_IF,
+ LITERAL_RETURN,LITERAL_SYNCHRONIZED,LITERAL_TRY,LITERAL_WHILE,LOR,LT,MINUS,MINUS_ASSIGN,
+ MOD,MOD_ASSIGN,NOT_EQUAL,PLUS,PLUS_ASSIGN,QUESTION,SL,SLIST,SL_ASSIGN,SR,
+ SR_ASSIGN,STAR,STAR_ASSIGN,LITERAL_ASSERT,TYPE_EXTENSION_AND"/>
+ <property name="severity" value="info"/>
+ </module>
+ </module>
+
+ <module name="TreeWalker">
+ <!-- Modifier Checks -->
+ <!-- See http://checkstyle.sourceforge.net/config_modifier.html -->
+ <module name="ModifierOrder">
+ <property name="severity" value="error"/>
+ </module>
+ <module name="RedundantModifier">
+ <property name="severity" value="info"/>
+ </module>
+
+ <!-- Checks for blocks. You know, those {}'s -->
+ <!-- http://checkstyle.sourceforge.net/config_blocks.html -->
+ <module name="AvoidNestedBlocks">
+ <property name="allowInSwitchCase" value="true"/>
+ <property name="severity" value="error"/>
+ </module>
+ <module name="EmptyBlock">
+ <property name="option" value="text"/>
+ <property name="severity" value="error"/>
+ </module>
+ <module name="LeftCurly">
+ <property name="severity" value="error"/>
+ </module>
+ <module name="NeedBraces">
+ <property name="severity" value="error"/>
+ </module>
+ <module name="RightCurly">
+ <property name="severity" value="error"/>
+ </module>
+ </module>
+
+ <module name="TreeWalker">
+ <!-- Checks for common coding problems -->
+ <!-- See http://checkstyle.sourceforge.net/config_coding.html -->
+ <module name="CovariantEquals">
+ <property name="severity" value="error"/>
+ </module>
+ <module name="DoubleCheckedLocking">
+ <property name="severity" value="error"/>
+ </module>
+ <module name="EmptyStatement">
+ <property name="severity" value="error"/>
+ </module>
+ <module name="EqualsHashCode">
+ <property name="severity" value="error"/>
+ </module>
+ <module name="IllegalInstantiation">
+ <property name="severity" value="error"/>
+ </module>
+ <module name="InnerAssignment">
+ <property name="severity" value="error"/>
+ </module>
+ <module name="MagicNumber">
+ <property name="ignoreNumbers" value="-1, 0, 1"/>
+ <property name="severity" value="warning"/>
+ <!-- TODO <property name="severity" value="error"/> -->
+ </module>
+ <module name="MissingSwitchDefault">
+ <property name="severity" value="error"/>
+ </module>
+ <module name="ModifiedControlVariable">
+ <property name="severity" value="error"/>
+ </module>
+ <module name="RedundantThrows">
+ <property name="severity" value="warning"/>
+ <!-- TODO <property name="severity" value="error"/>-->
+ </module>
+ <module name="SimplifyBooleanExpression">
+ <property name="severity" value="error"/>
+ </module>
+ <module name="SimplifyBooleanReturn">
+ <property name="severity" value="error"/>
+ </module>
+ <module name="StringLiteralEquality">
+ <property name="severity" value="error"/>
+ </module>
+ <module name="NestedIfDepth">
+ <property name="max" value="3"/>
+ <property name="severity" value="warning"/>
+ </module>
+ <module name="NestedTryDepth">
+ <property name="max" value="3"/>
+ <property name="severity" value="error"/>
+ </module>
+ <module name="IllegalCatch">
+ <property name="illegalClassNames"
+ value="java.lang.Throwable, java.lang.RuntimeException, java.lang.Error"/>
+ <property name="severity" value="error"/>
+ </module>
+ <module name="IllegalThrows"/>
+ <module name="ParameterAssignment">
+ <property name="severity" value="warning"/>
+ <!-- TODO <property name="severity" value="error"/>-->
+ </module>
+ <module name="DefaultComesLast">
+ <property name="severity" value="error"/>
+ </module>
+ <module name="FallThrough">
+ <property name="severity" value="error"/>
+ </module>
+ <module name="MultipleVariableDeclarations">
+ <property name="severity" value="error"/>
+ </module>
+ <module name="UnnecessaryParentheses">
+ <property name="severity" value="info"/>
+ </module>
+ </module>
+
+ <module name="TreeWalker">
+ <!-- Checks for class design -->
+ <!-- See http://checkstyle.sourceforge.net/config_design.html -->
+ <module name="FinalClass">
+ <property name="severity" value="error"/>
+ </module>
+ <module name="HideUtilityClassConstructor">
+ <property name="severity" value="error"/>
+ </module>
+ <module name="InterfaceIsType">
+ <property name="severity" value="warning"/>
+ </module>
+ <module name="VisibilityModifier">
+ <property name="packageAllowed" value="true"/>
+ <property name="protectedAllowed" value="true"/>
+ <property name="severity" value="error"/>
+ </module>
+ </module>
+
+ <module name="TreeWalker">
+ <!-- Miscellaneous other checks. -->
+ <!-- See http://checkstyle.sourceforge.net/config_metrics.html -->
+ <module name="CyclomaticComplexity">
+ <property name="severity" value="warning"/>
+ </module>
+
+ <!-- Miscellaneous other checks. -->
+ <!-- See http://checkstyle.sf.net/config_misc.html -->
+ <module name="ArrayTypeStyle">
+ <property name="severity" value="error"/>
+ </module>
+ <module name="UpperEll">
+ <property name="severity" value="error"/>
+ </module>
+ <module name="ParameterName">
+ <property name="severity" value="error"/>
+ </module>
+ <module name="DeclarationOrder">
+ <property name="severity" value="error"/>
+ </module>
+ <module name="FallThrough">
+ <property name="severity" value="error"/>
+ </module>
+ <module name="HiddenField">
+ <property name="tokens" value="VARIABLE_DEF"/>
+ <property name="severity" value="info"/>
+ </module>
+ <module name="UncommentedMain">
+ <property name="severity" value="warning"/>
+ </module>
+ <module name="TodoComment">
+ <property name="format" value="TODO"/>
+ <property name="severity" value="warning"/>
+ </module>
+
+ <module name="Indentation">
+ <property name="severity" value="error"/>
+ </module>
+ </module>
+</module>
14 years, 5 months
JBoss Rich Faces SVN: r16053 - in root/ui-sandbox/trunk/components/tables/ui/src/main: java/org/richfaces/component/state and 3 other directories.
by richfaces-svn-commits@lists.jboss.org
Author: abelevich
Date: 2009-12-03 10:09:52 -0500 (Thu, 03 Dec 2009)
New Revision: 16053
Modified:
root/ui-sandbox/trunk/components/tables/ui/src/main/java/org/richfaces/component/UISubTable.java
root/ui-sandbox/trunk/components/tables/ui/src/main/java/org/richfaces/component/state/DataTableState.java
root/ui-sandbox/trunk/components/tables/ui/src/main/java/org/richfaces/model/visual/impl/ColumnVisualModelImpl.java
root/ui-sandbox/trunk/components/tables/ui/src/main/java/org/richfaces/renderkit/ToggleControlRendererBase.java
root/ui-sandbox/trunk/components/tables/ui/src/main/resources/META-INF/resources/toggler.js
Log:
add client toggle support
Modified: root/ui-sandbox/trunk/components/tables/ui/src/main/java/org/richfaces/component/UISubTable.java
===================================================================
--- root/ui-sandbox/trunk/components/tables/ui/src/main/java/org/richfaces/component/UISubTable.java 2009-12-03 13:19:01 UTC (rev 16052)
+++ root/ui-sandbox/trunk/components/tables/ui/src/main/java/org/richfaces/component/UISubTable.java 2009-12-03 15:09:52 UTC (rev 16053)
@@ -27,7 +27,6 @@
import javax.faces.component.UIComponent;
import javax.faces.context.FacesContext;
import javax.faces.event.AbortProcessingException;
-import javax.faces.event.ComponentSystemEventListener;
import javax.faces.event.FacesEvent;
import javax.faces.event.PhaseId;
@@ -46,7 +45,7 @@
*
*/
-public abstract class UISubTable extends UIDataTableBase implements Row, Column, Expandable, ComponentSystemEventListener {
+public abstract class UISubTable extends UIDataTableBase implements Row, Column, Expandable {
public static final String COMPONENT_TYPE = "org.richfaces.SubTable";
@@ -62,7 +61,7 @@
private SubTableVisualModel visualModel;
- private DataComponentState componentState;
+ private SubTableState componentState;
enum PropertyKeys {
switchType, expanded, toggleExpression, childState, visualModel
@@ -175,7 +174,7 @@
ValueExpression expression = getValueExpression("componentState");
if(expression != null) {
- componentState = (DataComponentState)expression.getValue(elContext);
+ componentState = (SubTableState)expression.getValue(elContext);
}
if(componentState == null) {
@@ -183,7 +182,10 @@
}
if(componentState == null) {
- componentState = createComponentState();
+ Object state = createComponentState();
+ if(state instanceof SubTableState) {
+ componentState = (SubTableState)state;
+ }
}
if(expression != null && !expression.isReadOnly(elContext)) {
@@ -191,10 +193,7 @@
}
}
- if(componentState instanceof SubTableState) {
- dataTableState.addSubTableState((SubTableState)componentState);
- }
-
+ dataTableState.addSubTableState(componentState);
return componentState;
}
@@ -208,13 +207,64 @@
Object [] state = (Object [])stateObject;
if(state != null) {
super.setIterationState(state[0]);
- this.componentState = (DataComponentState)state[1];
+ this.componentState = (SubTableState)state[1];
} else {
super.setIterationState(state);
this.componentState = null;
}
}
-
+
+/* @Override
+ public Object saveState(FacesContext context) {
+
+ // TODO handle model serialization - "execute" model
+ Boolean componentStateIsStateHolder = null;
+ Object savedComponentState = null;
+
+ // TODO - partial state saving handling
+ if (componentState instanceof StateHolder) {
+ componentStateIsStateHolder = Boolean.TRUE;
+
+ StateHolder stateHolder = (StateHolder) componentState;
+
+ if (!stateHolder.isTransient()) {
+ savedComponentState = stateHolder.saveState(context);
+ }
+ } else {
+ componentStateIsStateHolder = Boolean.FALSE;
+
+ if (componentState instanceof Serializable) {
+ savedComponentState = componentState;
+ }
+ }
+
+ return new Object[] {super.saveState(context), savedComponentState, componentStateIsStateHolder};
+ }
+
+
+ @Override
+ public void restoreState(FacesContext context, Object stateObject) {
+ Object[] state = (Object[]) stateObject;
+
+ // TODO Auto-generated method stub
+ super.restoreState(context, state[0]);
+
+ Object savedComponentState = state[1];
+
+ if (savedComponentState != null) {
+ boolean componentStateIsStateHolder = ((Boolean) state[2]).booleanValue();
+
+ if (componentStateIsStateHolder) {
+ componentState = (SubTableState)createComponentState();
+ ((StateHolder) componentState).restoreState(context, savedComponentState);
+ } else {
+ componentState = (SubTableState) restoreAttachedState(context, savedComponentState);
+ }
+
+ // TODO update state model binding
+ }
+ }
+ */
public void setExpanded(boolean expanded) {
this.expanded = expanded;
}
@@ -246,16 +296,16 @@
if(event instanceof ToggleEvent) {
ToggleEvent toggleEvent = (ToggleEvent)event;
- MethodExpression expression = getToggleListener();
- if(expression != null) {
- expression.invoke(getFacesContext().getELContext(), new Object[]{toggleEvent});
- }
-
//not sure that this is right ... need to discuss
SubTableState state = getCurrentComponentState();
if(event.isAppropriateListener(state)) {
toggleEvent.processListener(state);
}
+
+ MethodExpression expression = getToggleListener();
+ if(expression != null) {
+ expression.invoke(getFacesContext().getELContext(), new Object[]{toggleEvent});
+ }
}
}
Modified: root/ui-sandbox/trunk/components/tables/ui/src/main/java/org/richfaces/component/state/DataTableState.java
===================================================================
--- root/ui-sandbox/trunk/components/tables/ui/src/main/java/org/richfaces/component/state/DataTableState.java 2009-12-03 13:19:01 UTC (rev 16052)
+++ root/ui-sandbox/trunk/components/tables/ui/src/main/java/org/richfaces/component/state/DataTableState.java 2009-12-03 15:09:52 UTC (rev 16053)
@@ -65,7 +65,9 @@
}
public void addSubTableState(SubTableState state) {
- this.subTableStates.put(state.getId(), state);
+ if(state != null) {
+ this.subTableStates.put(state.getId(), state);
+ }
}
public SubTableState getSubTableState(String id) {
Modified: root/ui-sandbox/trunk/components/tables/ui/src/main/java/org/richfaces/model/visual/impl/ColumnVisualModelImpl.java
===================================================================
--- root/ui-sandbox/trunk/components/tables/ui/src/main/java/org/richfaces/model/visual/impl/ColumnVisualModelImpl.java 2009-12-03 13:19:01 UTC (rev 16052)
+++ root/ui-sandbox/trunk/components/tables/ui/src/main/java/org/richfaces/model/visual/impl/ColumnVisualModelImpl.java 2009-12-03 15:09:52 UTC (rev 16053)
@@ -7,4 +7,6 @@
*
*/
public class ColumnVisualModelImpl implements ColumnVisualModel {
+ public ColumnVisualModelImpl() {
+ }
}
Modified: root/ui-sandbox/trunk/components/tables/ui/src/main/java/org/richfaces/renderkit/ToggleControlRendererBase.java
===================================================================
--- root/ui-sandbox/trunk/components/tables/ui/src/main/java/org/richfaces/renderkit/ToggleControlRendererBase.java 2009-12-03 13:19:01 UTC (rev 16052)
+++ root/ui-sandbox/trunk/components/tables/ui/src/main/java/org/richfaces/renderkit/ToggleControlRendererBase.java 2009-12-03 15:09:52 UTC (rev 16053)
@@ -55,7 +55,7 @@
Map<String, String> params = context.getExternalContext().getRequestParameterMap();
- String hiddenId = toggle.getClientId();
+ String hiddenId = toggle.getClientId() + HIDDEN;
String state = params.get(hiddenId);
if(state != null && state.trim().length()> 0) {
@@ -92,8 +92,9 @@
encodeControl(context, writer, toggleControl, switchType, expanded, false);
encodeControl(context, writer, toggleControl, switchType, !expanded, true);
- // encodeHiddenInput(context, writer, toggleControl);
+ encodeHiddenInput(context, writer, toggleControl);
+
}
}
}
Modified: root/ui-sandbox/trunk/components/tables/ui/src/main/resources/META-INF/resources/toggler.js
===================================================================
--- root/ui-sandbox/trunk/components/tables/ui/src/main/resources/META-INF/resources/toggler.js 2009-12-03 13:19:01 UTC (rev 16052)
+++ root/ui-sandbox/trunk/components/tables/ui/src/main/resources/META-INF/resources/toggler.js 2009-12-03 15:09:52 UTC (rev 16053)
@@ -30,16 +30,16 @@
this.command("show", elements);
}
this.state = toState;
- // this.saveState(this.state);
+ this.saveState(this.state);
}
}
Toggle.prototype.saveState= function(state) {
- /*var id = this.hidden;
+ var id = this.hidden;
var element = this.getElement(id);
if(element) {
element.attr('value', state);
- }*/
+ }
}
Toggle.prototype.clientToggle= function(toState){
@@ -47,14 +47,9 @@
}
Toggle.prototype.serverToggle = function(toState) {
- if(mojarra && mojarra.jsfcljs) {
- var form = this.getElement(this.formId);
- var prv = {};
- if(this.id) {
- prv[this.id] = toState;
- mojarra.jsfcljs(form[0],prv,'');
- }
- }
+ this.saveState(toState);
+ var form = this.getElement(this.formId);
+ form.submit();
}
Toggle.prototype.ajaxToggle = function(toState) {
14 years, 5 months
JBoss Rich Faces SVN: r16052 - root/framework/trunk/impl/src/main/resources/META-INF/resources.
by richfaces-svn-commits@lists.jboss.org
Author: nbelaevski
Date: 2009-12-03 08:19:01 -0500 (Thu, 03 Dec 2009)
New Revision: 16052
Modified:
root/framework/trunk/impl/src/main/resources/META-INF/resources/richfaces-queue.js
Log:
Results of code review for queue commit
Modified: root/framework/trunk/impl/src/main/resources/META-INF/resources/richfaces-queue.js
===================================================================
--- root/framework/trunk/impl/src/main/resources/META-INF/resources/richfaces-queue.js 2009-12-03 12:07:35 UTC (rev 16051)
+++ root/framework/trunk/impl/src/main/resources/META-INF/resources/richfaces-queue.js 2009-12-03 13:19:01 UTC (rev 16052)
@@ -13,15 +13,18 @@
richfaces.queue = function(opts){
+ //TODO: naming - class should be called QueueEntry, and first argument is "source", not query
var queueEntry = function(query, event, options) {
this.query = query;
this.options = options || {};
this.event = event;
-
+
+ //similarityGroupingId is mutable, thus we need special field for it
this.similarityGroupingId = this.options.similarityGroupingId;
this.eventsCount = 1;
};
+ //TODO: fix bad indentation of code
jQuery.extend(queueEntry.prototype, {
isIgnoreDupResponses: function() {
@@ -45,6 +48,7 @@
onRequestDelayPassed: function() {
this.readyToSubmit = true;
+ //TODO: should be this.queue.submitFirst
submitFirst();
},
@@ -94,20 +98,26 @@
});
// TODO: add this two variables to richfaces and report bug to jsf about constants
+ //TODO: what's the point in such kind of hash?
var jsfDataTypes = {'event' : 'event'};
var jsfEventNames = {'success' : 'success'};
var log = richfaces.log;
var items = [];
var queueOptions = opts || {};
+ //TODO: that's not last, but first
var last;
+ //TODO: inline this variable
var queueMode = queueOptions.mode;
+ //TODO: inline this variable
var queueRequestDelay = queueOptions.requestDelay;
+ //TODO: instance of this function will be created for each queue
var onError = function (data) {
log.debug("richfaces.queue: ajax submit error");
last = null;
+ //TODO: what if somebody is going to clear queue on error?
submitFirst();
};
@@ -133,10 +143,14 @@
}
if (items[0].readyToSubmit) {
last = items.shift();
+ //TODO: unnecessary check
if (last.readyToSubmit) {
log.debug("richfaces.queue: will submit request NOW");
+ //TODO: events counter should be submitted
//last.query.appendParameter("AJAX:EVENTS_COUNT", last.eventsCount);
var params = richfaces.processRequestParams(last.query, last.options);
+ //TODO: jsf.ajax.request should be used
+ //TODO: copy of event should be created otherwise IE will fail
richfaces.ajax.request(last.query, last.event, params);
if (last.options.queueonsubmit) {
last.options.queueonsubmit.call(last);
@@ -187,7 +201,9 @@
log.debug("Last queue entry is not the last anymore. Stopping requestDelay timer and marking entry as ready for submission")
lastEntry.stopTimer();
+ //TODO: create method resetSimilarityGroupingId()
lastEntry.setSimilarityGroupingId(undefined);
+ //TODO: create method setReadyToSubmit()
lastEntry.readyToSubmit = true;
items.push(entry);
@@ -202,6 +218,7 @@
},
+ //TODO: remove empty functions
pop: function () {
},
14 years, 5 months
JBoss Rich Faces SVN: r16051 - tags/3.3.3.BETA1/framework/impl/src/main/java/org/richfaces.
by richfaces-svn-commits@lists.jboss.org
Author: konstantin.mishin
Date: 2009-12-03 07:07:35 -0500 (Thu, 03 Dec 2009)
New Revision: 16051
Modified:
tags/3.3.3.BETA1/framework/impl/src/main/java/org/richfaces/VersionBean.java
Log:
change SVN revision and date
Modified: tags/3.3.3.BETA1/framework/impl/src/main/java/org/richfaces/VersionBean.java
===================================================================
--- tags/3.3.3.BETA1/framework/impl/src/main/java/org/richfaces/VersionBean.java 2009-12-03 11:17:33 UTC (rev 16050)
+++ tags/3.3.3.BETA1/framework/impl/src/main/java/org/richfaces/VersionBean.java 2009-12-03 12:07:35 UTC (rev 16051)
@@ -38,7 +38,7 @@
* Revision version, must be auto modified by CVS
*/
- public static final String REVISION = "3.BETA1" ;
+ public static final String REVISION = "3.BETA1";
public static final String SCM_REVISION = " SVN $Revision$ $Date$";//$Revision$ $Date$";
public static final Version _version = new Version();
14 years, 5 months
JBoss Rich Faces SVN: r16050 - root/ui/trunk.
by richfaces-svn-commits@lists.jboss.org
Author: Alex.Kolonitsky
Date: 2009-12-03 06:17:33 -0500 (Thu, 03 Dec 2009)
New Revision: 16050
Modified:
root/ui/trunk/pom.xml
Log:
RFPL-195 Code style policy
Add checkstyle in section build and reporting
Modified: root/ui/trunk/pom.xml
===================================================================
--- root/ui/trunk/pom.xml 2009-12-03 11:16:07 UTC (rev 16049)
+++ root/ui/trunk/pom.xml 2009-12-03 11:17:33 UTC (rev 16050)
@@ -38,9 +38,55 @@
</execution-->
</executions>
</plugin>
- </plugins>
- </build>
+ <plugin>
+ <groupId>org.apache.maven.plugins</groupId>
+ <artifactId>maven-checkstyle-plugin</artifactId>
+ <version>2.3</version>
+
+ <dependencies>
+ <dependency>
+ <groupId>org.richfaces</groupId>
+ <artifactId>checkstyle</artifactId>
+ <version>${project.version}</version>
+ </dependency>
+ </dependencies>
+
+ <executions>
+ <execution>
+ <id>richfaces-checkstyle-report</id>
+ <configuration>
+ <configLocation>exadel-richfaces-checkstyle/exadel+sun-checkstyle.xml</configLocation>
+ <suppressionsLocation>checkstyle-suppressions.xml</suppressionsLocation>
+
+ <failOnViolation>false</failOnViolation>
+ </configuration>
+
+ <phase>process-sources</phase>
+ <goals>
+ <goal>check</goal>
+ </goals>
+ </execution>
+ </executions>
+ </plugin>
+ </plugins>
+ </build>
+
+ <reporting>
+ <plugins>
+ <plugin>
+ <groupId>org.apache.maven.plugins</groupId>
+ <artifactId>maven-checkstyle-plugin</artifactId>
+ <version>2.3</version>
+
+ <configuration>
+ <configLocation>exadel-richfaces-checkstyle/exadel+sun-checkstyle.xml</configLocation>
+ <suppressionsLocation>checkstyle-suppressions.xml</suppressionsLocation>
+ </configuration>
+ </plugin>
+ </plugins>
+ </reporting>
+
<dependencies>
<dependency>
<groupId>junit</groupId>
14 years, 5 months
JBoss Rich Faces SVN: r16049 - root/examples/trunk.
by richfaces-svn-commits@lists.jboss.org
Author: Alex.Kolonitsky
Date: 2009-12-03 06:16:07 -0500 (Thu, 03 Dec 2009)
New Revision: 16049
Modified:
root/examples/trunk/pom.xml
Log:
RFPL-195 Code style policy
Add checkstyle in section build and reporting
Modified: root/examples/trunk/pom.xml
===================================================================
--- root/examples/trunk/pom.xml 2009-12-03 11:14:58 UTC (rev 16048)
+++ root/examples/trunk/pom.xml 2009-12-03 11:16:07 UTC (rev 16049)
@@ -159,9 +159,55 @@
<target>1.5</target>
</configuration>
</plugin>
- </plugins>
- </build>
+ <plugin>
+ <groupId>org.apache.maven.plugins</groupId>
+ <artifactId>maven-checkstyle-plugin</artifactId>
+ <version>2.3</version>
+
+ <dependencies>
+ <dependency>
+ <groupId>org.richfaces</groupId>
+ <artifactId>checkstyle</artifactId>
+ <version>${project.version}</version>
+ </dependency>
+ </dependencies>
+
+ <executions>
+ <execution>
+ <id>richfaces-checkstyle-report</id>
+ <configuration>
+ <configLocation>exadel-richfaces-checkstyle/exadel+sun-checkstyle.xml</configLocation>
+ <suppressionsLocation>checkstyle-suppressions.xml</suppressionsLocation>
+
+ <failOnViolation>false</failOnViolation>
+ </configuration>
+
+ <phase>process-sources</phase>
+ <goals>
+ <goal>check</goal>
+ </goals>
+ </execution>
+ </executions>
+ </plugin>
+ </plugins>
+ </build>
+
+ <reporting>
+ <plugins>
+ <plugin>
+ <groupId>org.apache.maven.plugins</groupId>
+ <artifactId>maven-checkstyle-plugin</artifactId>
+ <version>2.3</version>
+
+ <configuration>
+ <configLocation>exadel-richfaces-checkstyle/exadel+sun-checkstyle.xml</configLocation>
+ <suppressionsLocation>checkstyle-suppressions.xml</suppressionsLocation>
+ </configuration>
+ </plugin>
+ </plugins>
+ </reporting>
+
<properties>
<jetty.port>8080</jetty.port>
</properties>
14 years, 5 months
JBoss Rich Faces SVN: r16048 - root/framework/trunk.
by richfaces-svn-commits@lists.jboss.org
Author: Alex.Kolonitsky
Date: 2009-12-03 06:14:58 -0500 (Thu, 03 Dec 2009)
New Revision: 16048
Modified:
root/framework/trunk/pom.xml
Log:
RFPL-195 Code style policy
Add checkstyle in section build and reporting
Modified: root/framework/trunk/pom.xml
===================================================================
--- root/framework/trunk/pom.xml 2009-12-03 11:10:13 UTC (rev 16047)
+++ root/framework/trunk/pom.xml 2009-12-03 11:14:58 UTC (rev 16048)
@@ -1,130 +1,181 @@
<?xml version="1.0" encoding="UTF-8"?>
<project xmlns="http://maven.apache.org/POM/4.0.0" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
- xsi:schemaLocation="http://maven.apache.org/POM/4.0.0
+ xsi:schemaLocation="http://maven.apache.org/POM/4.0.0
http://maven.apache.org/xsd/maven-4.0.0.xsd">
- <parent>
- <groupId>org.richfaces</groupId>
- <artifactId>framework-version-matrix</artifactId>
- <version>4.0.0-SNAPSHOT</version>
- <relativePath>version-matrix/pom.xml</relativePath>
- </parent>
+ <parent>
+ <groupId>org.richfaces</groupId>
+ <artifactId>framework-version-matrix</artifactId>
+ <version>4.0.0-SNAPSHOT</version>
+ <relativePath>version-matrix/pom.xml</relativePath>
+ </parent>
- <modelVersion>4.0.0</modelVersion>
- <groupId>org.richfaces</groupId>
- <artifactId>framework</artifactId>
- <name>JSF ajax framework</name>
- <packaging>pom</packaging>
+ <modelVersion>4.0.0</modelVersion>
+ <groupId>org.richfaces</groupId>
+ <artifactId>framework</artifactId>
+ <packaging>pom</packaging>
- <dependencyManagement>
- <dependencies>
- <dependency>
- <groupId>org.richfaces.framework</groupId>
- <artifactId>richfaces-api</artifactId>
- <version>${project.version}</version>
- </dependency>
- <dependency>
- <groupId>org.richfaces.framework</groupId>
- <artifactId>richfaces-impl</artifactId>
- <version>${project.version}</version>
- </dependency>
- <dependency>
- <groupId>org.jboss.test-jsf</groupId>
- <artifactId>htmlunit-client</artifactId>
- <version>1.0.0-SNAPSHOT</version>
- </dependency>
- <dependency>
- <groupId>org.jboss.test-jsf</groupId>
- <artifactId>jsf-mock</artifactId>
- <version>1.0.0-SNAPSHOT</version>
- </dependency>
- </dependencies>
- </dependencyManagement>
+ <name>JSF ajax framework</name>
- <dependencies>
- <dependency>
- <groupId>junit</groupId>
- <artifactId>junit</artifactId>
- <scope>test</scope>
- </dependency>
- <dependency>
- <groupId>javax.servlet</groupId>
- <artifactId>servlet-api</artifactId>
- <scope>provided</scope>
- </dependency>
- <dependency>
- <groupId>javax.servlet.jsp</groupId>
- <artifactId>jsp-api</artifactId>
- <scope>provided</scope>
- </dependency>
- <dependency>
- <groupId>javax.el</groupId>
- <artifactId>el-api</artifactId>
- <scope>provided</scope>
- </dependency>
- <dependency>
- <groupId>jstl</groupId>
- <artifactId>jstl</artifactId>
- <scope>provided</scope>
- </dependency>
- <dependency>
- <groupId>com.sun.faces</groupId>
- <artifactId>jsf-api</artifactId>
- <scope>provided</scope>
- </dependency>
- <dependency>
- <groupId>com.sun.faces</groupId>
- <artifactId>jsf-impl</artifactId>
- <scope>test</scope>
- </dependency>
- </dependencies>
+ <modules>
+ <module>version-matrix</module>
+ <module>api</module>
+ <module>impl</module>
+ <module>test-base</module>
+ </modules>
- <modules>
- <module>version-matrix</module>
- <module>api</module>
- <module>impl</module>
- <module>test-base</module>
- </modules>
+ <dependencyManagement>
+ <dependencies>
+ <dependency>
+ <groupId>org.richfaces.framework</groupId>
+ <artifactId>richfaces-api</artifactId>
+ <version>${project.version}</version>
+ </dependency>
+ <dependency>
+ <groupId>org.richfaces.framework</groupId>
+ <artifactId>richfaces-impl</artifactId>
+ <version>${project.version}</version>
+ </dependency>
+ <dependency>
+ <groupId>org.jboss.test-jsf</groupId>
+ <artifactId>htmlunit-client</artifactId>
+ <version>1.0.0-SNAPSHOT</version>
+ </dependency>
+ <dependency>
+ <groupId>org.jboss.test-jsf</groupId>
+ <artifactId>jsf-mock</artifactId>
+ <version>1.0.0-SNAPSHOT</version>
+ </dependency>
+ </dependencies>
+ </dependencyManagement>
- <profiles>
- <profile>
- <id>clover</id>
- <build>
- <plugins>
- <plugin>
- <groupId>com.atlassian.maven.plugins</groupId>
- <artifactId>maven-clover2-plugin</artifactId>
- <configuration>
- <licenseLocation>
- ${clover.license.path}
- </licenseLocation>
- <jdk>1.5</jdk>
- <generatePdf>false</generatePdf>
- <generateXml>true</generateXml>
- <generateHtml>true</generateHtml>
- </configuration>
- <executions>
- <execution>
- <id>instrument</id>
- <phase>verify</phase>
- <goals>
- <goal>instrument</goal>
- <goal>check</goal>
- <goal>clover</goal>
- </goals>
- </execution>
- </executions>
- </plugin>
- </plugins>
- </build>
- </profile>
- <profile>
- <id>hudson</id>
- <properties>
- <clover.license.path>/home/hudson/config_repository/resources/richfaces/richfaces-clover-license.txt</clover.license.path>
- </properties>
- </profile>
- </profiles>
-
+ <dependencies>
+ <dependency>
+ <groupId>junit</groupId>
+ <artifactId>junit</artifactId>
+ <scope>test</scope>
+ </dependency>
+ <dependency>
+ <groupId>javax.servlet</groupId>
+ <artifactId>servlet-api</artifactId>
+ <scope>provided</scope>
+ </dependency>
+ <dependency>
+ <groupId>javax.servlet.jsp</groupId>
+ <artifactId>jsp-api</artifactId>
+ <scope>provided</scope>
+ </dependency>
+ <dependency>
+ <groupId>javax.el</groupId>
+ <artifactId>el-api</artifactId>
+ <scope>provided</scope>
+ </dependency>
+ <dependency>
+ <groupId>jstl</groupId>
+ <artifactId>jstl</artifactId>
+ <scope>provided</scope>
+ </dependency>
+ <dependency>
+ <groupId>com.sun.faces</groupId>
+ <artifactId>jsf-api</artifactId>
+ <scope>provided</scope>
+ </dependency>
+ <dependency>
+ <groupId>com.sun.faces</groupId>
+ <artifactId>jsf-impl</artifactId>
+ <scope>test</scope>
+ </dependency>
+ </dependencies>
+
+ <build>
+ <plugins>
+ <plugin>
+ <groupId>org.apache.maven.plugins</groupId>
+ <artifactId>maven-checkstyle-plugin</artifactId>
+ <version>2.3</version>
+
+ <dependencies>
+ <dependency>
+ <groupId>org.richfaces</groupId>
+ <artifactId>checkstyle</artifactId>
+ <version>${project.version}</version>
+ </dependency>
+ </dependencies>
+
+ <executions>
+ <execution>
+ <id>richfaces-checkstyle-report</id>
+ <configuration>
+ <configLocation>exadel-richfaces-checkstyle/exadel+sun-checkstyle.xml</configLocation>
+ <suppressionsLocation>checkstyle-suppressions.xml</suppressionsLocation>
+
+ <failOnViolation>false</failOnViolation>
+ </configuration>
+
+ <phase>process-sources</phase>
+ <goals>
+ <goal>check</goal>
+ </goals>
+ </execution>
+ </executions>
+ </plugin>
+ </plugins>
+ </build>
+
+ <reporting>
+ <plugins>
+ <plugin>
+ <groupId>org.apache.maven.plugins</groupId>
+ <artifactId>maven-checkstyle-plugin</artifactId>
+ <version>2.3</version>
+
+ <configuration>
+ <configLocation>exadel-richfaces-checkstyle/exadel+sun-checkstyle.xml</configLocation>
+ <suppressionsLocation>checkstyle-suppressions.xml</suppressionsLocation>
+ </configuration>
+ </plugin>
+ </plugins>
+ </reporting>
+
+ <profiles>
+ <profile>
+ <id>clover</id>
+ <build>
+ <plugins>
+ <plugin>
+ <groupId>com.atlassian.maven.plugins</groupId>
+ <artifactId>maven-clover2-plugin</artifactId>
+ <configuration>
+ <licenseLocation>
+ ${clover.license.path}
+ </licenseLocation>
+ <jdk>1.5</jdk>
+ <generatePdf>false</generatePdf>
+ <generateXml>true</generateXml>
+ <generateHtml>true</generateHtml>
+ </configuration>
+ <executions>
+ <execution>
+ <id>instrument</id>
+ <phase>verify</phase>
+ <goals>
+ <goal>instrument</goal>
+ <goal>check</goal>
+ <goal>clover</goal>
+ </goals>
+ </execution>
+ </executions>
+ </plugin>
+ </plugins>
+ </build>
+ </profile>
+ <profile>
+ <id>hudson</id>
+ <properties>
+ <clover.license.path>/home/hudson/config_repository/resources/richfaces/richfaces-clover-license.txt
+ </clover.license.path>
+ </properties>
+ </profile>
+ </profiles>
</project>
\ No newline at end of file
14 years, 5 months
JBoss Rich Faces SVN: r16047 - root/cdk/trunk.
by richfaces-svn-commits@lists.jboss.org
Author: Alex.Kolonitsky
Date: 2009-12-03 06:10:13 -0500 (Thu, 03 Dec 2009)
New Revision: 16047
Modified:
root/cdk/trunk/pom.xml
Log:
RFPL-195 Code style policy
Add checkstyle in section build and reporting
Modified: root/cdk/trunk/pom.xml
===================================================================
--- root/cdk/trunk/pom.xml 2009-12-03 10:56:44 UTC (rev 16046)
+++ root/cdk/trunk/pom.xml 2009-12-03 11:10:13 UTC (rev 16047)
@@ -1,114 +1,163 @@
<?xml version="1.0" encoding="UTF-8"?>
<project xmlns="http://maven.apache.org/POM/4.0.0" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
- xsi:schemaLocation="http://maven.apache.org/POM/4.0.0
+ xsi:schemaLocation="http://maven.apache.org/POM/4.0.0
http://maven.apache.org/xsd/maven-4.0.0.xsd">
- <modelVersion>4.0.0</modelVersion>
- <groupId>org.richfaces</groupId>
- <artifactId>cdk</artifactId>
- <version>4.0.0-SNAPSHOT</version>
- <packaging>pom</packaging>
- <name>JSF components development kit</name>
+ <modelVersion>4.0.0</modelVersion>
- <distributionManagement>
- <downloadUrl>
- http://labs.jboss.com/portal/jbossrichfaces/downloads
- </downloadUrl>
- <repository>
- <id>repository.jboss.org</id>
- <uniqueVersion>false</uniqueVersion>
- <url>${releaseRepository}</url>
- </repository>
- <snapshotRepository>
- <id>snapshots.jboss.org</id>
- <uniqueVersion>true</uniqueVersion>
- <url>${snapshotRepository}</url>
- </snapshotRepository>
- <!--site>
- <url>file:target/site2</url>
- </site-->
- </distributionManagement>
- <repositories>
- <repository>
- <releases />
- <snapshots>
- <enabled>true</enabled>
- </snapshots>
- <id>maven-repository2.dev.java.net</id>
- <name>Java.net Repository for Maven 2</name>
- <url>http://download.java.net/maven/2</url>
- </repository>
-
- <repository>
- <id>repository.jboss.org</id>
- <releases>
- <enabled>true</enabled>
- </releases>
- <snapshots>
- <enabled>false</enabled>
- </snapshots>
- <url>http://repository.jboss.org/maven2</url>
- </repository>
- <repository>
- <id>snapshots.jboss.org</id>
- <releases>
- <enabled>false</enabled>
- </releases>
- <snapshots>
- <enabled>true</enabled>
- <updatePolicy>never</updatePolicy>
- </snapshots>
- <url>http://snapshots.jboss.org/maven2</url>
- </repository>
- </repositories>
- <pluginRepositories>
- <pluginRepository>
- <id>repository.jboss.org</id>
- <releases>
- <enabled>true</enabled>
- </releases>
- <snapshots>
- <enabled>false</enabled>
- </snapshots>
- <url>http://repository.jboss.org/maven2</url>
- </pluginRepository>
- <pluginRepository>
- <id>snapshots.jboss.org</id>
- <releases>
- <enabled>false</enabled>
- </releases>
- <snapshots>
- <enabled>true</enabled>
- <updatePolicy>never</updatePolicy>
- </snapshots>
- <url>http://snapshots.jboss.org/maven2</url>
- </pluginRepository>
- </pluginRepositories>
-
- <modules>
- <module>plugins</module>
- <module>archetypes</module>
- </modules>
- <build>
- <plugins>
- <plugin>
- <groupId>org.apache.maven.plugins</groupId>
- <artifactId>maven-dependency-plugin</artifactId>
- <version>2.1</version>
- </plugin>
- <plugin>
- <groupId>org.codehaus.mojo</groupId>
- <artifactId>xml-maven-plugin</artifactId>
- <version>1.0-beta-2</version>
- </plugin>
- <plugin>
- <groupId>org.apache.maven.plugins</groupId>
- <artifactId>maven-archetype-plugin</artifactId>
- <version>2.0-alpha-4</version>
- <extensions>true</extensions>
- </plugin>
- </plugins>
- </build>
+ <groupId>org.richfaces</groupId>
+ <artifactId>cdk</artifactId>
+ <version>4.0.0-SNAPSHOT</version>
+ <packaging>pom</packaging>
+ <name>JSF components development kit</name>
+ <modules>
+ <module>plugins</module>
+ <module>archetypes</module>
+ </modules>
+
+ <distributionManagement>
+ <downloadUrl>
+ http://labs.jboss.com/portal/jbossrichfaces/downloads
+ </downloadUrl>
+ <repository>
+ <id>repository.jboss.org</id>
+ <uniqueVersion>false</uniqueVersion>
+ <url>${releaseRepository}</url>
+ </repository>
+ <snapshotRepository>
+ <id>snapshots.jboss.org</id>
+ <uniqueVersion>true</uniqueVersion>
+ <url>${snapshotRepository}</url>
+ </snapshotRepository>
+ <!--site>
+ <url>file:target/site2</url>
+ </site-->
+ </distributionManagement>
+
+ <repositories>
+ <repository>
+ <releases/>
+ <snapshots>
+ <enabled>true</enabled>
+ </snapshots>
+ <id>maven-repository2.dev.java.net</id>
+ <name>Java.net Repository for Maven 2</name>
+ <url>http://download.java.net/maven/2</url>
+ </repository>
+
+ <repository>
+ <id>repository.jboss.org</id>
+ <releases>
+ <enabled>true</enabled>
+ </releases>
+ <snapshots>
+ <enabled>false</enabled>
+ </snapshots>
+ <url>http://repository.jboss.org/maven2</url>
+ </repository>
+ <repository>
+ <id>snapshots.jboss.org</id>
+ <releases>
+ <enabled>false</enabled>
+ </releases>
+ <snapshots>
+ <enabled>true</enabled>
+ <updatePolicy>never</updatePolicy>
+ </snapshots>
+ <url>http://snapshots.jboss.org/maven2</url>
+ </repository>
+ </repositories>
+
+ <pluginRepositories>
+ <pluginRepository>
+ <id>repository.jboss.org</id>
+ <releases>
+ <enabled>true</enabled>
+ </releases>
+ <snapshots>
+ <enabled>false</enabled>
+ </snapshots>
+ <url>http://repository.jboss.org/maven2</url>
+ </pluginRepository>
+ <pluginRepository>
+ <id>snapshots.jboss.org</id>
+ <releases>
+ <enabled>false</enabled>
+ </releases>
+ <snapshots>
+ <enabled>true</enabled>
+ <updatePolicy>never</updatePolicy>
+ </snapshots>
+ <url>http://snapshots.jboss.org/maven2</url>
+ </pluginRepository>
+ </pluginRepositories>
+
+ <build>
+ <plugins>
+ <plugin>
+ <groupId>org.apache.maven.plugins</groupId>
+ <artifactId>maven-dependency-plugin</artifactId>
+ <version>2.1</version>
+ </plugin>
+ <plugin>
+ <groupId>org.codehaus.mojo</groupId>
+ <artifactId>xml-maven-plugin</artifactId>
+ <version>1.0-beta-2</version>
+ </plugin>
+ <plugin>
+ <groupId>org.apache.maven.plugins</groupId>
+ <artifactId>maven-archetype-plugin</artifactId>
+ <version>2.0-alpha-4</version>
+ <extensions>true</extensions>
+ </plugin>
+
+ <plugin>
+ <groupId>org.apache.maven.plugins</groupId>
+ <artifactId>maven-checkstyle-plugin</artifactId>
+ <version>2.3</version>
+
+ <dependencies>
+ <dependency>
+ <groupId>org.richfaces</groupId>
+ <artifactId>checkstyle</artifactId>
+ <version>${project.version}</version>
+ </dependency>
+ </dependencies>
+
+ <executions>
+ <execution>
+ <id>richfaces-checkstyle-report</id>
+ <configuration>
+ <configLocation>exadel-richfaces-checkstyle/exadel+sun-checkstyle.xml</configLocation>
+ <suppressionsLocation>checkstyle-suppressions.xml</suppressionsLocation>
+
+ <failOnViolation>false</failOnViolation>
+ </configuration>
+
+ <phase>process-sources</phase>
+ <goals>
+ <goal>check</goal>
+ </goals>
+ </execution>
+ </executions>
+ </plugin>
+ </plugins>
+ </build>
+
+ <reporting>
+ <plugins>
+ <plugin>
+ <groupId>org.apache.maven.plugins</groupId>
+ <artifactId>maven-checkstyle-plugin</artifactId>
+ <version>2.3</version>
+
+ <configuration>
+ <configLocation>exadel-richfaces-checkstyle/exadel+sun-checkstyle.xml</configLocation>
+ <suppressionsLocation>checkstyle-suppressions.xml</suppressionsLocation>
+ </configuration>
+ </plugin>
+ </plugins>
+ </reporting>
</project>
\ No newline at end of file
14 years, 5 months