Author: nbelaevski
Date: 2009-03-27 12:44:20 -0400 (Fri, 27 Mar 2009)
New Revision: 13269
Modified:
trunk/test-applications/realworld2/web/src/main/java/org/richfaces/realworld/manager/ShelfManager.java
trunk/test-applications/realworld2/web/src/main/java/org/richfaces/realworld/manager/SlideshowManager.java
trunk/test-applications/realworld2/web/src/main/java/org/richfaces/realworld/manager/TreeManager.java
Log:
Code review results committed
Modified:
trunk/test-applications/realworld2/web/src/main/java/org/richfaces/realworld/manager/ShelfManager.java
===================================================================
---
trunk/test-applications/realworld2/web/src/main/java/org/richfaces/realworld/manager/ShelfManager.java 2009-03-27
15:56:31 UTC (rev 13268)
+++
trunk/test-applications/realworld2/web/src/main/java/org/richfaces/realworld/manager/ShelfManager.java 2009-03-27
16:44:20 UTC (rev 13269)
@@ -62,6 +62,7 @@
@In
User user;
+ //TODO nick - rename to createShelf
public void initEdit() {
Shelf shelf = new Shelf();
Contexts.getConversationContext().set("shelf", shelf);
Modified:
trunk/test-applications/realworld2/web/src/main/java/org/richfaces/realworld/manager/SlideshowManager.java
===================================================================
---
trunk/test-applications/realworld2/web/src/main/java/org/richfaces/realworld/manager/SlideshowManager.java 2009-03-27
15:56:31 UTC (rev 13268)
+++
trunk/test-applications/realworld2/web/src/main/java/org/richfaces/realworld/manager/SlideshowManager.java 2009-03-27
16:44:20 UTC (rev 13269)
@@ -101,6 +101,7 @@
if(slideshowIndex == images.size() - 1){
slideshowIndex = -1;
}
+ //TODO nick - this will start slideshow from the 2nd image (slideshowIndex == 1)
slideshowIndex++;
selectedImage = images.get(slideshowIndex);
}
Modified:
trunk/test-applications/realworld2/web/src/main/java/org/richfaces/realworld/manager/TreeManager.java
===================================================================
---
trunk/test-applications/realworld2/web/src/main/java/org/richfaces/realworld/manager/TreeManager.java 2009-03-27
15:56:31 UTC (rev 13268)
+++
trunk/test-applications/realworld2/web/src/main/java/org/richfaces/realworld/manager/TreeManager.java 2009-03-27
16:44:20 UTC (rev 13269)
@@ -24,6 +24,7 @@
@SuppressWarnings("unchecked")
public Boolean adviseNodeSelected(UITree tree) {
Object currentNode = tree.getRowData();
+ //TODO nick - cast not neccessary: if currentNode.equals(model.getSelectedAlbum() ||
...)
if (currentNode instanceof Album) {
boolean selected = currentNode == model.getSelectedAlbum();
return selected;
Show replies by date