9:44 a.m.
I'm having trouble figuring out syntax for my rules - could someone please
steer me in the right direction - it's been a frustrating few days and no
luck. I need to check existence of various attributes from the
SHIPMENT_MOVE fact against a list of values (same list) I fetch from the
DB...
Get $valuesList from a DAO - then...
If SHIPMENT_MOVE.customer_code = "abc" and SHIPMENT_MOVE.reference_code
exists in $valuesList
OR
SHIPMENT_MOVE.customer_code = "abc" and SHIPMENT_MOVE.shipping_code exists
in $valuesList
OR
SHIPMENT_MOVE.customer_code = "abc" and SHIPMENT_MOVE.partner_code exists in
$valuesList
I have the following rule working fine:
$shipment SHIPMENT_MOVE(customer_code = "abc")
LookupTableResult ( resultValue == 1 ) from lookupDAO.getLookup(...)
But I'm having real problems with writing a rule like this:
when
SHIPMENT_MOVE(customer_code == "abc", $list contains ship_code) OR
SHIPMENT_MOVE(customer_code == "abc", $list contains deliver_code) OR
SHIPMENT_MOVE(customer_code == "abc", $list contains port_code)
Your guidance will be appreciated -
Thanks,
James
P.S.
I'm using Drools 3.1.0M1
--
View this message in context:
http://www.nabble.com/Struggling-with-Rule-syntax---please-help...-tf3408...
Sent from the drools - user mailing list archive at Nabble.com.
12:14 p.m.
James,
What are the "elements" in your list? Strings?
There are a few ways of doing it. Basically they differ on what are
the elements of your list, how many you expect to find in each list,
etc. The simplest way:
when
$code : String() from lookupDAO.getLookup(...)
( SHIPMENT_MOVE(customer_code == "abc", ship_code == $code ) OR
SHIPMENT_MOVE(customer_code == "abc", deliver_code == $code ) OR
SHIPMENT_MOVE(customer_code == "abc", port_code == $code )
)
then
// consequence
end
Remember that if your list contains codes that match more than one
condition above, your consequence will fire multiple times.
If you want it to fire only once, you can use a predicate:
when
$code : String() from lookupDAO.getLookup(...)
SHIPMENT_MOVE(customer_code == "abc", $sc : ship_code,
$dc : deliver_code, $pc : port_code,
( $code.equals($sc) ||
$code.equals($dc) || $code.equals($pc) ) )
)
then
// consequence
end
If you expect your list to have a lot of objects, or if you expect to
use the same list in more than one rule, you can improve performance by
doing a rule to retrieve and assert the list of codes, based on whatever
criteria you need (customer code for instance in the bellow example):
rule "retrieving the list"
when
Customer( $custCode : customer_code )
then
List codes = lookupDAO.getLookup( $custCode );
assert( codes );
end
rule "doing something"
when
Customer( $custCode : customer_code )
$list : List()
SHIPMENT_MOVE(customer_code == $custCode, $sc : ship_code,
$dc : deliver_code, $pc : port_code,
( $list.containts($sc) ||
$list.containts($dc) || $list.containts($pc) ) )
then
// do something
end
If your DAO returns a specific class, like the one mentioned in one
of your examples bellow (LookupTableResults) and it is not a collections
implementation, you can even do things like:
when
SHIPMENT_MOVE(customer_code == "abc", $sc : ship_code,
$dc : deliver_code, $pc : port_code )
LookupTableResult( elements contains $sc | contains $dc | contains
$pc ) from lookupDAO.getLookup(...)
)
then
// consequence
end
So, I don't have your code to run, but there are many ways of
doing... test and try to find which one best suites you.
Hope it helps.
Edson
jdepaul wrote:
I'm having trouble figuring out syntax for my rules - could
someone please
steer me in the right direction - it's been a frustrating few days and no
luck. I need to check existence of various attributes from the
SHIPMENT_MOVE fact against a list of values (same list) I fetch from the
DB...
Get $valuesList from a DAO - then...
If SHIPMENT_MOVE.customer_code = "abc" and SHIPMENT_MOVE.reference_code
exists in $valuesList
OR
SHIPMENT_MOVE.customer_code = "abc" and SHIPMENT_MOVE.shipping_code exists
in $valuesList
OR
SHIPMENT_MOVE.customer_code = "abc" and SHIPMENT_MOVE.partner_code exists in
$valuesList
I have the following rule working fine:
$shipment SHIPMENT_MOVE(customer_code = "abc")
LookupTableResult ( resultValue == 1 ) from lookupDAO.getLookup(...)
But I'm having real problems with writing a rule like this:
when
SHIPMENT_MOVE(customer_code == "abc", $list contains ship_code) OR
SHIPMENT_MOVE(customer_code == "abc", $list contains deliver_code) OR
SHIPMENT_MOVE(customer_code == "abc", $list contains port_code)
Your guidance will be appreciated -
Thanks,
James
P.S.
I'm using Drools 3.1.0M1
--
Edson Tirelli
Software Engineer - JBoss Rules Core Developer
Office: +55 11 3124-6000
Mobile: +55 11 9218-4151
JBoss, a division of Red Hat @ www.jboss.com
3:06 p.m.
Thank you for an exhaustive reply Edson - this helps a lot. A couple of
things to clarify and then some follow-up questions for you:
My DAO takes a String name of the lookup table as input and returns a List
of String values for that lookup table name. Three will be a fairly good
number of common lookup tables: around 650 in all, each table will have a
collection of String values tied to it. Some tables will have as much as
33,000 String values (only one of them has that many, the rest have 5,10, 20
values at the most). All these lookup tables will be used in many rules.
Some rules will reference the Lookup tables, some may not.
From your description, looks like I should pursue Approach #2 as my
best
bet: I plan on having a rule to retrieve the codes. Looking at the example
you listed (see below) I understand MOST of it: first rule is to retrieve
the codes and to assert them in working memory:
> List codes = lookupDAO.getLookup( $custCode ); <-- OK
> assert( codes ); <-- OK
I do not understand the line in the next rule below that reads:
> $list : List() <-- does this somehow refer to
"codes" List above?
How does this variable $list get assigned to the List of codes asserted in
the rule above - am I missing something in the syntax? What would be the
syntax to assert more than one List object (List codes, List from_ports,
List to_ports) into the Working Memory?
The syntax below that reads: >> ( $list.containts($sc) ||
$list.containts($dc) || $list.containts($pc) << - that helps me a lot - I
just need to know how to define different $lists and assign them to
different set of codes ($codes_list, $fromPorts_list, $toPorts_list, etc)
and I'll be on my way.
Thanks,
James
Edson Tirelli-3 wrote:
... What are the "elements" in your list? Strings?
#2 ... If you expect your list to have a lot of objects, or if you expect
to
use the same list in more than one rule, you can improve performance by
doing a rule to retrieve and assert the list of codes, based on whatever
criteria you need (customer code for instance in the bellow example):
rule "retrieving the list"
when
Customer( $custCode : customer_code )
then
List codes = lookupDAO.getLookup( $custCode ); <-- OK
assert( codes ); <-- OK
end
rule "doing something"
when
Customer( $custCode : customer_code ) <--ok
$list : List() <-- Don't understand... How is the $list variable
here linked back to the "List codes" in the rule above?
SHIPMENT_MOVE(customer_code == $custCode, $sc : ship_code,
$dc : deliver_code, $pc : port_code,
( $list.containts($sc) ||
$list.containts($dc) || $list.containts($pc) ) )
then
// do something
end
--
View this message in context:
http://www.nabble.com/Struggling-with-Rule-syntax---please-help...-tf3408...
Sent from the drools - user mailing list archive at Nabble.com.
8:04 a.m.
Please help with 'contains' keyword syntax. I have the following code in
place - I'm wondering why this rule does NOT parse properly?!
I assert GATE_IN object - that's my primary fact. I also assert a
supporting fact called a LookupTableDOM into working memory, which contains
String name and ArrayList values. I want my rule to fire when
CUSTOMER_REFERENCE_NUMBER == "HX" and GATE_IN.SH_CODE exists in the List of
values from LookupTableDOM - what am I doing wrong here:
// This does NOT work
1 rule "This rule does NOT work"
2 when
3
4 // values variable is an ArrayList containing String elements...
5 LookupTableDOM( $name : name == "MILT.CUSTO", $MiltVals : values );
6
7 $gateIN : GATE_IN( CUSTOMER_REFERENCE_NUMBER == "HX",
8 $sh_code : SH_CODE,
9 $MiltVals contains $sh_code ) <-- what's wrong with
this line???
10 //$MiltVals.contains($sh_code) ) <-- this did
not work either...
11 then
12 // do something...
13end
This code was built based on the example you offered below - I just can't
make the syntax work. Please help.
James
Edson Tirelli-3 wrote:
rule "retrieving the list"
when
Customer( $custCode : customer_code )
then
List codes = lookupDAO.getLookup( $custCode );
assert( codes );
end
rule "doing something"
when
Customer( $custCode : customer_code )
$list : List()
SHIPMENT_MOVE(customer_code == $custCode, $sc : ship_code,
$dc : deliver_code, $pc : port_code,
( $list.containts($sc) ||
$list.containts($dc) || $list.containts($pc) ) )
then
// do something
end
If your DAO returns a specific class, like the one mentioned in one
of your examples bellow (LookupTableResults) and it is not a collections
implementation, you can even do things like:
when
SHIPMENT_MOVE(customer_code == "abc", $sc : ship_code,
$dc : deliver_code, $pc : port_code
)
LookupTableResult( elements contains $sc | contains $dc | contains
$pc ) from lookupDAO.getLookup(...)
)
then
// consequence
end
--
View this message in context:
http://www.nabble.com/Struggling-with-Rule-syntax---please-help...-tf3408...
Sent from the drools - user mailing list archive at Nabble.com.
9:36 a.m.
Hi James,
You can't use a bound object as the list against which "contains"
operates.
Something like this should work, where getLookupValues() returns an
ArrayList by calling LookupTableDOM with name="MILT.CUSTO".
rule "This rule does NOT work"
when
$gateIN : GATE_IN( CUSTOMER_REFERENCE_NUMBER == "HX", $sh_code :
SH_CODE, lookupValues contains $sh_code )
then
// do something...
End
With kind regards,
Mike
-----Original Message-----
From: rules-users-bounces(a)lists.jboss.org
[mailto:rules-users-bounces@lists.jboss.org] On Behalf Of jdepaul
Sent: 22 March 2007 13:04
To: rules-users(a)lists.jboss.org
Subject: Re: [rules-users] Struggling with Rule syntax - please help...
Please help with 'contains' keyword syntax. I have the following code
in
place - I'm wondering why this rule does NOT parse properly?!
I assert GATE_IN object - that's my primary fact. I also assert a
supporting fact called a LookupTableDOM into working memory, which
contains
String name and ArrayList values. I want my rule to fire when
CUSTOMER_REFERENCE_NUMBER == "HX" and GATE_IN.SH_CODE exists in the List
of
values from LookupTableDOM - what am I doing wrong here:
// This does NOT work
1 rule "This rule does NOT work"
2 when
3
4 // values variable is an ArrayList containing String
elements...
5 LookupTableDOM( $name : name == "MILT.CUSTO", $MiltVals :
values );
6
7 $gateIN : GATE_IN( CUSTOMER_REFERENCE_NUMBER == "HX",
8 $sh_code : SH_CODE,
9 $MiltVals contains $sh_code ) <--
what's wrong with
this line???
10 //$MiltVals.contains($sh_code) ) <--
this did
not work either...
11 then
12 // do something...
13end
This code was built based on the example you offered below - I just
can't
make the syntax work. Please help.
James
Edson Tirelli-3 wrote:
rule "retrieving the list"
when
Customer( $custCode : customer_code )
then
List codes = lookupDAO.getLookup( $custCode );
assert( codes );
end
rule "doing something"
when
Customer( $custCode : customer_code )
$list : List()
SHIPMENT_MOVE(customer_code == $custCode, $sc : ship_code,
$dc : deliver_code, $pc :
port_code,
( $list.containts($sc) ||
$list.containts($dc) || $list.containts($pc) ) )
then
// do something
end
If your DAO returns a specific class, like the one mentioned in one
of your examples bellow (LookupTableResults) and it is not a
collections
implementation, you can even do things like:
when
SHIPMENT_MOVE(customer_code == "abc", $sc : ship_code,
$dc : deliver_code, $pc :
port_code
)
LookupTableResult( elements contains $sc | contains $dc | contains
$pc ) from lookupDAO.getLookup(...)
)
then
// consequence
end
--
View this message in context:
http://www.nabble.com/Struggling-with-Rule-syntax---please-help...-tf340
8727.html#a9611859
Sent from the drools - user mailing list archive at Nabble.com.
_______________________________________________
rules-users mailing list
rules-users(a)lists.jboss.org
https://lists.jboss.org/mailman/listinfo/rules-users
12:03 p.m.
Anstis, Michael (M.) wrote:
You can't use a bound object as the list against which "contains"
operates.
Guys - think this is bad news for me... I need to use 'contains' keyword as
List comparison against several variables from the primary Fact and possibly
against several Lists. Without the ability to bind variable names to
specific ArrayList objects I don't know how I can do this type of comparison
in my rules - I hope there is a work-around to my problem, otherwise this
may be a deal killer for my project...
What I dont understand is that Edson's example seemed to get me so close -
he gave this example some time in the past, which seems to illustrate that
variable binding to List object is possible. How is his example different
from what I'm trying to do in my code?
Again, this is what I need:
Several Lookup list objects each with many String elements asserted into
memory. One main Fact (GATEIN) asserted into memory as well, the GATEIN
fact has CustNumber, shipper_code, forwarder_code, cosignee_code, etc).
Rule needs to check for existence of one of these codes in ONE or MORE
lookup lists. Something like this:
if (CustomerNumber = "293" and (ShippersList contains shipper_code or
ShipperList contains forwarder_code, or ShipperList contains cosignee_code)
).
Is this possible given the syntax constraints? BTW, I'm using 3.1.0M1
James
Edson's prvious example:
------------------------------------------------
rule "retrieving the list"
when
Customer( $custCode : customer_code )
then
List codes = lookupDAO.getLookup( $custCode );
assert( codes );
end
rule "doing something"
when
Customer( $custCode : customer_code )
$list : List()
SHIPMENT_MOVE(customer_code == $custCode, $sc : ship_code,
$dc : deliver_code, $pc :
port_code,
( $list.containts($sc) ||
$list.containts($dc) || $list.containts($pc) ) )
then
// do something
end
------------------------------------------------
--
View this message in context:
http://www.nabble.com/Struggling-with-Rule-syntax---please-help...-tf3408...
Sent from the drools - user mailing list archive at Nabble.com.
4:31 a.m.
I don't think your project is dead at all; you just need to re-consider
how you might achieve your objective.
Edson's example you refer to used a List.contains() within a "return
value operator" (example 3.13 in the 3.0.5 docs):-
[Edson's example]
rule "retrieving the list"
when
Customer( $custCode : customer_code )
then
List codes = lookupDAO.getLookup( $custCode );
assert( codes );
end
rule "doing something"
when
Customer( $custCode : customer_code )
<-- Bound column
$list : List()
<-- Bound column (to a List() fact which must implement List)
SHIPMENT_MOVE(
customer_code == $custCode,
<-- Field constraint
$sc : ship_code,
<-- Bound column
$dc : deliver_code,
<-- Bound column
$pc : port_code,
<-- Bound column
( $list.containts($sc) || $list.containts($dc) ||
$list.containts($pc) ) <-- Return value operator
)
then
// do something
End
His other option was to use 3.1's "from" statement. This requires a
"LookupTableResult()" object that exposes a "List getElements()"
method
and a "lookupDAO" object (possibly in global scope, but I'm unsure) that
has a "LookupTableResult getLookup(...)" method which returns a
LookupTableResult object containing an elements List containing the
codes you need to validate against.
when
SHIPMENT_MOVE(
customer_code == "abc",
$sc : ship_code,
$dc : deliver_code,
$pc : port_code )
LookupTableResult( elements contains $sc | contains $dc | contains
$pc ) from lookupDAO.getLookup(...)
)
then
// consequence
end
I think both would serve your purpose.
With kind regards,
Mike
-----Original Message-----
From: rules-users-bounces(a)lists.jboss.org
[mailto:rules-users-bounces@lists.jboss.org] On Behalf Of jdepaul
Sent: 22 March 2007 17:04
To: rules-users(a)lists.jboss.org
Subject: [rules-users] RE: Struggling with Rule syntax - please help...
Anstis, Michael (M.) wrote:
You can't use a bound object as the list against which "contains"
operates.
Guys - think this is bad news for me... I need to use 'contains'
keyword as
List comparison against several variables from the primary Fact and
possibly
against several Lists. Without the ability to bind variable names to
specific ArrayList objects I don't know how I can do this type of
comparison
in my rules - I hope there is a work-around to my problem, otherwise
this
may be a deal killer for my project...
What I dont understand is that Edson's example seemed to get me so close
-
he gave this example some time in the past, which seems to illustrate
that
variable binding to List object is possible. How is his example
different
from what I'm trying to do in my code?
Again, this is what I need:
Several Lookup list objects each with many String elements asserted into
memory. One main Fact (GATEIN) asserted into memory as well, the GATEIN
fact has CustNumber, shipper_code, forwarder_code, cosignee_code, etc).
Rule needs to check for existence of one of these codes in ONE or MORE
lookup lists. Something like this:
if (CustomerNumber = "293" and (ShippersList contains shipper_code or
ShipperList contains forwarder_code, or ShipperList contains
cosignee_code)
).
Is this possible given the syntax constraints? BTW, I'm using 3.1.0M1
James
Edson's prvious example:
------------------------------------------------
rule "retrieving the list"
when
Customer( $custCode : customer_code )
then
List codes = lookupDAO.getLookup( $custCode );
assert( codes );
end
rule "doing something"
when
Customer( $custCode : customer_code )
$list : List()
SHIPMENT_MOVE(customer_code == $custCode, $sc : ship_code,
$dc : deliver_code, $pc :
port_code,
( $list.containts($sc) ||
$list.containts($dc) || $list.containts($pc) ) )
then
// do something
end
------------------------------------------------
--
View this message in context:
http://www.nabble.com/Struggling-with-Rule-syntax---please-help...-tf340
8727.html#a9619455
Sent from the drools - user mailing list archive at Nabble.com.
_______________________________________________
rules-users mailing list
rules-users(a)lists.jboss.org
https://lists.jboss.org/mailman/listinfo/rules-users
8:54 a.m.
Good to hear - YES, I want to use Edson's first example where he uses
List.contains() - his example, however, used just ONE list object and I need
to declare and refer to MULTIPLE list objects asserted into working memory.
COuld you show syntax for multiple list object definitions?
THanks in advance,
james
Anstis, Michael (M.) wrote:
Edson's example you refer to used a List.contains() within a "return
value operator" (example 3.13 in the 3.0.5 docs):-
[Edson's example]
rule "retrieving the list"
when
Customer( $custCode : customer_code )
then
List codes = lookupDAO.getLookup( $custCode );
assert( codes );
end
rule "doing something"
when
Customer( $custCode : customer_code )
<-- Bound column
$list : List()
<-- Bound column (to a List() fact which must implement List)
SHIPMENT_MOVE(
customer_code == $custCode,
<-- Field constraint
$sc : ship_code,
<-- Bound column
$dc : deliver_code,
<-- Bound column
$pc : port_code,
<-- Bound column
( $list.containts($sc) || $list.containts($dc) ||
$list.containts($pc) ) <-- Return value operator
)
then
// do something
End
--
View this message in context:
http://www.nabble.com/Struggling-with-Rule-syntax---please-help...-tf3408...
Sent from the drools - user mailing list archive at Nabble.com.
3:59 a.m.
Something like this?
rule "Codes1"
when
then
Codes1List codes1 = lookupDAO.getLookup( CODES_1 ); <--
Codes1List is a subclass of List
assert( codes1 );
end
rule "Codes2"
when
then
Codes2List codes2 = lookupDAO.getLookup( CODES_2 ); <--
Codes2List is a subclass of List
assert( codes2 );
End
rule "Codes3"
when
then
Codes3List codes3 = lookupDAO.getLookup( CODES_3 ); <--
Codes3List is a subclass of List
assert( codes3 );
End
rule "doing something"
when
Customer( $custCode : customer_code )
$codes1 : Codes1List()
$codes2 : Codes2List()
$codes3 : Codes3List()
SHIPMENT_MOVE(
customer_code == $custCode,
$sc : ship_code,
$dc : deliver_code,
$pc : port_code,
( $codes1.containts($sc) || $codes2.containts($dc) ||
$codes3.containts($pc) )
)
then
// do something
End
Otherwise you'll need to explain your model to me and what you're trying
to achieve a little more.
Thanks,
Mike
-----Original Message-----
From: rules-users-bounces(a)lists.jboss.org
[mailto:rules-users-bounces@lists.jboss.org] On Behalf Of jdepaul
Sent: 23 March 2007 13:55
To: rules-users(a)lists.jboss.org
Subject: [rules-users] RE: RE: Struggling with Rule syntax - please
help...
Good to hear - YES, I want to use Edson's first example where he uses
List.contains() - his example, however, used just ONE list object and I
need
to declare and refer to MULTIPLE list objects asserted into working
memory.
COuld you show syntax for multiple list object definitions?
THanks in advance,
james
Anstis, Michael (M.) wrote:
Edson's example you refer to used a List.contains() within a "return
value operator" (example 3.13 in the 3.0.5 docs):-
[Edson's example]
rule "retrieving the list"
when
Customer( $custCode : customer_code )
then
List codes = lookupDAO.getLookup( $custCode );
assert( codes );
end
rule "doing something"
when
Customer( $custCode : customer_code )
<-- Bound column
$list : List()
<-- Bound column (to a List() fact which must implement List)
SHIPMENT_MOVE(
customer_code == $custCode,
<-- Field constraint
$sc : ship_code,
<-- Bound column
$dc : deliver_code,
<-- Bound column
$pc : port_code,
<-- Bound column
( $list.containts($sc) || $list.containts($dc) ||
$list.containts($pc) ) <-- Return value operator
)
then
// do something
End
--
View this message in context:
http://www.nabble.com/Struggling-with-Rule-syntax---please-help...-tf340
8727.html#a9635322
Sent from the drools - user mailing list archive at Nabble.com.
_______________________________________________
rules-users mailing list
rules-users(a)lists.jboss.org
https://lists.jboss.org/mailman/listinfo/rules-users
4:16 p.m.
Perfect! This is exactly what I needed - for me the key was understanding
that CodesList must extend java.util.ArrayList object... it all fell into
place from there... Thanks very much Michael for all your help - here's my
sample rule definition which I've successfully tested in a test harness:
rule "This rule works!"
no-loop
when
$MILT_CUSTNO : LookupListDOM ( name == "MILT_CUSTNO" ) // extends
ArrayList
$MILT_SHPRNO : LookupListDOM ( name == "MILT_SHPRNO" ) // extends
ArrayList
$gateIN : GATE_IN(
CUSTOMER_REFERENCE_NUMBER matches "^HX.*",
ACTIVITY_LOCATION matches "^US.*",
$sh_code : SH_CODE,
$fo_code : FO_CODE,
( ( $MILT_CUSTNO.contains($sh_code) ) || (
$MILT_SHPRNO.contains($fo_code) ) )
)
then
System.out.println("Matched Customer Rule! About to inovke Service...");
//myService.sendNotification($event, Constants.CUSTOMER_MATCH);
end
Thanks again for helping me resolve this important issue.
Regards,
James
Anstis, Michael (M.) wrote:
Something like this?
...
rule "doing something"
when
Customer( $custCode : customer_code )
$codes1 : Codes1List()
$codes2 : Codes2List()
$codes3 : Codes3List()
SHIPMENT_MOVE(
customer_code == $custCode,
$sc : ship_code,
$dc : deliver_code,
$pc : port_code,
( $codes1.containts($sc) || $codes2.containts($dc) ||
$codes3.containts($pc) )
)
then
// do something
End
--
View this message in context:
http://www.nabble.com/Struggling-with-Rule-syntax---please-help...-tf3408...
Sent from the drools - user mailing list archive at Nabble.com.
6453
days inactive
6466
days old
9 comments
3 participants
participants (3)
-
Anstis, Michael (M.) -
Edson Tirelli -
jdepaul