1:16 a.m.
Hello all,
I've been getting more and more into using Drools Expert, but I certainly still have a
lot to learn. I have almost a complete rules file ready to go. But I am having an issue
with the LHS checking that a collection contains a certain object value. The rule
currently looks like this:
rule "Rule Name"
no-loop true
when
property : StatusProperty( name == "propertyName", value ==
"valueA" )
t : TrainingStatus( currentSection == "section_a", properties contains
property )
then
t.setNextSection( "section_b" );
t.setPreviousSection( "section_overview" );
update( t );
end
The TrainingStatus object has the following fields:
public class TrainingStatus implements Serializable {
private String currentSection;
private String nextSection;
private String previousSection;
private Set<StatusProperty> properties = new TreeSet<StatusProperty>();
}
And the StatusProperty object has the following:
public class StatusProperty implements Serializable {
private String name;
private String value;
}
I'm inserting a TrainingStatus object that should match this rule. But the resulting
object does not have the nextSection and previousSection fields set to the values they
should.
Can anyone advise on how to get this rule working as expected?
Thanks for your help!
Mike
8:36 a.m.
The rule looks fine, so the problem is somewhere else:
* Are you properly implementing the equals()/hashcode() methods in the
StatusProperty class? or are you checking for the exact same instance (in
which case the defaul equals()/hashcode() would work)
* are you adding the properties to the TrainingStatus.properties collection
before inserting TrainingStatus into the session? or are you calling
update/modify after inserting it?
Also, not related to the problem at all, but we recommend you to use
modify() instead of update() in your rules consequence:
modify( t ) {
setNextSection( "section_b" ),
setPreviousSection( "section_overview" )
}
[]s
Edson
2010/1/24 Mike Dougherty <mjdougherty(a)gmail.com>
Hello all,
I've been getting more and more into using Drools Expert, but I certainly
still have a lot to learn. I have almost a complete rules file ready to go.
But I am having an issue with the LHS checking that a collection contains a
certain object value. The rule currently looks like this:
rule "Rule Name"
no-loop true
when
property : StatusProperty( name == "propertyName", value ==
"valueA" )
t : TrainingStatus( currentSection == "section_a", properties
contains property )
then
t.setNextSection( "section_b" );
t.setPreviousSection( "section_overview" );
update( t );
end
The TrainingStatus object has the following fields:
public class TrainingStatus implements Serializable {
private String currentSection;
private String nextSection;
private String previousSection;
private Set<StatusProperty> properties = new
TreeSet<StatusProperty>();
}
And the StatusProperty object has the following:
public class StatusProperty implements Serializable {
private String name;
private String value;
}
I'm inserting a TrainingStatus object that should match this rule. But the
resulting object does not have the nextSection and previousSection fields
set to the values they should.
Can anyone advise on how to get this rule working as expected?
Thanks for your help!
Mike
_______________________________________________
rules-users mailing list
rules-users(a)lists.jboss.org
https://lists.jboss.org/mailman/listinfo/rules-users
--
Edson Tirelli
JBoss Drools Core Development
JBoss by Red Hat @ www.jboss.com
11:36 a.m.
Hello Edson,
Thanks for your reply. Yes, I believe I am implementing equals and hashCode property in
the StatusProperty class:
@Override
public boolean equals(Object o) {
if (this == o) return true;
if (o == null || getClass() != o.getClass()) return false;
StatusProperty that = (StatusProperty) o;
if (!name.equals(that.name)) return false;
if (!value.equals(that.value)) return false;
return true;
}
@Override
public int hashCode() {
int result = name.hashCode();
result ^= value.hashCode();
return result;
}
Yes, I am adding to the properties list before inserting the TrainingStatus object into
the session.
Also, I tried changing from update to modify and it broke the rule. I'm using Drool
5.0.1, has that method been deprecated?
Thanks again for your help,
Mike
On Jan 24, 2010, at 6:36 AM, Edson Tirelli wrote:
The rule looks fine, so the problem is somewhere else:
* Are you properly implementing the equals()/hashcode() methods in the StatusProperty
class? or are you checking for the exact same instance (in which case the defaul
equals()/hashcode() would work)
* are you adding the properties to the TrainingStatus.properties collection before
inserting TrainingStatus into the session? or are you calling update/modify after
inserting it?
Also, not related to the problem at all, but we recommend you to use modify() instead
of update() in your rules consequence:
modify( t ) {
setNextSection( "section_b" ),
setPreviousSection( "section_overview" )
}
[]s
Edson
2010/1/24 Mike Dougherty <mjdougherty(a)gmail.com>
Hello all,
I've been getting more and more into using Drools Expert, but I certainly still have
a lot to learn. I have almost a complete rules file ready to go. But I am having an issue
with the LHS checking that a collection contains a certain object value. The rule
currently looks like this:
rule "Rule Name"
no-loop true
when
property : StatusProperty( name == "propertyName", value ==
"valueA" )
t : TrainingStatus( currentSection == "section_a", properties
contains property )
then
t.setNextSection( "section_b" );
t.setPreviousSection( "section_overview" );
update( t );
end
The TrainingStatus object has the following fields:
public class TrainingStatus implements Serializable {
private String currentSection;
private String nextSection;
private String previousSection;
private Set<StatusProperty> properties = new
TreeSet<StatusProperty>();
}
And the StatusProperty object has the following:
public class StatusProperty implements Serializable {
private String name;
private String value;
}
I'm inserting a TrainingStatus object that should match this rule. But the resulting
object does not have the nextSection and previousSection fields set to the values they
should.
Can anyone advise on how to get this rule working as expected?
Thanks for your help!
Mike
_______________________________________________
rules-users mailing list
rules-users(a)lists.jboss.org
https://lists.jboss.org/mailman/listinfo/rules-users
--
Edson Tirelli
JBoss Drools Core Development
JBoss by Red Hat @ www.jboss.com
_______________________________________________
rules-users mailing list
rules-users(a)lists.jboss.org
https://lists.jboss.org/mailman/listinfo/rules-users
11:17 a.m.
On Sun, Jan 24, 2010 at 8:16 AM, Mike Dougherty <mjdougherty(a)gmail.com>wrote:
I'm inserting a TrainingStatus object that should match this rule. But the
resulting object does not have the nextSection and previousSection fields
set to the values they should.
Only because you mention the insertion of the TrainingStatus object but not
the one(s) of (a) StatusProperty object(s): They should be inserted, too!
-W
11:40 a.m.
Hello Wolfgang,
Thank you for the response. However, as I read this documentation this should not be
necessary. Even still, if I try it, it does not seem to help.
Thanks,
Mike
On Jan 24, 2010, at 9:17 AM, Wolfgang Laun wrote:
On Sun, Jan 24, 2010 at 8:16 AM, Mike Dougherty
<mjdougherty(a)gmail.com> wrote:
I'm inserting a TrainingStatus object that should match this rule. But the resulting
object does not have the nextSection and previousSection fields set to the values they
should.
Only because you mention the insertion of the TrainingStatus object but not the one(s) of
(a) StatusProperty object(s): They should be inserted, too!
-W
_______________________________________________
rules-users mailing list
rules-users(a)lists.jboss.org
https://lists.jboss.org/mailman/listinfo/rules-users
12:22 p.m.
Mike,
Wolfgang has it right. When you write:
property : StatusProperty( name == "propertyName", value ==
"valueA" )
You are telling the engine that the StatusProperty is a fact in the
working memory. Reading that, I assumed you were inserting them, because if
they are not facts in the working memory, the rule will obviously never
match.
If you don't want to insert them (although recommended), you need to
rewrite the pattern using "from" to tell the engine where to look for the
properties. Example:
when
t : TrainingStatus( currentSection == "section_a" )
property : StatusProperty( name == "propertyName", value ==
"valueA" ) from t.properties
then
end
[]s
Edson
2010/1/25 Mike Dougherty <mjdougherty(a)gmail.com>
Hello Wolfgang,
Thank you for the response. However, as I read this documentation this
should not be necessary. Even still, if I try it, it does not seem to help.
Thanks,
Mike
On Jan 24, 2010, at 9:17 AM, Wolfgang Laun wrote:
On Sun, Jan 24, 2010 at 8:16 AM, Mike Dougherty <mjdougherty(a)gmail.com>wrote:
>
> I'm inserting a TrainingStatus object that should match this rule. But the
> resulting object does not have the nextSection and previousSection fields
> set to the values they should.
Only because you mention the insertion of the TrainingStatus object but not
the one(s) of (a) StatusProperty object(s): They should be inserted, too!
-W
_______________________________________________
rules-users mailing list
rules-users(a)lists.jboss.org
https://lists.jboss.org/mailman/listinfo/rules-users
_______________________________________________
rules-users mailing list
rules-users(a)lists.jboss.org
https://lists.jboss.org/mailman/listinfo/rules-users
--
Edson Tirelli
JBoss Drools Core Development
JBoss by Red Hat @ www.jboss.com
2:36 p.m.
Hey Edson and Wolfgang,
I went to setup an example app and rules file to send you, and it seemed to work
correctly. So now I have to figure out the difference between the sample code and
application code. Hopefully, I'll be able to find it.
Thanks to both of you for your help.
Mike
On Jan 25, 2010, at 10:22 AM, Edson Tirelli wrote:
Mike,
Wolfgang has it right. When you write:
property : StatusProperty( name == "propertyName", value ==
"valueA" )
You are telling the engine that the StatusProperty is a fact in the working memory.
Reading that, I assumed you were inserting them, because if they are not facts in the
working memory, the rule will obviously never match.
If you don't want to insert them (although recommended), you need to rewrite the
pattern using "from" to tell the engine where to look for the properties.
Example:
when
t : TrainingStatus( currentSection == "section_a" )
property : StatusProperty( name == "propertyName", value ==
"valueA" ) from t.properties
then
end
[]s
Edson
2010/1/25 Mike Dougherty <mjdougherty(a)gmail.com>
Hello Wolfgang,
Thank you for the response. However, as I read this documentation this should not be
necessary. Even still, if I try it, it does not seem to help.
Thanks,
Mike
On Jan 24, 2010, at 9:17 AM, Wolfgang Laun wrote:
> On Sun, Jan 24, 2010 at 8:16 AM, Mike Dougherty <mjdougherty(a)gmail.com> wrote:
>
> I'm inserting a TrainingStatus object that should match this rule. But the
resulting object does not have the nextSection and previousSection fields set to the
values they should.
>
> Only because you mention the insertion of the TrainingStatus object but not the
one(s) of (a) StatusProperty object(s): They should be inserted, too!
>
> -W
>
>
> _______________________________________________
> rules-users mailing list
> rules-users(a)lists.jboss.org
> https://lists.jboss.org/mailman/listinfo/rules-users
_______________________________________________
rules-users mailing list
rules-users(a)lists.jboss.org
https://lists.jboss.org/mailman/listinfo/rules-users
--
Edson Tirelli
JBoss Drools Core Development
JBoss by Red Hat @ www.jboss.com
_______________________________________________
rules-users mailing list
rules-users(a)lists.jboss.org
https://lists.jboss.org/mailman/listinfo/rules-users
12:24 p.m.
2010/1/25 Mike Dougherty <mjdougherty(a)gmail.com>
Hello Wolfgang,
Thank you for the response. However, as I read this documentation this
should not be necessary.
But it is, definitely. Matching and binding a Java object the way you do it
in your rule
property : StatusProperty( ... )
will only work if such an object has been inserted.
Even still, if I try it, it does not seem to help.
Could you please post your Java code from session creation til
fireAllRules(), with all the
object creations and inserts?
Even if you insert the StatusProperty objects, your rule may still not fire
if you do, for
instance, insertion of the TrainingStatus object before you add the
StatusProperty
objects to the Set<StatusProperty> of the inserted training status!
-W
Thanks,
Mike
On Jan 24, 2010, at 9:17 AM, Wolfgang Laun wrote:
On Sun, Jan 24, 2010 at 8:16 AM, Mike Dougherty <mjdougherty(a)gmail.com>wrote:
>
> I'm inserting a TrainingStatus object that should match this rule. But the
> resulting object does not have the nextSection and previousSection fields
> set to the values they should.
Only because you mention the insertion of the TrainingStatus object but not
the one(s) of (a) StatusProperty object(s): They should be inserted, too!
-W
_______________________________________________
rules-users mailing list
rules-users(a)lists.jboss.org
https://lists.jboss.org/mailman/listinfo/rules-users
_______________________________________________
rules-users mailing list
rules-users(a)lists.jboss.org
https://lists.jboss.org/mailman/listinfo/rules-users
5355
days inactive
5356
days old
7 comments
3 participants
participants (3)
-
Edson Tirelli -
Mike Dougherty -
Wolfgang Laun