TL;DR: We forked the grafana build tools [0] and built a commit off the
master branch that we knew to be stable. In addition we modified the build
scripts to include some Grafana plugins inside the container image. There
were two reasons we did this.
1. We were depending on new features in Grafana that were only available on
the master branch. Grafana was under very heavy development as they geared
up towards their 5.0 release and we were finding new problems arising every
few days while we worked off the master branch. This was really slowing
down APB development.
2. We needed to install additional plugins required by some
dashboards. Grafana's
docker image provides a way to install plugins using environment variables
fed into the container at runtime but this requires root access which is
not feasible in Openshift. The only way we could do it at the time was by
baking in the plugins as part of the docker build. It's a terrible solution
but it was the only way at the time to continue the very fast pace of
development of the APBs.
There are still a some questions to be answered:
* How are we going to distribute Grafana on OpenShift such that it doesn't
require root access?
* What is the best way to install plugins? There was some discussion about
the different options and the consequences of those options in this
document [1]
This all arose during a sprint where one of the primary goals was to
deliver an APB that could provision Grafana + Prometheus and display
dashboard discovery and some other features. We decided at the time that we
were not prepared to answer those bigger questions so we knowingly put this
technical debt on ourselves and implemented a quick and dirty solution.
This entire thing was discussed publicly in a Github PR:
https://github.com/aerogearcatalog/keycloak-apb/pull/33 But perhaps it
should also have been mentioned on list at the time. Hope this clears
things up.
[0]:
https://github.com/aerogear/grafana-docker
[1]:
https://docs.google.com/document/d/1WAUQ9IfJovSSUsHYR2PU3UeRWdpuyoKN9_Imy...
On Thu, Mar 15, 2018 at 9:27 AM, David Martin <davmarti(a)redhat.com> wrote:
I remember a rember there's a reason for having a custom image
built
(we need specific features that aren't in latest upstream image), but
I'm not sure who pushed it up and from where.
@Dara @Steven, is there a fork of grafana or some repo where we have
the Dockerfile?
On 14 March 2018 at 15:15, Matthias Wessendorf <matzew(a)apache.org> wrote:
> Hi,
>
> I am not able to find the image for this container:
>
https://hub.docker.com/r/aerogearcatalog/grafana/
>
> If not an automated build repo, we should at least point to the actual
> aerogear GH repository, where the thing is located.
>
> Thanks
>
> --
> Matthias Wessendorf
>
> github:
https://github.com/matzew
> twitter:
http://twitter.com/mwessendorf
>
> --
> You received this message because you are subscribed to the Google Groups
> "Aerogear" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to aerogear+unsubscribe(a)googlegroups.com.
> To post to this group, send email to aerogear(a)googlegroups.com.
> To view this discussion on the web visit
>
https://groups.google.com/d/msgid/aerogear/CAAg5f2RgsYFDWqG%3DX%3Dj%
3D48fVhCH2nrgjRuXNdNF9za3nt8uhSQ%40mail.gmail.com.
> For more options, visit
https://groups.google.com/d/optout.
--
David Martin
Red Hat Mobile
Twitter: @irldavem
IRC: @irldavem (#aerogear)
--
Dara Hayes
Associate software engineer
<
https://redhat.com> TRIED. TESTED. TRUSTED. <
https://redhat.com/trusted>