10:01 a.m.
Hi All,
In the scope of https://issues.jboss.org/browse/AEROGEAR-803 , we have a
method to retrieve an user (based on its id). If the user don't exist it
returns null.
There were some suggestions to change that into :
- throwing a runtime exception (seems a bit brutal)
- or returning an empty user (can be confusing)
What is your opinion about this ?
Seb
ps: the method https://gist.github.com/4510879
10:55 a.m.
On Jan 11, 2013, at 10:01 AM, Sebastien Blanc <scm.blanc(a)gmail.com> wrote:
Hi All,
In the scope of https://issues.jboss.org/browse/AEROGEAR-803 , we have a method to
retrieve an user (based on its id). If the user don't exist it returns null.
There were some suggestions to change that into :
- throwing a runtime exception (seems a bit brutal)
This does seem brutal, unless there is some security issues with not doing this
i think it should be the client dev's responsibility to check if the return value
exists.
- or returning an empty user (can be confusing)
What is your opinion about this ?
Seb
ps: the method https://gist.github.com/4510879
_______________________________________________
aerogear-dev mailing list
aerogear-dev(a)lists.jboss.org
https://lists.jboss.org/mailman/listinfo/aerogear-dev
10:55 a.m.
Hey Seb,
I'd go with an exception which can be handled. You could perhaps have an
error route for it and have the choice of either forwarding to a view or
returning json as a response to the calling client.
/Dan
On 11 January 2013 16:01, Sebastien Blanc <scm.blanc(a)gmail.com> wrote:
Hi All,
In the scope of https://issues.jboss.org/browse/AEROGEAR-803 , we have a
method to retrieve an user (based on its id). If the user don't exist it
returns null.
There were some suggestions to change that into :
- throwing a runtime exception (seems a bit brutal)
- or returning an empty user (can be confusing)
What is your opinion about this ?
Seb
ps: the method https://gist.github.com/4510879
_______________________________________________
aerogear-dev mailing list
aerogear-dev(a)lists.jboss.org
https://lists.jboss.org/mailman/listinfo/aerogear-dev
11:02 a.m.
On Fri, Jan 11, 2013 at 4:01 PM, Sebastien Blanc <scm.blanc(a)gmail.com> wrote:
Hi All,
In the scope of https://issues.jboss.org/browse/AEROGEAR-803 , we have a
method to retrieve an user (based on its id). If the user don't exist it
returns null.
There were some suggestions to change that into :
- throwing a runtime exception (seems a bit brutal)
+1 on exception
-M
- or returning an empty user (can be confusing)
What is your opinion about this ?
Seb
ps: the method https://gist.github.com/4510879
_______________________________________________
aerogear-dev mailing list
aerogear-dev(a)lists.jboss.org
https://lists.jboss.org/mailman/listinfo/aerogear-dev
--
Matthias Wessendorf
blog: http://matthiaswessendorf.wordpress.com/
sessions: http://www.slideshare.net/mwessendorf
twitter: http://twitter.com/mwessendorf
11:07 a.m.
What is really wrong with returning 'null' ?
I'm used to this situation when using Hibernate for example, when the user
don't exist then it just return null and it's up to the developer (as Lucas
said) to handle this situation ...
Seb
On Fri, Jan 11, 2013 at 5:02 PM, Matthias Wessendorf <matzew(a)apache.org>wrote:
On Fri, Jan 11, 2013 at 4:01 PM, Sebastien Blanc
<scm.blanc(a)gmail.com>
wrote:
> Hi All,
> In the scope of https://issues.jboss.org/browse/AEROGEAR-803 , we have a
> method to retrieve an user (based on its id). If the user don't exist it
> returns null.
>
> There were some suggestions to change that into :
> - throwing a runtime exception (seems a bit brutal)
+1 on exception
-M
> - or returning an empty user (can be confusing)
>
> What is your opinion about this ?
>
> Seb
>
> ps: the method https://gist.github.com/4510879
>
>
>
> _______________________________________________
> aerogear-dev mailing list
> aerogear-dev(a)lists.jboss.org
> https://lists.jboss.org/mailman/listinfo/aerogear-dev
>
--
Matthias Wessendorf
blog: http://matthiaswessendorf.wordpress.com/
sessions: http://www.slideshare.net/mwessendorf
twitter: http://twitter.com/mwessendorf
_______________________________________________
aerogear-dev mailing list
aerogear-dev(a)lists.jboss.org
https://lists.jboss.org/mailman/listinfo/aerogear-dev
11:14 a.m.
Just that it might cause an error later down that could possibly be hard to
track down, that is all. The application might fail at some later stage
long after this call was made.
/Dan
On 11 January 2013 17:07, Sebastien Blanc <scm.blanc(a)gmail.com> wrote:
What is really wrong with returning 'null' ?
I'm used to this situation when using Hibernate for example, when the user
don't exist then it just return null and it's up to the developer (as Lucas
said) to handle this situation ...
Seb
On Fri, Jan 11, 2013 at 5:02 PM, Matthias Wessendorf <matzew(a)apache.org>wrote:
> On Fri, Jan 11, 2013 at 4:01 PM, Sebastien Blanc <scm.blanc(a)gmail.com>
> wrote:
> > Hi All,
> > In the scope of https://issues.jboss.org/browse/AEROGEAR-803 , we have
> a
> > method to retrieve an user (based on its id). If the user don't exist it
> > returns null.
> >
> > There were some suggestions to change that into :
> > - throwing a runtime exception (seems a bit brutal)
>
> +1 on exception
>
> -M
>
>
> > - or returning an empty user (can be confusing)
> >
> > What is your opinion about this ?
> >
> > Seb
> >
> > ps: the method https://gist.github.com/4510879
> >
> >
> >
> > _______________________________________________
> > aerogear-dev mailing list
> > aerogear-dev(a)lists.jboss.org
> > https://lists.jboss.org/mailman/listinfo/aerogear-dev
> >
>
>
>
> --
> Matthias Wessendorf
>
> blog: http://matthiaswessendorf.wordpress.com/
> sessions: http://www.slideshare.net/mwessendorf
> twitter: http://twitter.com/mwessendorf
> _______________________________________________
> aerogear-dev mailing list
> aerogear-dev(a)lists.jboss.org
> https://lists.jboss.org/mailman/listinfo/aerogear-dev
>
_______________________________________________
aerogear-dev mailing list
aerogear-dev(a)lists.jboss.org
https://lists.jboss.org/mailman/listinfo/aerogear-dev
11:06 a.m.
+1 for an empty user if you're just doing a query.
+1 for throw a runtime exception BRUTAL (if you're check if the user can login)
AG Sec will handle this exception and return the appropriate HTTP status code. Something
like "401 - I'm brutal"
--
"The measure of a man is what he does with power" - Plato
-
@abstractj
-
Volenti Nihil Difficile
On Friday, January 11, 2013 at 1:01 PM, Sebastien Blanc wrote:
Hi All,
In the scope of https://issues.jboss.org/browse/AEROGEAR-803 , we have a method to
retrieve an user (based on its id). If the user don't exist it returns null.
There were some suggestions to change that into :
- throwing a runtime exception (seems a bit brutal)
- or returning an empty user (can be confusing)
What is your opinion about this ?
Seb
ps: the method https://gist.github.com/4510879
_______________________________________________
aerogear-dev mailing list
aerogear-dev(a)lists.jboss.org (mailto:aerogear-dev@lists.jboss.org)
https://lists.jboss.org/mailman/listinfo/aerogear-dev
11:57 a.m.
On 11/01/2013, at 13:01, Sebastien Blanc <scm.blanc(a)gmail.com> wrote:
Hi All,
In the scope of https://issues.jboss.org/browse/AEROGEAR-803 , we have a method to
retrieve an user (based on its id). If the user don't exist it returns null.
There were some suggestions to change that into :
- throwing a runtime exception (seems a bit brutal)
+1
- or returning an empty user (can be confusing)
-1
What is your opinion about this ?
Seb
ps: the method https://gist.github.com/4510879
_______________________________________________
aerogear-dev mailing list
aerogear-dev(a)lists.jboss.org
https://lists.jboss.org/mailman/listinfo/aerogear-dev
2:45 a.m.
Ok,
We have a majority for the Exception, so go! go! go! for the runtime
Exception , shall I create a new Exception in ag-security ? Suggestions for
the name ?
Seb
On Fri, Jan 11, 2013 at 5:57 PM, Douglas Campos <qmx(a)qmx.me> wrote:
On 11/01/2013, at 13:01, Sebastien Blanc <scm.blanc(a)gmail.com> wrote:
> Hi All,
> In the scope of https://issues.jboss.org/browse/AEROGEAR-803 , we have
a method to retrieve an user (based on its id). If the user don't exist it
returns null.
>
> There were some suggestions to change that into :
> - throwing a runtime exception (seems a bit brutal)
+1
> - or returning an empty user (can be confusing)
-1
>
> What is your opinion about this ?
>
> Seb
>
> ps: the method https://gist.github.com/4510879
>
>
> _______________________________________________
> aerogear-dev mailing list
> aerogear-dev(a)lists.jboss.org
> https://lists.jboss.org/mailman/listinfo/aerogear-dev
_______________________________________________
aerogear-dev mailing list
aerogear-dev(a)lists.jboss.org
https://lists.jboss.org/mailman/listinfo/aerogear-dev
3:09 a.m.
Just go with RuntimeException and we change it if necessary.
--
"The measure of a man is what he does with power" - Plato
-
@abstractj
-
Volenti Nihil Difficile
On Monday, January 14, 2013 at 5:45 AM, Sebastien Blanc wrote:
Ok,
We have a majority for the Exception, so go! go! go! for the runtime Exception , shall I
create a new Exception in ag-security ? Suggestions for the name ?
Seb
On Fri, Jan 11, 2013 at 5:57 PM, Douglas Campos <qmx(a)qmx.me (mailto:qmx@qmx.me)>
wrote:
>
> On 11/01/2013, at 13:01, Sebastien Blanc <scm.blanc(a)gmail.com
(mailto:scm.blanc@gmail.com)> wrote:
>
> > Hi All,
> > In the scope of https://issues.jboss.org/browse/AEROGEAR-803 , we have a method
to retrieve an user (based on its id). If the user don't exist it returns null.
> >
> > There were some suggestions to change that into :
> > - throwing a runtime exception (seems a bit brutal)
> +1
> > - or returning an empty user (can be confusing)
> -1
> >
> > What is your opinion about this ?
> >
> > Seb
> >
> > ps: the method https://gist.github.com/4510879
> >
> >
> > _______________________________________________
> > aerogear-dev mailing list
> > aerogear-dev(a)lists.jboss.org (mailto:aerogear-dev@lists.jboss.org)
> > https://lists.jboss.org/mailman/listinfo/aerogear-dev
>
>
> _______________________________________________
> aerogear-dev mailing list
> aerogear-dev(a)lists.jboss.org (mailto:aerogear-dev@lists.jboss.org)
> https://lists.jboss.org/mailman/listinfo/aerogear-dev
_______________________________________________
aerogear-dev mailing list
aerogear-dev(a)lists.jboss.org (mailto:aerogear-dev@lists.jboss.org)
https://lists.jboss.org/mailman/listinfo/aerogear-dev
4118
days inactive
4121
days old
10 comments
6 participants
participants (6)
-
Bruno Oliveira -
Daniel Bevenius -
Douglas Campos -
Lucas Holmquist -
Matthias Wessendorf -
Sebastien Blanc