Hi, I saw that there was some discussion about whitespace in a javascript file on a PR yesterday. Now it seems to me that among the things to discuss whitespace is just noise,

especially because formatting can be done automatically.

Talking with qmx and lholmquist about this it seems that JS land doesn't have good tools for this.

To have something in the mean time we could use something like the eclipse formatter, because it can format JS has a ton of options and there are already a lot of external tools that use it: https://github.com/krasa/EclipseCodeFormatter

https://code.google.com/p/maven-java-formatter-plugin

http://liviutudor.com/2012/03/02/batch-source-formatting-in-eclipse-indigo/

So how about having something like this that will format our JS for us? We could integrate something like this in our build, or that or create our own CLI tool as long as we have something that will work so that we don't have to discuss formatting anymore, what do you think?

Cheers, Erik Jan _______________________________________________ aerogear-dev mailing list aerogear-dev(a)lists.jboss.org https://lists.jboss.org/mailman/listinfo/aerogear-dev

> Talking with qmx and lholmquist about this it seems that JS land doesn't > have good tools for this. > hrm - the grunt worked for me; but I don't know if it is _that_ good The formatter that is available with grunt seems to have very little settings [1], but if that is fine for most of us by all means we should use it! [1] https://npmjs.org/package/grunt-jsbeautifier

> > To have something in the mean time we could use something like the > eclipse formatter, because it can format JS has a ton of options and there > are already a lot of external tools that use it: > > https://github.com/krasa/EclipseCodeFormatter > I doubt that a JS weenie will use Eclipse/IDEA It's meant as an example you don't need the full eclipse IDE to use the formatting tool. It can be used standalone and it has a ton of options about where to put whitespace. We could also build our own javascript code formatter, but why not have something that works today. And I think even a javascript coder can execute a command line utility. Just trying to be pragmatic _______________________________________________ aerogear-dev mailing list aerogear-dev(a)lists.jboss.org https://lists.jboss.org/mailman/listinfo/aerogear-dev

On Oct 29, 2013, at 7:14 AM, Matthias Wessendorf <matzew(a)apache.org&gt; wrote: > > > > On Tue, Oct 29, 2013 at 12:08 PM, Erik Jan de Wit <edewit(a)redhat.com&gt; wrote: >> >> Talking with qmx and lholmquist about this it seems that JS land doesn't have good tools for this. >> >> >> hrm - the grunt worked for me; but I don't know if it is _that_ good grunt will run jshint, which doesn't do the formatting for you, but tells you what you need to fix. but until up to a point. I think there is a difference between formatting and whitespace > > The formatter that is available with grunt seems to have very little settings [1], but if that is fine for most of us by all means we should use it! > > [1] https://npmjs.org/package/grunt-jsbeautifier > > perhaps here we could help/improve ? +1 to this option > > >> >> >> To have something in the mean time we could use something like the eclipse formatter, because it can format JS has a ton of options and there are already a lot of external tools that use it: >> >> https://github.com/krasa/EclipseCodeFormatter >> >> I doubt that a JS weenie will use Eclipse/IDEA > Correct, none of us "Rock Stars" would use an IDE :) > It's meant as an example you don't need the full eclipse IDE to use the formatting tool. It can be used standalone and it has a ton of options about where to put whitespace. We could also build our own javascript code formatter, but why not have something that works today. And I think even a javascript coder can execute a command line utility. if there is a java dependency then it is a no go for JS land > > Just trying to be pragmatic > > > > _______________________________________________ > aerogear-dev mailing list > aerogear-dev(a)lists.jboss.org > https://lists.jboss.org/mailman/listinfo/aerogear-dev > > > > -- > Matthias Wessendorf > > blog: http://matthiaswessendorf.wordpress.com/ > sessions: http://www.slideshare.net/mwessendorf > twitter: http://twitter.com/mwessendorf > _______________________________________________ > aerogear-dev mailing list > aerogear-dev(a)lists.jboss.org > https://lists.jboss.org/mailman/listinfo/aerogear-dev _______________________________________________ aerogear-dev mailing list aerogear-dev(a)lists.jboss.org https://lists.jboss.org/mailman/listinfo/aerogear-dev

On Oct 29, 2013, at 6:39 AM, Erik Jan de Wit <edewit(a)redhat.com&gt; wrote: > Hi, > > I saw that there was some discussion about whitespace in a javascript file on a PR yesterday. Now it seems to me that among the things to discuss whitespace is just noise, especially because formatting can be done automatically. I think part of this was the fact that somethings didn't need to be revisioned.( some IDE's like to do stuff ). I think it is important as part of the commit process that we need to be making sure that we are only committing changes that we made.

> Talking with qmx and lholmquist about this it seems that JS land doesn't have good tools for this. > > To have something in the mean time we could use something like the eclipse formatter, because it can format JS has a ton of options and there are already a lot of external tools that use it: > > https://github.com/krasa/EclipseCodeFormatter > https://code.google.com/p/maven-java-formatter-plugin > http://liviutudor.com/2012/03/02/batch-source-formatting-in-eclipse-indigo/ > > So how about having something like this that will format our JS for us? We could integrate something like this in our build, or that or create our own CLI tool as long as we have something that will work so that we don't have to discuss formatting anymore, what do you think? > > Cheers, > Erik Jan > _______________________________________________ > aerogear-dev mailing list > aerogear-dev(a)lists.jboss.org > https://lists.jboss.org/mailman/listinfo/aerogear-dev _______________________________________________ aerogear-dev mailing list aerogear-dev(a)lists.jboss.org https://lists.jboss.org/mailman/listinfo/aerogear-dev

On Oct 29, 2013, at 6:39 AM, Erik Jan de Wit <edewit(a)redhat.com&gt; wrote: Hi, I saw that there was some discussion about whitespace in a javascript file on a PR yesterday. Now it seems to me that among the things to discuss whitespace is just noise, especially because formatting can be done automatically. I think part of this was the fact that somethings didn't need to be revisioned.( some IDE's like to do stuff ). I think it is important as part of the commit process that we need to be making sure that we are only committing changes that we made.

Talking with qmx and lholmquist about this it seems that JS land doesn't have good tools for this. To have something in the mean time we could use something like the eclipse formatter, because it can format JS has a ton of options and there are already a lot of external tools that use it: https://github.com/krasa/EclipseCodeFormatter https://code.google.com/p/maven-java-formatter-plugin http://liviutudor.com/2012/03/02/batch-source-formatting-in-eclipse-indigo/ So how about having something like this that will format our JS for us? We could integrate something like this in our build, or that or create our own CLI tool as long as we have something that will work so that we don't have to discuss formatting anymore, what do you think? Cheers, Erik Jan _______________________________________________ aerogear-dev mailing list aerogear-dev(a)lists.jboss.org https://lists.jboss.org/mailman/listinfo/aerogear-dev _______________________________________________ aerogear-dev mailing list aerogear-dev(a)lists.jboss.org https://lists.jboss.org/mailman/listinfo/aerogear-dev

On Oct 29, 2013, at 8:23 AM, Sebastien Blanc <scm.blanc(a)gmail.com&gt; wrote: On Tue, Oct 29, 2013 at 2:20 PM, Lucas Holmquist <lholmqui(a)redhat.com&gt;wrote: > > On Oct 29, 2013, at 6:39 AM, Erik Jan de Wit <edewit(a)redhat.com&gt; wrote: > > Hi, > > I saw that there was some discussion about whitespace in a javascript > file on a PR yesterday. Now it seems to me that among the things to > discuss whitespace is just noise, especially because formatting can be done > automatically. > > > I think part of this was the fact that somethings didn't need to be > revisioned.( some IDE's like to do stuff ). > > I think it is important as part of the commit process that we need to > be making sure that we are only committing changes that we made. > +1 and I take entirely responsibility for this one. Auto format from IDEs are evil. And running grunt without any warning should be a condition before pushing. Well, isn't that an implied condition?? You should always make sure the build passes before you send a PR or push any code.

> > > Talking with qmx and lholmquist about this it seems that JS land doesn't > have good tools for this. > > To have something in the mean time we could use something like the > eclipse formatter, because it can format JS has a ton of options and there > are already a lot of external tools that use it: > > https://github.com/krasa/EclipseCodeFormatter > https://code.google.com/p/maven-java-formatter-plugin > > http://liviutudor.com/2012/03/02/batch-source-formatting-in-eclipse-indigo/ > > So how about having something like this that will format our JS for us? > We could integrate something like this in our build, or that or create our > own CLI tool as long as we have something that will work so that we don't > have to discuss formatting anymore, what do you think? > > Cheers, > Erik Jan > _______________________________________________ > aerogear-dev mailing list > aerogear-dev(a)lists.jboss.org > https://lists.jboss.org/mailman/listinfo/aerogear-dev > > > > _______________________________________________ > aerogear-dev mailing list > aerogear-dev(a)lists.jboss.org > https://lists.jboss.org/mailman/listinfo/aerogear-dev > _______________________________________________ aerogear-dev mailing list aerogear-dev(a)lists.jboss.org https://lists.jboss.org/mailman/listinfo/aerogear-dev _______________________________________________ aerogear-dev mailing list aerogear-dev(a)lists.jboss.org https://lists.jboss.org/mailman/listinfo/aerogear-dev

Hi, I saw that there was some discussion about whitespace in a javascript file on a PR yesterday. Now it seems to me that among the things to discuss whitespace is just noise, especially because formatting can be done automatically. Talking with qmx and lholmquist about this it seems that JS land doesn't have good tools for this. To have something in the mean time we could use something like the eclipse formatter, because it can format JS has a ton of options and there are already a lot of external tools that use it: https://github.com/krasa/EclipseCodeFormatter https://code.google.com/p/maven-java-formatter-plugin http://liviutudor.com/2012/03/02/batch-source-formatting-in-eclipse-indigo/ So how about having something like this that will format our JS for us? We could integrate something like this in our build, or that or create our own CLI tool as long as we have something that will work so that we don't have to discuss formatting anymore, what do you think?

Cheers, Erik Jan

Not only JavaScript. For instance, it would be great to have Maven Checkstyle Plugin for Java/Android.

I think you got check style confused with an other tool because it works on an abstract syntax tree see http://checkstyle.sourceforge.net/config.html

There are PRs for a few months

for AEROGEAR-336: https://github.com/aerogear/aerogear-parent/pull/4 and https://github.com/aerogear/aerogear-misc/pull/1 . All that's needed is: 1/ Release new version of aerogear-misc 2/ Release new version of aerogear-parent 3/ Bump parent in all Maven based project So far checkstyle only checks for unused imports, but the file itself can easily be updated to accommodate your needs.