I am +0.99 on this. As long as it's easy and the risk of breaking a bunch of stuff is low.

On Mar 22, 2013, at 8:55 AM, Summers Pittman <supittma(a)redhat.com&gt; wrote: > Y'all, > > I noticed that some of the method and class names in AeroGear Android around Paging are sub obtimal. > > I would like to, before 1.0 is cut, make the following changes > > Methods: > PageConfig.setPageHeaderParser -> PageConfig.setParameterProvider > > > Classed: > > PageResultExtractor -> ParameterProvider > ParameterProvider -> gets merged into Parameter Provider > > All implementations are updated > > wdyt? > > _______________________________________________ > aerogear-dev mailing list > aerogear-dev(a)lists.jboss.org > https://lists.jboss.org/mailman/listinfo/aerogear-dev _______________________________________________ aerogear-dev mailing list aerogear-dev(a)lists.jboss.org https://lists.jboss.org/mailman/listinfo/aerogear-dev

Y'all, I noticed that some of the method and class names in AeroGear Android around Paging are sub obtimal. I would like to, before 1.0 is cut, make the following changes Methods: PageConfig.setPageHeaderParser -> PageConfig.setParameterProvider Classed: PageResultExtractor -> ParameterProvider ParameterProvider -> gets merged into Parameter Provider All implementations are updated wdyt? _______________________________________________ aerogear-dev mailing list aerogear-dev(a)lists.jboss.org https://lists.jboss.org/mailman/listinfo/aerogear-dev

From the spec: A parameter provider API will be provided to that the application developer can submit any (paging) parameter that the used server requires. An example would be that the used paging service supports sorting as well. That is what this class did and is getting renamed to be correct.

You are referring to Paging parameters. On 03/22/2013 10:05 AM, Matthias Wessendorf wrote: parameter provider, is used to specify the "query" (e.g. limit/offset , page. per-page) etc Is that waht it does ? On Fri, Mar 22, 2013 at 2:55 PM, Summers Pittman <supittma(a)redhat.com&gt;wrote: > Y'all, > > I noticed that some of the method and class names in AeroGear Android > around Paging are sub obtimal. > > I would like to, before 1.0 is cut, make the following changes > > Methods: > PageConfig.setPageHeaderParser -> PageConfig.setParameterProvider > > > Classed: > > PageResultExtractor -> ParameterProvider > ParameterProvider -> gets merged into Parameter Provider > > All implementations are updated > > wdyt? > > > _______________________________________________ > aerogear-dev mailing list > aerogear-dev(a)lists.jboss.org > https://lists.jboss.org/mailman/listinfo/aerogear-dev > -- Matthias Wessendorf blog: http://matthiaswessendorf.wordpress.com/ sessions: http://www.slideshare.net/mwessendorf twitter: http://twitter.com/mwessendorf _______________________________________________ aerogear-dev mailing listaerogear-dev@lists.jboss.orghttps://lists.jboss.org/mailman/listinfo/aerogear-dev _______________________________________________ aerogear-dev mailing list aerogear-dev(a)lists.jboss.org https://lists.jboss.org/mailman/listinfo/aerogear-dev

On Fri, Mar 22, 2013 at 3:07 PM, Summers Pittman <supittma(a)redhat.com <mailto:supittma@redhat.com>> wrote: From the spec: A|parameter provider|API will be provided to that the application developer can submit any (paging) parameter that the used server requires. An example would be that the used paging service supports sorting as well. That is what this class did and is getting renamed to be correct. You are referring to Paging parameters. https://github.com/aerogear/aerogear.org/blob/master/docs/specs/aerogear-...

On 03/22/2013 10:05 AM, Matthias Wessendorf wrote: > parameter provider, is used to specify the "query" (e.g. > limit/offset , page. per-page) etc > > Is that waht it does ? > > On Fri, Mar 22, 2013 at 2:55 PM, Summers Pittman > <supittma(a)redhat.com <mailto:supittma@redhat.com>> wrote: > > Y'all, > > I noticed that some of the method and class names in AeroGear > Android around Paging are sub obtimal. > > I would like to, before 1.0 is cut, make the following changes > > Methods: > PageConfig.setPageHeaderParser -> PageConfig.setParameterProvider > > > Classed: > > PageResultExtractor -> ParameterProvider > ParameterProvider -> gets merged into Parameter Provider > > All implementations are updated > > wdyt? > > > _______________________________________________ > aerogear-dev mailing list > aerogear-dev(a)lists.jboss.org > <mailto:aerogear-dev@lists.jboss.org> > https://lists.jboss.org/mailman/listinfo/aerogear-dev > > > > > -- > Matthias Wessendorf > > blog: http://matthiaswessendorf.wordpress.com/ > sessions: http://www.slideshare.net/mwessendorf > twitter: http://twitter.com/mwessendorf > > > _______________________________________________ > aerogear-dev mailing list > aerogear-dev(a)lists.jboss.org <mailto:aerogear-dev@lists.jboss.org> > https://lists.jboss.org/mailman/listinfo/aerogear-dev _______________________________________________ aerogear-dev mailing list aerogear-dev(a)lists.jboss.org <mailto:aerogear-dev@lists.jboss.org> https://lists.jboss.org/mailman/listinfo/aerogear-dev -- Matthias Wessendorf blog: http://matthiaswessendorf.wordpress.com/ sessions: http://www.slideshare.net/mwessendorf twitter: http://twitter.com/mwessendorf _______________________________________________ aerogear-dev mailing list aerogear-dev(a)lists.jboss.org https://lists.jboss.org/mailman/listinfo/aerogear-dev