After thinking about this for a bit, I think I would vote to not bundle those deps. I don't think there should be any errors thrown unless someone uses an interface that has one of those dependencies. If it does, that's an issue we need to fix. I think we need to spell out very clearly what is required to use those adapters and provide links. On Jun 17, 2013, at 2:30 PM, Lucas Holmquist <lholmqui(a)redhat.com&gt; wrote: > So AeroGear.js, the notifier stuff, has external dependencies on stomp.js / socks.js , depending on what adapter you use. ( probably also the vertxbus.js also ) > > The question is do we package these external dependencies with our JS libs or do we say "These are needed, so here are links to get them". > > Using Bower, we can add the socks-client.js file, but not the others. > > currently jQuery is a dependency, but we don't package that > > > THoughts? > _______________________________________________ > aerogear-dev mailing list > aerogear-dev(a)lists.jboss.org > https://lists.jboss.org/mailman/listinfo/aerogear-dev _______________________________________________ aerogear-dev mailing list aerogear-dev(a)lists.jboss.org https://lists.jboss.org/mailman/listinfo/aerogear-dev

On Jun 17, 2013, at 2:47 PM, Lucas Holmquist <lholmqui(a)redhat.com&gt; wrote: > i can agree with that. > > I know where to get the socks-client.js and the vertxbus.js, but where is the stomp.js file from Well, it came from here https://github.com/hornetq/hornetq/blob/master/examples/jms/stomp-websock... After looking at that though, I have no idea where it came from. Is it a general STOMP JS impl, is it hornetq specific? I have no idea. Also, the first comment in that file also troubles me … making me consider not doing a STOMP adapter but not sure if just the vert.x adapter is enough for now. > > > to bad they all don't have bower stuff > > On Jun 17, 2013, at 3:46 PM, Kris Borchers <kris(a)redhat.com&gt; wrote: > >> After thinking about this for a bit, I think I would vote to not bundle those deps. I don't think there should be any errors thrown unless someone uses an interface that has one of those dependencies. If it does, that's an issue we need to fix. I think we need to spell out very clearly what is required to use those adapters and provide links. >> >> On Jun 17, 2013, at 2:30 PM, Lucas Holmquist <lholmqui(a)redhat.com&gt; wrote: >> >>> So AeroGear.js, the notifier stuff, has external dependencies on stomp.js / socks.js , depending on what adapter you use. ( probably also the vertxbus.js also ) >>> >>> The question is do we package these external dependencies with our JS libs or do we say "These are needed, so here are links to get them". >>> >>> Using Bower, we can add the socks-client.js file, but not the others. >>> >>> currently jQuery is a dependency, but we don't package that >>> >>> >>> THoughts? >>> _______________________________________________ >>> aerogear-dev mailing list >>> aerogear-dev(a)lists.jboss.org >>> https://lists.jboss.org/mailman/listinfo/aerogear-dev >> >> >> _______________________________________________ >> aerogear-dev mailing list >> aerogear-dev(a)lists.jboss.org >> https://lists.jboss.org/mailman/listinfo/aerogear-dev > > > _______________________________________________ > aerogear-dev mailing list > aerogear-dev(a)lists.jboss.org > https://lists.jboss.org/mailman/listinfo/aerogear-dev _______________________________________________ aerogear-dev mailing list aerogear-dev(a)lists.jboss.org https://lists.jboss.org/mailman/listinfo/aerogear-dev

Well, it came from here https://github.com/hornetq/hornetq/blob/master/examples/jms/stomp-websock... After looking at that though, I have no idea where it came from. Is it a general STOMP JS impl, is it hornetq specific? I have no idea. Also, the first comment in that file also troubles me … making me consider not doing a STOMP adapter but not sure if just the vert.x adapter is enough for now.