Re: [hibernate-dev] AssociationType.isEmbeddedInXML() no longer used

Hi Steve, I've created the following issues that are assigned to you: HHH-7777 : Deprecate XmlRepresentableType HHH-7776 : Consolidate to/from string handling for types in StringRepresentableType I've added deprecation and removal of EntityType.isNotEmbedded() to HHH-7771 and HHH-7772. I'll fix those. Regards, Gail ----- Original Message ----- > From: "Steve Ebersole" <steve(a)hibernate.org&gt; > To: "Gail Badner" <gbadner(a)redhat.com&gt; > Cc: "Hibernate hibernate-dev" <hibernate-dev(a)lists.jboss.org&gt;, "Strong Liu" <stliu(a)hibernate.org&gt; > Sent: Thursday, November 8, 2012 7:20:38 PM > Subject: Re: [hibernate-dev] AssociationType.isEmbeddedInXML() no longer used > > I was saying to use StringRepresentableType in replacement of > toXMLString() and fromXMLString(). > > Most implementations of these things just delegate amongst > themselves. > > On Thu 08 Nov 2012 08:15:23 PM CST, Gail Badner wrote: >> I've created HHH-7770 for removing attributes from hbm.xml mapping >> elements related to EntityMode.DOM4J. Should this be done in >> metamodel branch for 5.0? Is there any way (or reason) to >> deprecate these attributes before 5.0? >> >> I've also created HHH-7771 for deprecating obsolete Type and >> AssociationType methods left over from EntityMode.DOM4J. I set the >> target as 4.1.9. >> >> I've created HHH-7772 to remove the deprecated code in 5.0. >> >> I'd like to get rid of code having to do with being "embedded in >> XML" because it is yet another way the word "embedded" is used >> that adds to confusion. >> >> EnhancedUserType and XmlRepresentableType have toXMLString() and >> fromXMLString(). I am not sure if these are still needed. >> >> Steve mentioned something about adding >> org.hibernate.type.StringRepresentableType to handle basic to/from >> string handling. I see that StringRepresentableType already has >> toString() and fromStringValue(). >> >> Steve, are you thinking that toXMLString() and fromXMLString() >> would be added to StringRepresentableType? >> >> What about fromString(), toLoggableString()? Would these be added >> to StringRepresentableType? >> >> I don't think this is related to being "embedded in XML", but I >> noticed there is also EntityType.isNotEmbedded(), which always >> returns false. AFAICT, it has no impact on anything and can also >> be deprecated in 4.x and removed in 5.0. Or am I missing something >> here? >> >> Thanks, >> Gail >> >> ----- Original Message ----- >>> From: "Strong Liu" <stliu(a)hibernate.org&gt; >>> To: "Gail Badner" <gbadner(a)redhat.com&gt; >>> Cc: "Hibernate hibernate-dev" <hibernate-dev(a)lists.jboss.org&gt; >>> Sent: Wednesday, October 31, 2012 8:43:56 AM >>> Subject: Re: [hibernate-dev] AssociationType.isEmbeddedInXML() no >>> longer used >>> >>> >>> >>> >>> On Oct 31, 2012, at 5:54 AM, Gail Badner < gbadner(a)redhat.com > >>> wrote: >>> >>> >>> I see that AssociationType.isEmbeddedInXML() is no longer used >>> anywhere. >>> >>> Is this left over from EntityMode.DOM4J? >>> >>> >>> >>> yes, and I think there is still other methods relate to this >>> >>> >>> >>> If so, should I go ahead and remove >>> AssociationType.isEmbeddedInXML() >>> and its implementation from metamodel branch? >>> >>> >>> >>> +1 >>> >>> >>> >>> Regards, >>> Gail >>> _______________________________________________ >>> hibernate-dev mailing list >>> hibernate-dev(a)lists.jboss.org >>> https://lists.jboss.org/mailman/listinfo/hibernate-dev >>> >>> >>> >>> ------------------------- >>> Best Regards, >>> >>> Strong Liu <stliu at hibernate.org > >>> http://about.me/stliu/bio >>> > > -- > steve(a)hibernate.org > http://hibernate.org >