Re: [hibernate-dev] JDBC uses ON_CLOSE connection release mode

Thanks for the feedback, Fo the moment, the 5.0 docs are ready, and we can push the integration further, as you suggested. There will be other updates that we'll do to improve the docs (Envers, Spatial, Portability topics), and I'll make sure to split the 5.1-related things from changes that apply to 5.0. This way, we can maintain the 5.0 docs much more easily. Vlad On Tue, Apr 5, 2016 at 9:36 PM, Gail Badner <gbadner(a)redhat.com&gt; wrote: > Hi Vlad, > > It looks great! If it's ready to go, I'll push it to > https://docs.jboss.org/hibernate/orm/5.0/ and update the link on > hibernate.org. > > Thanks! > Gail > > On Mon, Apr 4, 2016 at 10:47 PM, Vlad Mihalcea <mihalcea.vlad(a)gmail.com&gt; > wrote: > >> Hi Gail, >> >> I removed the 5.1 references on the new User Guide. >> You can check it out and see how you like it: >> >> > cd documentation >> > gradle rUG >> >> Let me know what you think. >> >> Vlad >> >> On Mon, Apr 4, 2016 at 11:02 PM, Gail Badner <gbadner(a)redhat.com&gt; wrote: >> >>> Thanks much! >>> >>> On Mon, Apr 4, 2016 at 11:48 AM, Vlad Mihalcea <mihalcea.vlad(a)gmail.com >>> > wrote: >>> >>>> Sure, >>>> >>>> I'm going to take care of it tomorrow. >>>> >>>> Vlad >>>> >>>> On Mon, Apr 4, 2016 at 9:33 PM, Gail Badner <gbadner(a)redhat.com&gt; >>>> wrote: >>>> >>>>> Is there is any 5.1-specific content? If so, it needs to be stripped >>>>> out for 5.0. >>>>> >>>>> On Mon, Apr 4, 2016 at 6:35 AM, Vlad Mihalcea < >>>>> mihalcea.vlad(a)gmail.com&gt; wrote: >>>>> >>>>>> Hi Gail, >>>>>> >>>>>> I pushed the 5.1 documentation into the 5,0 branch. >>>>>> The only thing that's needed now is to modify the release procedure >>>>>> which I'll send it as a PR. >>>>>> >>>>>> We also have to modify the hibernate.org site so that 5.0 >>>>>> references the same documentation links as 5.1. >>>>>> >>>>>> Vlad >>>>>> >>>>>> On Thu, Mar 24, 2016 at 7:34 AM, Vlad Mihalcea < >>>>>> mihalcea.vlad(a)gmail.com&gt; wrote: >>>>>> >>>>>>> The 4.x branches contain the old documentation, the one that was >>>>>>> written with Hibernate 3 in mind. >>>>>>> >>>>>>> The new documentation work was started in 5.0 but we only got it >>>>>>> done in 5.1, so 5.0 doesn't contain all the additions we made to the new >>>>>>> documentation. >>>>>>> >>>>>>> I can backport it for sure, but I don't know if it won't break >>>>>>> something during the release phase. >>>>>>> >>>>>>> For this purpose, I'm going to split this task in two: >>>>>>> >>>>>>> 1. Copy the whole asciidoc User Guide that we wrote from scratch. >>>>>>> This step will contain a lot of modifications so it will be difficult to >>>>>>> review it in GitHub probably. But it can be reviewing manually. >>>>>>> 2. Modify the release procedure to use the new User Guide. This >>>>>>> step can be reviewed by you and Steve so we make sure we don't break >>>>>>> anything. >>>>>>> >>>>>>> Vlad >>>>>>> >>>>>>> On Thu, Mar 24, 2016 at 1:52 AM, Gail Badner <gbadner(a)redhat.com&gt; >>>>>>> wrote: >>>>>>> >>>>>>>> I noticed there is some information in 4.2 docs that are not in >>>>>>>> 5.0. I'm not sure what happened there. >>>>>>>> >>>>>>>> Is there info in the 5.1 docs that does not apply to 5.0? If so, >>>>>>>> is there a way to easily exclude it? >>>>>>>> >>>>>>>> I don't know what all is involved in backporting the docs. If it >>>>>>>> can be done safely and excluding 5.1-specific info, then please go ahead. >>>>>>>> >>>>>>>> Thanks! >>>>>>>> Gail >>>>>>>> >>>>>>>> On Wed, Mar 23, 2016 at 12:17 AM, Vlad Mihalcea < >>>>>>>> mihalcea.vlad(a)gmail.com&gt; wrote: >>>>>>>> >>>>>>>>> I made the change for 4.2. >>>>>>>>> >>>>>>>>> For 5.0, we should switch to the current 5.1 documentation >>>>>>>>> because the 5.0 User Guide lacks a lot of information. >>>>>>>>> It requires adding the asciidoc documentation, Gradle configs, >>>>>>>>> and also change the release procedure to use asciidoc instead of docbook. >>>>>>>>> >>>>>>>>> Should we add a new task for this? >>>>>>>>> >>>>>>>>> Vlad >>>>>>>>> >>>>>>>>> On Tue, Mar 22, 2016 at 8:07 PM, Gail Badner <gbadner(a)redhat.com&gt; >>>>>>>>> wrote: >>>>>>>>> >>>>>>>>>> Hi Vlad, >>>>>>>>>> >>>>>>>>>> Yes, please update the doc for 5.0 and 4.2. >>>>>>>>>> >>>>>>>>>> Thanks! >>>>>>>>>> Gail >>>>>>>>>> >>>>>>>>>> On Sun, Mar 20, 2016 at 11:37 PM, Vlad Mihalcea < >>>>>>>>>> mihalcea.vlad(a)gmail.com&gt; wrote: >>>>>>>>>> >>>>>>>>>>> Hi Gail, >>>>>>>>>>> >>>>>>>>>>> For the 5.0 branch, I could update the doc for this issue. A >>>>>>>>>>> new release will publish the updated doc, right? >>>>>>>>>>> Should the documentation be updated for the 4.x branches too? >>>>>>>>>>> >>>>>>>>>>> Vlad >>>>>>>>>>> >>>>>>>>>>> On Thu, Mar 17, 2016 at 9:04 PM, Steve Ebersole < >>>>>>>>>>> steve(a)hibernate.org&gt; wrote: >>>>>>>>>>> >>>>>>>>>>>> It looks like it changed during 3.6 -> 4.0, reverting back to >>>>>>>>>>>> ON_CLOSE. I agree it should changed to AFTER_TRANSACTION, >>>>>>>>>>>> however I would only change it on master. >>>>>>>>>>>> >>>>>>>>>>>> For the other branches, if anything, just update the doc. >>>>>>>>>>>> >>>>>>>>>>>> >>>>>>>>>>>> On Thu, Mar 3, 2016 at 12:40 AM Vlad Mihalcea < >>>>>>>>>>>> mihalcea.vlad(a)gmail.com&gt; wrote: >>>>>>>>>>>> >>>>>>>>>>>>> I think this PR is valid: >>>>>>>>>>>>> >>>>>>>>>>>>> https://github.com/hibernate/hibernate-orm/pull/997 >>>>>>>>>>>>> >>>>>>>>>>>>> I checked it out and, when using JDBC, we use the ON_CLOSE >>>>>>>>>>>>> connection >>>>>>>>>>>>> release mode. >>>>>>>>>>>>> >>>>>>>>>>>>> Shouldn't we use the AFTER_TRANSACTION release mode as we >>>>>>>>>>>>> state in the docs? >>>>>>>>>>>>> >>>>>>>>>>>>> Vlad >>>>>>>>>>>>> _______________________________________________ >>>>>>>>>>>>> hibernate-dev mailing list >>>>>>>>>>>>> hibernate-dev(a)lists.jboss.org >>>>>>>>>>>>> https://lists.jboss.org/mailman/listinfo/hibernate-dev >>>>>>>>>>>>> >>>>>>>>>>>> >>>>>>>>>>> >>>>>>>>>> >>>>>>>>> >>>>>>>> >>>>>>> >>>>>> >>>>> >>>> >>> >> >