Thanks Guillaume,
regarding data cleaning, I was thinking of having the tests drop the
database by adding a method to
org.hibernate.ogm.test.utils.TestableGridDialect.
If you could focus on making the tests pass / disable them in the
short term, I'll look into fixing the testsuite.
Cheers,
Sanne
On 20 March 2012 18:28, Guillaume SCHEIBEL <guillaume.scheibel(a)gmail.com> wrote:
Hi all,
Ok Sanne, thanks for the code review. I'll work in those point. As we said,
I will configure surefire to skip all tests that use associations.
About the other points, MongoHQ is a paas provider (Cloudbees is actually
working whith it) but working with a PAAS provider will probably requiering
some modifications on the connection part to use url and authentification.
And about the stored data cleaning, I'm going to check what can be done.
Cheers,
Guillaume
2012/3/20 Sanne Grinovero <sanne(a)hibernate.org>
>
> Hello all,
> I'm satisfied with this structure as a good starting point; let's know
> hack together from this reference; please discard the previous
> branches.
>
> git@github.com:hibernate/hibernate-ogm.git
>
> branch: mongodb
>
> There are some limitations, so I wasn't happy to integrate it in master
> yet.
> The main problems are:
>
> 1# It's not passing all tests. This is my current output:
> Tests run: 30, Failures: 0, Errors: 16, Skipped: 0
>
> Simply put, the GridDialect is not complete as it's not implementing
> all methods.
>
> 2# Even passing the tests, it requires a MongoDB instance to connect to.
> Not sure yet how we're going to deal with this for continuous
> integration.. I guess we need MongoDB installed on the Jenkins
> machines, or use some external PAAS.
>
> I've identified some other minor problems too: not all tests cleanup
> properly - some of these failures appear to be induced by previous
> failures, like uncommitted transactions still bound to the running
> thread.
>
https://hibernate.onjira.com/browse/OGM-138
>
> Last problem, since MongoDB actually remembers state between test runs
> we need to make sure we cleanup stored data as well; I'll extend the
> core module testsuite for this.
>
https://hibernate.onjira.com/browse/OGM-139
>
> Regards,
> Sanne