8:15 a.m.
While developing the Byte Buddy Enhancer, Rafael ran into what I thnk is a
valid problem in the ORM build. Namely the fact that we incorporate
non-fatal Checktyle checks. In local builds this leads to a situation
where it is extremely difficult for new contributors to find out what
exactly they violated. Jenkins presents these better and makes it easier
to see just "fatal" (high priority) violations, but the Checktype report
itself does not. Even worse the Checkstyle report does not even show the
priority of individual violations at all.
I suggest we remove all non-fatal Checkstyle rules to make it easier on
contributors.
9:14 a.m.
What do you think about having different profiles?
One for new contributors (more relaxed)
and one for active developers.
Given that I'm not sure what kind of checkstyle rules we are talking about.
On Wed, Nov 9, 2016 at 2:15 PM, Steve Ebersole <steve(a)hibernate.org> wrote:
While developing the Byte Buddy Enhancer, Rafael ran into what I thnk
is a
valid problem in the ORM build. Namely the fact that we incorporate
non-fatal Checktyle checks. In local builds this leads to a situation
where it is extremely difficult for new contributors to find out what
exactly they violated. Jenkins presents these better and makes it easier
to see just "fatal" (high priority) violations, but the Checktype report
itself does not. Even worse the Checkstyle report does not even show the
priority of individual violations at all.
I suggest we remove all non-fatal Checkstyle rules to make it easier on
contributors.
_______________________________________________
hibernate-dev mailing list
hibernate-dev(a)lists.jboss.org
https://lists.jboss.org/mailman/listinfo/hibernate-dev
9:20 a.m.
I like Davide's proposal. +1
On Wed, Nov 9, 2016 at 5:14 PM, Davide D'Alto <davide(a)hibernate.org> wrote:
What do you think about having different profiles?
One for new contributors (more relaxed)
and one for active developers.
Given that I'm not sure what kind of checkstyle rules we are talking about.
On Wed, Nov 9, 2016 at 2:15 PM, Steve Ebersole <steve(a)hibernate.org>
wrote:
> While developing the Byte Buddy Enhancer, Rafael ran into what I thnk is
a
> valid problem in the ORM build. Namely the fact that we incorporate
> non-fatal Checktyle checks. In local builds this leads to a situation
> where it is extremely difficult for new contributors to find out what
> exactly they violated. Jenkins presents these better and makes it easier
> to see just "fatal" (high priority) violations, but the Checktype report
> itself does not. Even worse the Checkstyle report does not even show the
> priority of individual violations at all.
>
> I suggest we remove all non-fatal Checkstyle rules to make it easier on
> contributors.
> _______________________________________________
> hibernate-dev mailing list
> hibernate-dev(a)lists.jboss.org
> https://lists.jboss.org/mailman/listinfo/hibernate-dev
_______________________________________________
hibernate-dev mailing list
hibernate-dev(a)lists.jboss.org
https://lists.jboss.org/mailman/listinfo/hibernate-dev
9:22 a.m.
Gradle does not have profiles. So you mean different tasks?
On Wed, Nov 9, 2016 at 9:20 AM Vlad Mihalcea <mihalcea.vlad(a)gmail.com>
wrote:
I like Davide's proposal. +1
On Wed, Nov 9, 2016 at 5:14 PM, Davide D'Alto <davide(a)hibernate.org>
wrote:
What do you think about having different profiles?
One for new contributors (more relaxed)
and one for active developers.
Given that I'm not sure what kind of checkstyle rules we are talking about.
On Wed, Nov 9, 2016 at 2:15 PM, Steve Ebersole <steve(a)hibernate.org>
wrote:
> While developing the Byte Buddy Enhancer, Rafael ran into what I thnk is
a
> valid problem in the ORM build. Namely the fact that we incorporate
> non-fatal Checktyle checks. In local builds this leads to a situation
> where it is extremely difficult for new contributors to find out what
> exactly they violated. Jenkins presents these better and makes it easier
> to see just "fatal" (high priority) violations, but the Checktype report
> itself does not. Even worse the Checkstyle report does not even show the
> priority of individual violations at all.
>
> I suggest we remove all non-fatal Checkstyle rules to make it easier on
> contributors.
> _______________________________________________
> hibernate-dev mailing list
> hibernate-dev(a)lists.jboss.org
> https://lists.jboss.org/mailman/listinfo/hibernate-dev
_______________________________________________
hibernate-dev mailing list
hibernate-dev(a)lists.jboss.org
https://lists.jboss.org/mailman/listinfo/hibernate-dev
9:42 a.m.
https://hibernate.atlassian.net/browse/HHH-11235
On Wed, Nov 9, 2016 at 9:22 AM Steve Ebersole <steve(a)hibernate.org> wrote:
Gradle does not have profiles. So you mean different tasks?
On Wed, Nov 9, 2016 at 9:20 AM Vlad Mihalcea <mihalcea.vlad(a)gmail.com>
wrote:
I like Davide's proposal. +1
On Wed, Nov 9, 2016 at 5:14 PM, Davide D'Alto <davide(a)hibernate.org>
wrote:
What do you think about having different profiles?
One for new contributors (more relaxed)
and one for active developers.
Given that I'm not sure what kind of checkstyle rules we are talking about.
On Wed, Nov 9, 2016 at 2:15 PM, Steve Ebersole <steve(a)hibernate.org>
wrote:
> While developing the Byte Buddy Enhancer, Rafael ran into what I thnk is
a
> valid problem in the ORM build. Namely the fact that we incorporate
> non-fatal Checktyle checks. In local builds this leads to a situation
> where it is extremely difficult for new contributors to find out what
> exactly they violated. Jenkins presents these better and makes it easier
> to see just "fatal" (high priority) violations, but the Checktype report
> itself does not. Even worse the Checkstyle report does not even show the
> priority of individual violations at all.
>
> I suggest we remove all non-fatal Checkstyle rules to make it easier on
> contributors.
> _______________________________________________
> hibernate-dev mailing list
> hibernate-dev(a)lists.jboss.org
> https://lists.jboss.org/mailman/listinfo/hibernate-dev
_______________________________________________
hibernate-dev mailing list
hibernate-dev(a)lists.jboss.org
https://lists.jboss.org/mailman/listinfo/hibernate-dev
9:20 a.m.
http://ci.hibernate.org/job/hibernate-orm-master-h2-check/106/checkstyleR...
Any of the 0 versus 2846 + 609
On Wed, Nov 9, 2016 at 9:14 AM Davide D'Alto <davide(a)hibernate.org> wrote:
What do you think about having different profiles?
One for new contributors (more relaxed)
and one for active developers.
Given that I'm not sure what kind of checkstyle rules we are talking about.
On Wed, Nov 9, 2016 at 2:15 PM, Steve Ebersole <steve(a)hibernate.org>
wrote:
> While developing the Byte Buddy Enhancer, Rafael ran into what I thnk is
a
> valid problem in the ORM build. Namely the fact that we incorporate
> non-fatal Checktyle checks. In local builds this leads to a situation
> where it is extremely difficult for new contributors to find out what
> exactly they violated. Jenkins presents these better and makes it easier
> to see just "fatal" (high priority) violations, but the Checktype report
> itself does not. Even worse the Checkstyle report does not even show the
> priority of individual violations at all.
>
> I suggest we remove all non-fatal Checkstyle rules to make it easier on
> contributors.
> _______________________________________________
> hibernate-dev mailing list
> hibernate-dev(a)lists.jboss.org
> https://lists.jboss.org/mailman/listinfo/hibernate-dev
2970
days inactive
2970
days old
5 comments
3 participants
participants (3)
-
Davide D'Alto -
Steve Ebersole -
Vlad Mihalcea