Re: [hibernate-dev] Pull request

Hi Sanne, The PR queue has not been neglected at all. The problem was that the issue was still marked with the "Requires Changes" label, and I assumed it was not done yet.

Vlad On Wed, Jun 7, 2017 at 12:41 PM, Sanne Grinovero <sanne(a)hibernate.org&gt; wrote: > > Hi Milo, > > apologies for that. The ORM team had some meetings, travelling, etc.. > I guess the PR queue has been temporarily neglected and they'll have > to catch up. > > I don't think you missed something, good idea to call for attention on > the mailing list. > > Thanks, > Sanne > > > On 6 June 2017 at 20:36, Milo van der Zee <milo(a)vanderzee.org&gt; wrote: > > Hello, > > > > I submitted a pull request and fixed some issues with it (jUnit test and > > formatting) and after that nothing happens. How does this work? Do I > > just have to be patient or do I miss something? > > > > https://github.com/hibernate/hibernate-orm/pull/1906 > > > > MAG, > > Milo > > > > _______________________________________________ > > hibernate-dev mailing list > > hibernate-dev(a)lists.jboss.org > > https://lists.jboss.org/mailman/listinfo/hibernate-dev > _______________________________________________ > hibernate-dev mailing list > hibernate-dev(a)lists.jboss.org > https://lists.jboss.org/mailman/listinfo/hibernate-dev