I agree. The whole signed-off thing just sounded
just-a-little-less-annoying than signing a CLA. And it misses covering
non-PR contributions - we (committer) could do the signed-off as we apply
the patch, but that defeats the whole intent.
So yes, I was glad that Richard saw this the same way.
BTW.. can't remember if I mentioned it, but I also worked on README.md[1]
and the ORM contributing website page[2]. For whatever reason the
README.md is rendering goofy now - if anyone has ideas why, would love to
hear how to fix it. It uses asciidoc(tor) syntax as part of a markdown
file so not sure how GitHub ever rendered that properly before.
[1]
https://github.com/hibernate/hibernate-orm/blob/master/README.md
[2]
http://hibernate.org/orm/contribute/
On Wed, Aug 9, 2017 at 5:42 AM Sanne Grinovero <sanne(a)hibernate.org> wrote:
On 9 August 2017 at 09:21, Guillaume Smet
<guillaume.smet(a)gmail.com>
wrote:
> On Tue, Aug 8, 2017 at 11:56 PM, Steve Ebersole <steve(a)hibernate.org>
wrote:
>>
>> signed-off is not required. Richard is in agreement with that. Of
course
>> if you feel it is warranted and useful you can use it the other
projects,
>> but for ORM I am making the decision to not complicate these processes
>> needlessly.
>
>
> If not strictly necessary, I'm +1 for not requiring the sign off on the
> NoORM projects. I suspect it will make the process as painful as the
current
> CLA process (it's not a common thing so we will have to ask people to
amend
> their commits).
I agree it would have been a barrier; the whole "signed-off"
discussion had me worried.. just checking that we indeed got explicit
directions of not needing to bother with it, that would make me happy.
Thanks Steve!