Re: [hibernate-dev] [HSEARCH] Breaking some contracts

Cool I definitely like the immutable SearchFactory. while you're thinking about a new contract to accomodate the new requirements, could you also consider the following so that we won't have to break twice: 1) Lucene's new near-real-time indexing enables you to open an IndexReader from the currently open IndexWriter (to share some open buffers). This means a ReaderProvider could benefit from somehow getting a reference to the currently opened IndexWriter - makes sense only when using a Lucene backend so it should be optional. 2) If we really need HSEARCH-152, it would need the DirectoryProvider to be able to get access to the relevant Workspace: it needs to ask the current IndexWriter to take snapshots and prevent the IW to be closed while it's replicating. Seems there's going to be a mutual dependency, so one of the two will likely not be able to be immutable. Workspace could register itself back to the DP? I didn't thinkg about it yet, but would likely need to change the contracts too. 3) About Infinispan DirectoryProvider : seems a good time to workout the SPI idea you where having, to be able to plug it in while it's built by a separate module? Reminder: that's a requirement for InfinispanDP because it needs Java6. The DP itself is trivial to implement, if you pave the road to this pattern. sorry for being the complicator at this round... please make it as simple as possible, just consider that these are on the "todo soon" list too. Cheers, Sanne 2010/6/7 Emmanuel Bernard <emmanuel(a)hibernate.org&gt;: