Re: [hibernate-dev] Preparing to release 4.3.8 and 4.2.17

Hi Petar, we have different instructions for Eclipse or IntelliJ users; here you should find general contribution guidelines and also the code styles attached: - https://developer.jboss.org/wiki/ContributingToHibernateUsingEclipse - https://developer.jboss.org/wiki/ContributingToHibernateUsingIntelliJ And another hint: while we'd love new patches to follow the formatting and style conventions, please never reformat existing code so that patches are as small as needed for the fix/feature. That makes it far easier to understand the patch, and possibly avoid some pain if eventually someone wants to port your fix to a different branch. Also, could you please sign the contributor's agreement? https://cla.jboss.org -> pick "Hibernate" in the drop down menu. Thanks for your help! Sanne On 6 January 2015 at 09:50, Petar Tahchiev <paranoiabla(a)gmail.com&gt; wrote: > Hi Gail, > > can you point me to the Hibernate code formatter file (for eclipse or > intellij idea)? I'm trying to find it but i cannot. > > 2015-01-06 11:00 GMT+02:00 Gail Badner <gbadner(a)redhat.com&gt;: > >> Hi Peter, >> >> It looks like your pull request changed tabs to spaces, so there are a lot >> of diffs. I can't tell what exactly you changed. Please recreate the pull >> request without changing tabs to spaces. >> >> I'm sorry, this will not make it into 4.3.8. I'll consider it for 4.3.9. >> >> Regards, >> Gail >> >> ----- Original Message ----- >> > From: "Petar Tahchiev" <paranoiabla(a)gmail.com&gt; >> > To: "Gail Badner" <gbadner(a)redhat.com&gt; >> > Cc: "hibernate-dev" <hibernate-dev(a)lists.jboss.org&gt; >> > Sent: Tuesday, January 6, 2015 12:47:11 AM >> > Subject: Re: [hibernate-dev] Preparing to release 4.3.8 and 4.2.17 >> > >> > Any chance to get this included >> > https://github.com/hibernate/hibernate-orm/pull/863 ? >> > >> > >> > 2015-01-06 10:37 GMT+02:00 Gail Badner <gbadner(a)redhat.com&gt;: >> > >> > > I've finished building and taggind for 4.2.17.Final. I'm getting some >> > > final fixes in for 4.3.8.Final, then I'll release that version. I'll >> finish >> > > these up on Tuesday. >> > > Gail >> > > >> > > ----- Original Message ----- >> > > > From: "Gail Badner" <gbadner(a)redhat.com&gt; >> > > > To: "hibernate-dev" <hibernate-dev(a)lists.jboss.org&gt; >> > > > Sent: Monday, January 5, 2015 1:10:08 PM >> > > > Subject: [hibernate-dev] Preparing to release 4.3.8 and 4.2.17 >> > > > >> > > > I'm getting ready to release 4.3.8 and 4.2.17. Please do not push >> any new >> > > > fixes until they are released. >> > > > >> > > > Thanks! >> > > > Gail >> > > > _______________________________________________ >> > > > hibernate-dev mailing list >> > > > hibernate-dev(a)lists.jboss.org >> > > > https://lists.jboss.org/mailman/listinfo/hibernate-dev >> > > > >> > > _______________________________________________ >> > > hibernate-dev mailing list >> > > hibernate-dev(a)lists.jboss.org >> > > https://lists.jboss.org/mailman/listinfo/hibernate-dev >> > > >> > >> > >> > >> > -- >> > Regards, Petar! >> > Karlovo, Bulgaria. >> > --- >> > Public PGP Key at: >> > >> https://keyserver1.pgp.com/vkd/DownloadKey.event?keyid=0x19658550C3110611 >> > Key Fingerprint: A369 A7EE 61BC 93A3 CDFF 55A5 1965 8550 C311 0611 >> > >> > > > > -- > Regards, Petar! > Karlovo, Bulgaria. > --- > Public PGP Key at: > https://keyserver1.pgp.com/vkd/DownloadKey.event?keyid=0x19658550C3110611 > Key Fingerprint: A369 A7EE 61BC 93A3 CDFF 55A5 1965 8550 C311 0611 > _______________________________________________ > hibernate-dev mailing list > hibernate-dev(a)lists.jboss.org > https://lists.jboss.org/mailman/listinfo/hibernate-dev