Re: [hibernate-dev] [Search] Useless dependency on solr-analysis-extras
Hi Hardy,
On Thu, Dec 13, 2012 at 10:49 AM, Hardy Ferentschik <hardy(a)hibernate.org> wrote:
I am fine with removing it, but maybe we need to sync the docs in
this case as well. It says now:
"all required Solr dependencies are now defined as dependencies of the artifact
org.hibernate:hibernate-search-analysers;
just add the following dependency"
IIRC, this sentence is here because Hibernate Search used to package
the analyzers extracted from Solr in a specific Jar. It was removed in
favor of a dependency to Solr jars when they were pushed to Maven not
so long ago.
IMHO, the important word in this sentence is the "required" in "all
*required* Solr dependencies": stempel, ICU and smartcn aren't
required at all: if you want these specific analyzers, you just have
to add a dependency to them, which isn't surprising.
It doesn't seem like a bad idea to be consistent with how Lucene have
rearranged their analyzers and to include all the lucene-analyzers +
the Solr machinery used to wrap them.
I think it's worth a note in the release notes though if we go this way.
I'll go create a JIRA as you asked.
Thanks.
--
Guillaume