Re: [hibernate-dev] [HSEARCH] Extract core of HSEARCH query engine to be independent of Hibernate Core.
2011/2/23 Emmanuel Bernard <emmanuel(a)hibernate.org>:
On 23 févr. 2011, at 19:56, Emmanuel Bernard wrote:
>> 1) TimeoutManager should throw specific exceptions directly, depending
>> on the framework being used
>> (see the pull request I sent you [1], I think it solves the issue, we
>> might want to polish it a bit to have the JPA interface define it's
>> own specific factory.
>
> I'll have a look
I've applied your pull request. Good catch.
You also said you wanted a better integration between timeout manager and HSQuery, do you
have ideas in mind? Let's try and discuss that tomorrow morning (I'm at the BeJUG
in the evening).
No need: there was a method catching a timeout to throw a second
timeout, but I had that changed in my pull request and you applied
that already.
For reference, it was the part of the patch starting at this line:
[
https://github.com/emmanuelbernard/hibernate-search/commit/c0631ac76d96af...
]
I think we should be able to remove the need for the method
"reactOnQueryTimeoutExceptionWhileExtracting", but doesn't need to be
part of these changes.
Currently only the CriteriaObjectsInitializer seems to invoke that method.
Have a good trip to BeJUG,
Sanne