So far so good, for the maven build I have added 2 things:
- <excludes>**/target/generated-sources/*.java</excludes> into the
hibernate-ogm-parent checkstyle plugin conf, to avoid the check of the
generated classes
- <property name="lineSeparator" value="lf"/> to the checkstyle
config
(module NewlineAtEndOfFile) otherwise, each file had an issue about newline
missing.
WDYT ?
2013/4/19 Gunnar Morling <gunnar(a)hibernate.org>
2013/4/19 Sanne Grinovero <sanne(a)hibernate.org>
> +1
> next on my wishlist, and was already chatting about it with Steve the
> other days. You guys should not hide from IRC :-P
> I won't be able to do it now, but feel free to add the repository,
> package name and necessary configuration changes in the
>
ci.hibernate.org repository so that it gets auto-installed as well at
> the next machine refresh. Or I'll look into it when I can.
>
> What URL would you all expect it on? Apparently if we want a different
> subdomain that takes quite some time; I'd expect something like
>
> -
ci.hibernate.org/sonar ?
> -
sonar.hibernate.org ?
> -
hibernate.org/sonar ?
>
> I'd pick the first one as I perceive it as a secondary service, we can
> then add a prominent link on the header of
ci.hibernate.org to point
> to it: we'd likely want to edit the header anyway to link to
>
hibernate.org, github et al.
>
I guess I'd like
sonar.hibernate.org most since I'd consider the two
services to be on the same level. But the others surely work, too.
One issue I had in the past with Sonar was that its configuration
(FindBugs, CheckStyle etc.) was independent from the corresponding
configuration for the build (Maven plug-ins). I.e. you had to change config
at two places when e.g. adding a new rule.
Therefore I preferred to use the Jenkins plug-ins for FindBugs, CheckStyle
etc, which then could use the same configuration as the Maven plug-ins.
Maybe that's not an issue anymore, though.
FWIW, I also liked having this info in Jenkins directly instead of having
yet another tool. But if you all love Sonar, that's fine with me, too.
--Gunnar
>
> Sanne
>
>
>
> On 19 April 2013 10:29, Hardy Ferentschik <hardy(a)hibernate.org> wrote:
> > Sonar is great. I am running it locally to get the metrics. That's the
> part I am missing for HV on Cloudbees. Unfortunately, it is not included
in
> the free offering.
> >
> >
> >
> > --hardy
> >
> >
> >
> > On 19 Apr 2013, at 11:24, Strong Liu <stliu(a)hibernate.org> wrote:
> >
> >> btw, what do you guys think of sonar?
> >>
> >> shall we give it a try on ci.hibernate.org?
> >>
> >>
> >> On Apr 19, 2013, at 4:32 PM, Hardy Ferentschik <hardy(a)hibernate.org>
> wrote:
> >>
> >>>
> >>> On 19 Jan 2013, at 9:54 AM, Guillaume SCHEIBEL <
> guillaume.scheibel(a)gmail.com> wrote:
> >>>
> >>>> Where can I find the new style rule for Intellij and the checktyle
> plugin ?
> >>>
> >>> I think the existing style rules have not changed. See also
>
https://community.jboss.org/wiki/ContributingtoHibernateSearch#Idea
> >>> It is just that we enforce the rules now as part of the build.
> >>>
> >>> --Hardy
> >>>
> >>
> >> -------------------------
> >> Best Regards,
> >>
> >> Strong Liu <stliu at hibernate.org>
> >>
http://about.me/stliu/bio
> >>
> >>
> >>
> > _______________________________________________
> > hibernate-dev mailing list
> > hibernate-dev(a)lists.jboss.org
> >
https://lists.jboss.org/mailman/listinfo/hibernate-dev
> _______________________________________________
> hibernate-dev mailing list
> hibernate-dev(a)lists.jboss.org
>
https://lists.jboss.org/mailman/listinfo/hibernate-dev
>
_______________________________________________
hibernate-dev mailing list
hibernate-dev(a)lists.jboss.org
https://lists.jboss.org/mailman/listinfo/hibernate-dev