[hibernate-dev] JBoss Cache Searchable interfaces

Hi guys - a few comments on the public interfaces of SearchableCache - 1) IMO, I think that the SearchableCache.createQuery() method should *not* return a FullTextQuery, but instead a JBCS-specific CacheQuery interface with a subset of the methods in FullTextQuery. I think the only methods in FullTextQuery that are relevant and that should be carried across to CacheQuery are: * list() * iterator(); * setFirstResult(int i); * setMaxResults(int i); * setFetchSize(int i); * getResultSize(); * setSort(); I think all of the rest - such as filters, criteria and projections - are irrelevant to a query on a cache. WDYT? Emmanuel? 2) Also, rather than implement FullTextQuery.scroll() to return a ScrollableResults instance, I'd rather that iterator() returns an instance of a new interface, QueryResultsIterator, which extends j.u.ListIterator. This gives us the ability to scroll back and forth over a result set, and we could add additional methods to jump to a specific point in the result set and helpers such as isLast(), isFirst(), isBeforeLast(), isAfterFirst(), first(), last(), afterFirst(), beforeLast(). I think that any benefit of a scrollable result set window preventing loading unnecessary objects from a DB are lost when your backing store is a cache and the objects are in memory anyway. And besides, any further optimisations can be in the iterator implementation, such as just maintaining a list of CachedEntityIds (a composite of Fqn and key) and fetching the objects from the cache lazily, as required. Also, with the above, 2, we don't leak any Hibernate or Hibernate Search interfaces into the user API which again IMO is a good thing. Thoughts, comments? Cheers Manik On 24 Jun 2008, at 11:47, Navin Surtani wrote: -- Manik Surtani Lead, JBoss Cache manik(a)jboss.org