On 30.10.2014, at 23:43, Steve Ebersole <steve(a)hibernate.org&gt; wrote: Well telling me/us which PRs got closed would be a good first step :)

Overall, checking that the PR still applies is a good idea too.

On Thu, Oct 30, 2014 at 5:34 PM, Andrej Golovnin <golovnin(a)gmx.net&gt; wrote: > On 30.10.2014, at 23:15, Steve Ebersole <steve(a)hibernate.org&gt; wrote: > > Well maybe rather than being hurt and sensitive maybe just understand that it was not intentional. GitHub automatically closed them. It was simply a mistake. > > Or be sensitive and threatening about it. Whichever you think helps you best ;) This does not answer my 1. question. :-) What is the best way to proceed? Are you going to reopen the pull requests or should we create new requests? I think, that at least one of my patches must be modified to be applied to the "new master". Any clear small guide, what we (contributors) should do to reopen the pull requests or a small info that you will care about the closed pull requests and we should sit down, relax and wait until you are done, would be really helpful. > > On Oct 30, 2014 11:05 PM, "Andrej Golovnin" <golovnin(a)gmx.net&gt; wrote: > Hello Steve, > > you have closed my pull requests and > pull requests from others too without any comment. > > Should we create a new pull requests for the "new master" branch? > Or should we just forget all the time and the work we have invested > to create those pull requests and stop submitting any new pull requests > in the future? > > Best regards, > Andrej Golovnin

> Here are mines: I mean from me. I should not write emails early in the morning. I was still asleep. :-) > https://github.com/hibernate/hibernate-orm/pull/779 > https://github.com/hibernate/hibernate-orm/pull/782 > https://github.com/hibernate/hibernate-orm/pull/777 > > > > Overall, checking that the PR still applies is a good idea too. > I'll do that on the weekend.

Hi Steve, > > https://github.com/hibernate/hibernate-orm/pull/777 > > > > > > > Overall, checking that the PR still applies is a good idea too. while working on a new pull request for the issue HHH-9324 I have noticed that the new master misses some dialects: Oracle12cDialect PostgreSQL92Dialect PostgreSQL94Dialect Are you going to restore this dialects from the old master or should I add them back with the new pull request? Best regards, Andrej Golovnin

> They should get moved to the 4.3-based master. I think I found the relevant issues: > > * Oracle12cDialect - https://hibernate.atlassian.net/browse/HHH-9044 > * PostgreSQL92Dialect & PostgreSQL94Dialect - https://hibernate.atlassian.net/browse/HHH-9167 > > I have reopened them and targeted them for 5.0 Do you already know when they will get moved to the 4.3-based master? I think I should wait with my pull request until they get moved.

Don't you all think it's very troubling that several issues in JIRA are marked as "resolved" but are not actually integrated in the new master? This query is probably not perfect but I hope it's enough to highlight the problem: https://hibernate.atlassian.net/issues/?filter=15161&jql=project%20%3... On 1 December 2014 at 23:31, Steve Ebersole <steve(a)hibernate.org&gt; wrote: > I am finishing up the initial 5.0 work for master right now. I will work > on these next. Ping me at the end of the week so I dont forget :) > > On Mon, Dec 1, 2014 at 3:07 PM, Andrej Golovnin <golovnin(a)gmx.net&gt; wrote: > >> >> > They should get moved to the 4.3-based master. I think I found the >> relevant issues: >> > >> > * Oracle12cDialect - https://hibernate.atlassian.net/browse/HHH-9044 >> > * PostgreSQL92Dialect & PostgreSQL94Dialect - >> https://hibernate.atlassian.net/browse/HHH-9167 >> > >> > I have reopened them and targeted them for 5.0 >> >> Do you already know when they will get moved to the 4.3-based master? >> I think I should wait with my pull request until they get moved. > _______________________________________________ > hibernate-dev mailing list > hibernate-dev(a)lists.jboss.org > https://lists.jboss.org/mailman/listinfo/hibernate-dev

On 02.12.2014, at 00:31, Steve Ebersole <steve(a)hibernate.org&gt; wrote: I am finishing up the initial 5.0 work for master right now. I will work on these next. Ping me at the end of the week so I dont forget :)

On Mon, Dec 1, 2014 at 3:07 PM, Andrej Golovnin <golovnin(a)gmx.net&gt; wrote: > They should get moved to the 4.3-based master. I think I found the relevant issues: > > * Oracle12cDialect - https://hibernate.atlassian.net/browse/HHH-9044 > * PostgreSQL92Dialect & PostgreSQL94Dialect - https://hibernate.atlassian.net/browse/HHH-9167 > > I have reopened them and targeted them for 5.0 Do you already know when they will get moved to the 4.3-based master? I think I should wait with my pull request until they get moved.