Hi, I don't know what is your policy about the dependency management but, currently, when you include hibernate-entity-manager in the pom of an application, it comes with dependencies to 3.1.0.Final and 3.1.0.CR2. The problem is that hibernate-commons-annotations-4.0.1.Final requires 3.1.0.CR2 of jboss-logging. See: http://search.maven.org/remotecontent?filepath=org/hibernate/common/hiber... I was wondering if it was possible to add an exclusion to the hibernate-entity-manager pom.xml (or the Gradle equivalent) to not drag the jboss-logging dependency of hibernate-commons-annotations so that from the outside the dependencies of hibernate-entity-manager are clean. Thanks for your feedback. -- Guillaume _______________________________________________ hibernate-dev mailing list hibernate-dev(a)lists.jboss.org https://lists.jboss.org/mailman/listinfo/hibernate-dev

Hi Guillaume, I'll leave it to the gradle gurus on the team to say how to fix that, but I'm surprised that Maven suggests both dependencies, that should never be the case. As a workaround, if you define an explicit dependency on jboss-logging in your <dependencyManagement> section you should be able to avoid any ambiguity. I always specify dependency versions explicitly in this form (in our projects using Maven) so that might explain why we never noticed this problem. thanks, Sanne On 8 October 2012 13:49, Guillaume Smet <guillaume.smet(a)gmail.com&gt; wrote: > Hi, > > I don't know what is your policy about the dependency management but, > currently, when you include hibernate-entity-manager in the pom of an > application, it comes with dependencies to 3.1.0.Final and 3.1.0.CR2. > > The problem is that hibernate-commons-annotations-4.0.1.Final requires > 3.1.0.CR2 of jboss-logging. See: > http://search.maven.org/remotecontent?filepath=org/hibernate/common/hiber... > > I was wondering if it was possible to add an exclusion to the > hibernate-entity-manager pom.xml (or the Gradle equivalent) to not > drag the jboss-logging dependency of hibernate-commons-annotations so > that from the outside the dependencies of hibernate-entity-manager are > clean. > > Thanks for your feedback. > > -- > Guillaume > _______________________________________________ > hibernate-dev mailing list > hibernate-dev(a)lists.jboss.org > https://lists.jboss.org/mailman/listinfo/hibernate-dev _______________________________________________ hibernate-dev mailing list hibernate-dev(a)lists.jboss.org https://lists.jboss.org/mailman/listinfo/hibernate-dev

On 8 October 2012 15:44, Steve Ebersole <steve(a)hibernate.org&gt; wrote: > Nothing Gradle specific here. Not following why you say that. He is > talking about projects including hibernate-entitymanager, which I assume is > using Maven since I believe every Hibernate sub-project is still using Maven > to build (correct me if I am wrong there). What Guillaume is suggesting is that the pom.xml of the hibernate-entitymanager should exclude one version, to expose only the correct one. I think this pom.xml is generated by Gradle since EntityManger is a submodule of the Hibernate ORM repository? Cheers, Sanne > > That said, this is in fact exactly what Maven does. It just blindly > includes all versions. At least thats what it did in Maven 2. I have not > played much with Maven 3. You project, the one including > hibernate-entitymanager, controls this through <dependencyManagement/> to > name the singularized version of a dependency to pull in even across > transitive deps. Again, thats how it used to work in Maven 2, and I have > heard of no changes in that regard for Maven 3. > > On 10/08/2012 08:34 AM, Sanne Grinovero wrote: >> >> Hi Guillaume, >> I'll leave it to the gradle gurus on the team to say how to fix that, >> but I'm surprised that Maven suggests both dependencies, that should >> never be the case. >> >> As a workaround, if you define an explicit dependency on jboss-logging >> in your <dependencyManagement> section you should be able to avoid any >> ambiguity. >> >> I always specify dependency versions explicitly in this form (in our >> projects using Maven) so that might explain why we never noticed this >> problem. >> >> thanks, >> Sanne >> >> >> On 8 October 2012 13:49, Guillaume Smet <guillaume.smet(a)gmail.com&gt; wrote: >>> >>> Hi, >>> >>> I don't know what is your policy about the dependency management but, >>> currently, when you include hibernate-entity-manager in the pom of an >>> application, it comes with dependencies to 3.1.0.Final and 3.1.0.CR2. >>> >>> The problem is that hibernate-commons-annotations-4.0.1.Final requires >>> 3.1.0.CR2 of jboss-logging. See: >>> >>> http://search.maven.org/remotecontent?filepath=org/hibernate/common/hiber... >>> >>> I was wondering if it was possible to add an exclusion to the >>> hibernate-entity-manager pom.xml (or the Gradle equivalent) to not >>> drag the jboss-logging dependency of hibernate-commons-annotations so >>> that from the outside the dependencies of hibernate-entity-manager are >>> clean. >>> >>> Thanks for your feedback. >>> >>> -- >>> Guillaume >>> _______________________________________________ >>> hibernate-dev mailing list >>> hibernate-dev(a)lists.jboss.org >>> https://lists.jboss.org/mailman/listinfo/hibernate-dev >> >> _______________________________________________ >> hibernate-dev mailing list >> hibernate-dev(a)lists.jboss.org >> https://lists.jboss.org/mailman/listinfo/hibernate-dev > > > > -- > steve(a)hibernate.org > http://hibernate.org >

On Mon, Oct 8, 2012 at 7:05 PM, Steve Ebersole <steve(a)hibernate.org&gt; wrote: > That's not exactly how the deps work here. It is in fact hibernate-core > that introduces the dep on hibernate-commons-annotations, not > hibernate-entitymanager. AFAICS, nope. The dependency for hibernate-commons-annotations is in hibernate-entitymanager's pom.xml: http://search.maven.org/remotecontent?filepath=org/hibernate/hibernate-en... And it's not in hibernate-core.

On Mon, Oct 8, 2012 at 7:43 PM, Steve Ebersole <steve(a)hibernate.org&gt; wrote: > http://search.maven.org/remotecontent?filepath=org/hibernate/hibernate-co... Argh, stupid Firefox search. So the hibernate-commons-annotations dependency is in hibernate-entitymanager *and* hibernate-core.

Hi Sanne, On Mon, Oct 8, 2012 at 3:34 PM, Sanne Grinovero <sanne(a)hibernate.org&gt; wrote: > I'll leave it to the gradle gurus on the team to say how to fix that, > but I'm surprised that Maven suggests both dependencies, that should > never be the case. It doesn't include both, of course. But both dependencies are present and exposed.

We often have various dependencies with different versions so it's not a real problem. The problem here is that hibernate-entity-manager requires 2 versions of the same dependency. If I exclude it, I have to maintain the version by hand, which I'm not very fond of, especially for such technical dependencies. With Emmanuel's solution, you'll have to release a new version of hibernate-commons-annotations each time you upgrade jboss-logging in hibernate-entity-manager. That's why I thought excluding the jboss-logging dependency coming from hibernate-commons-annotations in hibernate-entity-manager might be a better idea. It's not a critical problem at all but I think it's worth it to have a clean dependency tree for components as widely used as Hibernate.

The fact is that if you use the maven-enforcer-plugin with the dependency convergence rule ( http://maven.apache.org/enforcer/enforcer-rules/dependencyConvergence.html ), just adding the hibernate-entity-manager dependency to any project breaks this rule.

-- Guillaume