Hello, I've upgraded awestruct to version 0.5.7. Except for the minification of our stylesheets it seems to work fine but It would be nice if someone else can have a look at generate site and confirm to me that's OK to apply the changes in production. On the same note, I've noticed that we are using some custom extensions to execute the minification, specifically the one in _ext/css_minifier.rb. Is there any reason to do that? I'm asking because Awestruct comes with its own minification class called: Awestruct::Extension::Minify The main difference I noticed is that this extension doesn't copy the original file during deploy on the server and only uses the minified one. Also currently, this extension doesn't work for CSS but I guess they are going to fix it in the next releases (it works for html and js). Cheers, Davide

Thanks for taking care of that. I clicked here and there, especially on the complex pages, and it looks good to me. Be careful when merging, we don't want the Corporate contributors page on the public website yet. Thanks! -- Guillaume On Wed, Jan 10, 2018 at 12:25 PM, Davide D'Alto <davide(a)hibernate.org&gt; wrote: > > Just to clarify, The websites to check are: > http://staging.in.relation.to and http://staging.hibernate.org > Sorry, I forgot to add the links in the previous mail. > > > On Wed, Jan 10, 2018 at 11:08 AM, Davide D'Alto <davide(a)hibernate.org&gt; > wrote: > > Hello, > > I've upgraded awestruct to version 0.5.7. > > > > Except for the minification of our stylesheets it seems to work fine > > but It would be nice if someone else can have a look at generate site > > and confirm to me that's > > OK to apply the changes in production. > > > > On the same note, I've noticed that we are using some custom > > extensions to execute the minification, specifically the one in > > _ext/css_minifier.rb. > > > > Is there any reason to do that? I'm asking because Awestruct comes > > with its own minification class called: Awestruct::Extension::Minify > > > > The main difference I noticed is that this extension doesn't copy the > > original file during deploy on the server and only uses the minified > > one. > > Also currently, this extension doesn't work for CSS but I guess they > > are going to fix it in the next releases (it works for html and js). > > > > Cheers, > > Davide > _______________________________________________ > hibernate-dev mailing list > hibernate-dev(a)lists.jboss.org > https://lists.jboss.org/mailman/listinfo/hibernate-dev