From: "Gail Badner" <gbadner(a)redhat.com&gt; To: "Hibernate Dev" <hibernate-dev(a)lists.jboss.org&gt; Sent: Tuesday, July 21, 2015 10:08:28 PM Subject: [hibernate-dev] org.hibernate.test.annotations.manytoone.referencedcolumnname.ManyToOneReferencedColumnNameTest I think this is probably just a bug in the test, but I want to mention it in case there is a real bug here. When I run the unit tests multiple times, sometimes I see WarehouseItem created with: create table WarehouseItem ( id integer generated by default as identity, version integer not null, qtyInStock decimal(19,2), vendor_id integer, item_id integer, primary key (id) ) Sometimes WarehouseItem is created with: create table WarehouseItem ( id integer generated by default as identity, version integer not null, qtyInStock decimal(19,2), ITEM_ID integer not null, VENDOR_ID integer not null, primary key (id) ) I started seeing this only recently (last couple of weeks or so). In the WarehouseItem class [1], the following join column names are specified: vendor_id, VENDOR_ID, item_id, ITEM_ID. I'm sure that making the column names consistent (upper or lower) case would make the table DDL consistent. I want to make sure I don't mask a real bug by making this change. Is this a bug in the test, or a bug in how column names are processed? [1] https://github.com/hibernate/hibernate-orm/blob/master/hibernate-core/src... _______________________________________________ hibernate-dev mailing list hibernate-dev(a)lists.jboss.org https://lists.jboss.org/mailman/listinfo/hibernate-dev

From: "Emmanuel Bernard" <emmanuel(a)hibernate.org&gt; To: "Gail Badner" <gbadner(a)redhat.com&gt; Cc: "Hibernate Dev" <hibernate-dev(a)lists.jboss.org&gt; Sent: Wednesday, July 22, 2015 1:40:37 AM Subject: Re: [hibernate-dev] org.hibernate.test.annotations.manytoone.referencedcolumnname.ManyToOneReferencedColumnNameTest I’d say it’s fair to ask the user to use consistent column naming so that would be a bug in the test. > On 22 Jul 2015, at 07:08, Gail Badner <gbadner(a)redhat.com&gt; wrote: > > I think this is probably just a bug in the test, but I want to mention it > in case there is a real bug here. > > When I run the unit tests multiple times, sometimes I see WarehouseItem > created with: > > create table WarehouseItem ( > id integer generated by default as identity, > version integer not null, > qtyInStock decimal(19,2), > vendor_id integer, > item_id integer, > primary key (id) > ) > > Sometimes WarehouseItem is created with: > create table WarehouseItem ( > id integer generated by default as identity, > version integer not null, > qtyInStock decimal(19,2), > ITEM_ID integer not null, > VENDOR_ID integer not null, > primary key (id) > ) > > I started seeing this only recently (last couple of weeks or so). > > In the WarehouseItem class [1], the following join column names are > specified: vendor_id, VENDOR_ID, item_id, ITEM_ID. > > I'm sure that making the column names consistent (upper or lower) case > would make the table DDL consistent. I want to make sure I don't mask a > real bug by making this change. > > Is this a bug in the test, or a bug in how column names are processed? > > [1] > https://github.com/hibernate/hibernate-orm/blob/master/hibernate-core/src... > > _______________________________________________ > hibernate-dev mailing list > hibernate-dev(a)lists.jboss.org > https://lists.jboss.org/mailman/listinfo/hibernate-dev