4:36 p.m.
Hi,
solr-analysis-extras is a big package as it comes with the following
dependencies:
3594568 2012-10-06 18:46 WEB-INF/lib/lucene-smartcn-3.6.1.jar
511956 2012-10-06 18:46 WEB-INF/lib/lucene-stempel-3.6.1.jar
which is 4 MB of dependencies which are usually not that useful
(stempel is a polish stemmer, smartcn is for chinese).
I checked and hibernate-search compiles perfectly when we remove the
dependency to solr-analysis-extras and we add a dependency to
solr-core as all the analyzers used by Hibernate Search (including
most of the locale dependent analyzers/stemmers) are now in
lucene-analyzers. IIRC, they were moved from solr-analysis-extras to
lucene-analyzers during the 3.x release cycle.
Apart from the size of the jars, as a lot of new Java features
(Servlet 3 related features for instance) are based on classpath
scanning, removing this useless dependency looks worthwhile to me.
So the plan is to replace the solr-analysis-extras dependency with
solr-core. I can work on a pull request if it looks sane to everyone.
Thanks for your feedback.
--
Guillaume
3:49 a.m.
Sounds reasonable to me. solr-analysis-extras contains the ICU [1] support classes which
is in many cases are not needed.
On the other hand most projects will include hibernate-search-analysers to get the basic
analysers and at the moment get this
additional dependencies as well.
I guess it comes down to whether we think that by including hibernate-search-analysers you
should get all Solr tokenizers [2] w/o
adding additional dependencies or whether it is ok to ask users to explicitly add the
solr-analysis-extras when required.
I am fine with removing it, but maybe we need to sync the docs in this case as well. It
says now:
"all required Solr dependencies are now defined as dependencies of the artifact
org.hibernate:hibernate-search-analysers;
just add the following dependency"
Either way you should create a Jira ticket.
--Hardy
[1] http://site.icu-project.org/
[2] http://wiki.apache.org/solr/AnalyzersTokenizersTokenFilters
On 12 Jan 2012, at 11:36 PM, Guillaume Smet <guillaume.smet(a)gmail.com> wrote:
Hi,
solr-analysis-extras is a big package as it comes with the following
dependencies:
3594568 2012-10-06 18:46 WEB-INF/lib/lucene-smartcn-3.6.1.jar
511956 2012-10-06 18:46 WEB-INF/lib/lucene-stempel-3.6.1.jar
which is 4 MB of dependencies which are usually not that useful
(stempel is a polish stemmer, smartcn is for chinese).
I checked and hibernate-search compiles perfectly when we remove the
dependency to solr-analysis-extras and we add a dependency to
solr-core as all the analyzers used by Hibernate Search (including
most of the locale dependent analyzers/stemmers) are now in
lucene-analyzers. IIRC, they were moved from solr-analysis-extras to
lucene-analyzers during the 3.x release cycle.
Apart from the size of the jars, as a lot of new Java features
(Servlet 3 related features for instance) are based on classpath
scanning, removing this useless dependency looks worthwhile to me.
So the plan is to replace the solr-analysis-extras dependency with
solr-core. I can work on a pull request if it looks sane to everyone.
Thanks for your feedback.
--
Guillaume
_______________________________________________
hibernate-dev mailing list
hibernate-dev(a)lists.jboss.org
https://lists.jboss.org/mailman/listinfo/hibernate-dev
4:08 a.m.
Hi Hardy,
On Thu, Dec 13, 2012 at 10:49 AM, Hardy Ferentschik <hardy(a)hibernate.org> wrote:
I am fine with removing it, but maybe we need to sync the docs in
this case as well. It says now:
"all required Solr dependencies are now defined as dependencies of the artifact
org.hibernate:hibernate-search-analysers;
just add the following dependency"
IIRC, this sentence is here because Hibernate Search used to package
the analyzers extracted from Solr in a specific Jar. It was removed in
favor of a dependency to Solr jars when they were pushed to Maven not
so long ago.
IMHO, the important word in this sentence is the "required" in "all
*required* Solr dependencies": stempel, ICU and smartcn aren't
required at all: if you want these specific analyzers, you just have
to add a dependency to them, which isn't surprising.
It doesn't seem like a bad idea to be consistent with how Lucene have
rearranged their analyzers and to include all the lucene-analyzers +
the Solr machinery used to wrap them.
I think it's worth a note in the release notes though if we go this way.
I'll go create a JIRA as you asked.
Thanks.
--
Guillaume
4671
days inactive
4672
days old
2 comments
2 participants
participants (2)
-
Guillaume Smet -
Hardy Ferentschik