On Jun 27, 2012, at 12:42 PM, Sanne Grinovero wrote:
To reiterate what I've commented in the pull requests, I think
nice to have and properly fits the goal for a flawless integration
with the Hibernate ORM APIs.
I don't see a flaw in the integration as it is.
AFAIKS, all we gain with FullTextSharedSessionBuilder is that builder#openSession returns
a FullTextSession instead of a Session.
The cost for this are two more classes FullTextSharedSession and
FullTextSharedSessionBuilderDelegator which are basically just full
of noop operations. Easy to maintain maybe, but also easier to understand?
and it's already there.
That's really a weak argument. Are you implying just because something is written in
code it makes sense it needs to be kept around?
+1 to keep it.
-1 from me
On 27 June 2012 10:52, Hardy Ferentschik <hardy(a)hibernate.org> wrote:
> Sanne and I started a discussion around FullTextSharedSessionBuilder as part of
> and its corresponding pull request #308.
> The pull request exposes FullTextSharedSessionBuilder in the public FullTextSession
API. My question to begin with
> is why we need FullTextSharedSessionBuilder in the first place? It offers hardly (if
any at all) benefits. I suggest we even remove
> this interface rather than exposing it in FullTextSession.
>  https://hibernate.onjira.com/browse/HSEARCH-1169
>  https://github.com/hibernate/hibernate-search/pull/308
> hibernate-dev mailing list