11:44 a.m.
Hi all,
over the weekend I've added a custom field to all issues to store a
link to a pull request; this is in no way mandatory nor it affects any
work flow you might want to use, but hope you find it useful. It can't
support multiple links, so we should replace them if they are updated,
and backported issues with multiple pull requests don't fit in it.
In addition, but only applied to the Search project, I've added new
state and transitions for issues to move them into the state "pull
request sent".
An open issue has a button "Link to pull request" which will ask you
for the link, and change the issue state. I consider this useful when
evaluating the state of progress for a release. I've added a "reopen"
button as well to be used in those cases in which the pull request is
not satisfactory.
I think we could polish this even more; it seems possible for example
to link a commit hook to mark issues solved when a pull request is
merged, but I didn't go that far as I guess that requires some
discussion since it has some practical consequences.
Ideally I would love to hook into github's "send pull request" to move
into the "pull request sent" state and add the link automatically, but
from a reading of their docs it doesn't look like possible. Am I
wrong?
Let me know if you want it reverted, or have suggestions.
Sanne
12:06 p.m.
To be honest I have not sat down and thought about ideals of what
"integration" would look like here. Where did you see the "send pull
request docs"? This might be doable (assuming their API allows it) if
we agreed that the pull request branch is named using the JIRA issue
key. But that is not how everyone likes to name work branches iirc.
On Mon 05 Dec 2011 11:44:23 AM CST, Sanne Grinovero wrote:
Hi all,
over the weekend I've added a custom field to all issues to store a
link to a pull request; this is in no way mandatory nor it affects any
work flow you might want to use, but hope you find it useful. It can't
support multiple links, so we should replace them if they are updated,
and backported issues with multiple pull requests don't fit in it.
In addition, but only applied to the Search project, I've added new
state and transitions for issues to move them into the state "pull
request sent".
An open issue has a button "Link to pull request" which will ask you
for the link, and change the issue state. I consider this useful when
evaluating the state of progress for a release. I've added a "reopen"
button as well to be used in those cases in which the pull request is
not satisfactory.
I think we could polish this even more; it seems possible for example
to link a commit hook to mark issues solved when a pull request is
merged, but I didn't go that far as I guess that requires some
discussion since it has some practical consequences.
Ideally I would love to hook into github's "send pull request" to move
into the "pull request sent" state and add the link automatically, but
from a reading of their docs it doesn't look like possible. Am I
wrong?
Let me know if you want it reverted, or have suggestions.
Sanne
_______________________________________________
hibernate-dev mailing list
hibernate-dev(a)lists.jboss.org
https://lists.jboss.org/mailman/listinfo/hibernate-dev
--
steve(a)hibernate.org
http://hibernate.org
12:15 p.m.
On 5 December 2011 18:06, Steve Ebersole <steve(a)hibernate.org> wrote:
To be honest I have not sat down and thought about ideals of what
"integration" would look like here. Where did you see the "send pull
request docs"? This might be doable (assuming their API allows it) if we
agreed that the pull request branch is named using the JIRA issue key. But
that is not how everyone likes to name work branches iirc.
No I didn't find any docs about adding hooks at pull requests. only
post-commit hooks, but that's not what I was looking for so I guess
that's not possible unless Github wants to make that. Would anyone
else like the concept?
12:19 p.m.
On 5 December 2011 18:15, Sanne Grinovero <sanne(a)hibernate.org> wrote:
On 5 December 2011 18:06, Steve Ebersole <steve(a)hibernate.org>
wrote:
> To be honest I have not sat down and thought about ideals of what
> "integration" would look like here. Where did you see the "send pull
> request docs"? This might be doable (assuming their API allows it) if we
> agreed that the pull request branch is named using the JIRA issue key. But
> that is not how everyone likes to name work branches iirc.
No I didn't find any docs about adding hooks at pull requests. only
post-commit hooks, but that's not what I was looking for so I guess
that's not possible unless Github wants to make that. Would anyone
else like the concept?
Forgot one answer: I wouldn't refer to the branch name but look for
"HHH-nnnn" at the beginning of commit lines, as a pull request might
contain multiple fixes/tasks.
I'm using this in other scripts I use for code review in all Hibernate
and Infinispan (sub)modules and is almost always correct. At least, it
seems the way to go to me to enforce mentioning the JIRA key in the
commit comment so if a commit doesn't comply it's acceptable for the
integration to break.
4735
days inactive
4735
days old
3 comments
2 participants
participants (2)
-
Sanne Grinovero -
Steve Ebersole