We just discussed Hibernate 4.0 annotation scanning the other day and I wanted to add to the conversation (which was about using https://github.com/jbossas/jandex). As a workaround for https://issues.jboss.org/browse/JBAS-9141, I'll request a merge of the following change. This is about AS7 setting the "hibernate.ejb.resource_scanner" property to org.jboss.as.jpa.hibernate.HibernateAnnotationScanner (which implements the org.hibernate.ejb.packaging.Scanner interface). If we move away from supporting the current Scanner interface in Hibernate 4.0, we should discuss the impact on the AS7 scanner implementation. The HibernateAnnotationScanner class is in this commit (with other changes that go with it): https://github.com/scottmarlow/jboss-as/commit/5aaaa630f38d89d3bbbe832cac... Scott _______________________________________________ hibernate-dev mailing list hibernate-dev(a)lists.jboss.org https://lists.jboss.org/mailman/listinfo/hibernate-dev

In the Scanner implementation, I had to resort to loading classes to satisfy the current Scanner implementation. Perhaps in the next revison to the Scanner interface, we might add a method that doesn't return a Set of Class's but instead just returns the names: public Set<String<?>> getClassByNamesInJar(URL jartoScan, Set<Class<? extends Annotation>> annotationsToLookFor) Maybe we could do the same for getPackagesInJar (return a set of package names instead of Packages).

Another point to consider is that the org.hibernate.ejb.packaging.Scanner is not covering all Hibernate integration points, but only the AS JPA integration (as far as I currently understand it).

On 27 mars 2011, at 19:36, Scott Marlow wrote: > We just discussed Hibernate 4.0 annotation scanning the other day and I > wanted to add to the conversation (which was about using > https://github.com/jbossas/jandex). > > As a workaround for https://issues.jboss.org/browse/JBAS-9141, I'll > request a merge of the following change. This is about AS7 setting the > "hibernate.ejb.resource_scanner" property to > org.jboss.as.jpa.hibernate.HibernateAnnotationScanner (which implements > the org.hibernate.ejb.packaging.Scanner interface). > > If we move away from supporting the current Scanner interface in > Hibernate 4.0, we should discuss the impact on the AS7 scanner > implementation. Why do you want to get rid of this interface, it captures exactly what HEM needs. Has it changed in 4?

On 28 mars 2011, at 15:35, Scott Marlow wrote: > On 03/28/2011 09:04 AM, Emmanuel Bernard wrote: >> >> On 27 mars 2011, at 19:36, Scott Marlow wrote: >> >>> We just discussed Hibernate 4.0 annotation scanning the other day and I >>> wanted to add to the conversation (which was about using >>> https://github.com/jbossas/jandex). >>> >>> As a workaround for https://issues.jboss.org/browse/JBAS-9141, I'll >>> request a merge of the following change. This is about AS7 setting the >>> "hibernate.ejb.resource_scanner" property to >>> org.jboss.as.jpa.hibernate.HibernateAnnotationScanner (which implements >>> the org.hibernate.ejb.packaging.Scanner interface). >>> >>> If we move away from supporting the current Scanner interface in >>> Hibernate 4.0, we should discuss the impact on the AS7 scanner >>> implementation. >> >> Why do you want to get rid of this interface, it captures exactly what HEM needs. Has it changed in 4? > > I haven't heard anyone making a case to get rid of the Scanner interface. My suggestion is to consider optimizing the interface to not require classloading of the entities. Ah sorry I misunderstood you partially. What's the issue with a Scanner implementation loading classes? In a sense, HEM calling getName() is a non optimized code path that should be fixed eventually.