Those were used only for testing and as a runtime dependency:
testRuntime( libraries.oracle )
testRuntime( libraries.mssql )
So, I don't think there was any risk of distributing the drivers.
The only inconvenent was that every env should have those drivers
locally installed for the tests to run.
But the process of manually installing the drivers requires to accept
the license terms, so I don't think that was violating any licensing
terms.
The same is true for matrix testing, which uses the same drivers for
oracle and mssql.
On Sat, May 7, 2016 at 4:48 PM, Sanne Grinovero <sanne(a)hibernate.org> wrote:
Remember the licensing terms. You can not distribute those drivers.
On Sat, 7 May 2016, 14:30 Vlad Mihalcea, <mihalcea.vlad(a)gmail.com> wrote:
> Hi,
>
> I added those for testing, but now I realized that these could be missing
> from Jenkins.
> I'll add a Gradle condition to include the oracle/mssql dependencies only
> when we supply the -Pdb=oracle/mssql runtime property.
>
> Vlad
>
> On Fri, May 6, 2016 at 9:30 PM, Steve Ebersole <steve(a)hibernate.org>
> wrote:
>
> > On master I just removed the mssql and oracle JDBC drivers. They should
> > never have been added there.
> >
> >
> > On Tue, May 3, 2016 at 5:42 PM Gail Badner <gbadner(a)redhat.com> wrote:
> >
> > > The command I'm using is: ./gradlew clean test
> > >
> > > I think I remember someone mentioning this on hibernate-dev mailing
> list,
> > > but I can't seem to find it.
> > >
> > > Here is what I'm seeing:
> > > ...
> > > :documentation:processTestResources
> > > :documentation:testClasses
> > > :documentation:test
> > > :hibernate-c3p0:compileJava
> > > Starting AnimalSniffer checks using [java16-1.0.signature] against
> > > [sourceSets.main]
> > > :hibernate-c3p0:processResources
> > > :hibernate-c3p0:classes
> > > :hibernate-c3p0:compileTestJava
> > > :hibernate-c3p0:processTestResources
> > > :hibernate-c3p0:testClasses
> > > :hibernate-c3p0:test
> > > :hibernate-c3p0:buildDashboard
> > >
> > > FAILURE: Build failed with an exception.
> > >
> > > * What went wrong:
> > > Could not resolve all dependencies for configuration
> > > ':hibernate-c3p0:testRuntime'.
> > > > Could not find com.oracle.ojdbc:ojdbc7:12.1.0.2.0.
> > > Searched in the following locations:
> > >
> > >
> > >
> >
>
https://repo1.maven.org/maven2/com/oracle/ojdbc/ojdbc7/12.1.0.2.0/ojdbc7-...
> > >
> > >
> > >
> >
>
https://repo1.maven.org/maven2/com/oracle/ojdbc/ojdbc7/12.1.0.2.0/ojdbc7-...
> > >
> > >
> > >
> >
>
file:/home/gbadner/.m2/repository/com/oracle/ojdbc/ojdbc7/12.1.0.2.0/ojdbc7-12.1.0.2.0.pom
> > >
> > >
> > >
> >
>
file:/home/gbadner/.m2/repository/com/oracle/ojdbc/ojdbc7/12.1.0.2.0/ojdbc7-12.1.0.2.0.jar
> > >
> > >
> > >
> >
>
http://repository.jboss.org/nexus/content/groups/public/com/oracle/ojdbc/...
> > >
> > >
> > >
> >
>
http://repository.jboss.org/nexus/content/groups/public/com/oracle/ojdbc/...
> > >
> > >
> > >
> >
>
http://snapshots.jboss.org/maven2/com/oracle/ojdbc/ojdbc7/12.1.0.2.0/ojdb...
> > >
> > >
> > >
> >
>
http://snapshots.jboss.org/maven2/com/oracle/ojdbc/ojdbc7/12.1.0.2.0/ojdb...
> > > Required by:
> > > org.hibernate:hibernate-c3p0:5.1.1-SNAPSHOT
> > > > Could not find com.microsoft.sqlserver:sqljdbc4:4.0.
> > > Searched in the following locations:
> > >
> > >
> > >
> >
>
https://repo1.maven.org/maven2/com/microsoft/sqlserver/sqljdbc4/4.0/sqljd...
> > >
> > >
> > >
> >
>
https://repo1.maven.org/maven2/com/microsoft/sqlserver/sqljdbc4/4.0/sqljd...
> > >
> > >
> > >
> >
>
file:/home/gbadner/.m2/repository/com/microsoft/sqlserver/sqljdbc4/4.0/sqljdbc4-4.0.pom
> > >
> > >
> > >
> >
>
file:/home/gbadner/.m2/repository/com/microsoft/sqlserver/sqljdbc4/4.0/sqljdbc4-4.0.jar
> > >
> > >
> > >
> >
>
http://repository.jboss.org/nexus/content/groups/public/com/microsoft/sql...
> > >
> > >
> > >
> >
>
http://repository.jboss.org/nexus/content/groups/public/com/microsoft/sql...
> > >
> > >
> > >
> >
>
http://snapshots.jboss.org/maven2/com/microsoft/sqlserver/sqljdbc4/4.0/sq...
> > >
> > >
> > >
> >
>
http://snapshots.jboss.org/maven2/com/microsoft/sqlserver/sqljdbc4/4.0/sq...
> > > Required by:
> > > org.hibernate:hibernate-c3p0:5.1.1-SNAPSHOT
> > >
> > > * Try:
> > > Run with --stacktrace option to get the stack trace. Run with --info
> or
> > > --debug option to get more log output.
> > >
> > > BUILD FAILED
> > > _______________________________________________
> > > hibernate-dev mailing list
> > > hibernate-dev(a)lists.jboss.org
> > >
https://lists.jboss.org/mailman/listinfo/hibernate-dev
> > >
> > _______________________________________________
> > hibernate-dev mailing list
> > hibernate-dev(a)lists.jboss.org
> >
https://lists.jboss.org/mailman/listinfo/hibernate-dev
> >
> _______________________________________________
> hibernate-dev mailing list
> hibernate-dev(a)lists.jboss.org
>
https://lists.jboss.org/mailman/listinfo/hibernate-dev
>