6:22 a.m.
Hello All,
What's the status of BVAL-90 (Stop using a properties file for built-in
constraints and move to a list in Java)? I'm thinking of implementing it
using a static map that's get filled on class loading. I wanted to have a
clean implementation using reflection, but can't find a clean solution to
get the classes within a package. I'm also thinking of using an enum instead
of a map. What do you think?
Regards,
Alaa Nassef
6:28 a.m.
I don't see the need for reflection. Just add them to the map, period.
You might want to store the map in the ValidatorFactory instead of a
static, not sure.
On Feb 2, 2009, at 12:22, Alaa Mohsen wrote:
Hello All,
What's the status of BVAL-90 (Stop using a properties file for
built-in constraints and move to a list in Java)? I'm thinking of
implementing it using a static map that's get filled on class
loading. I wanted to have a clean implementation using reflection,
but can't find a clean solution to get the classes within a package.
I'm also thinking of using an enum instead of a map. What do you
think?
Regards,
Alaa Nassef
_______________________________________________
hibernate-dev mailing list
hibernate-dev(a)lists.jboss.org
https://lists.jboss.org/mailman/listinfo/hibernate-dev
6:31 a.m.
Actually I am sure now, you have to store the list in a Map at the
ValidatorFactory level because the list of validators can be
overridden in XML.
On Feb 2, 2009, at 12:28, Emmanuel Bernard wrote:
I don't see the need for reflection. Just add them to the map,
period.
You might want to store the map in the ValidatorFactory instead of a
static, not sure.
On Feb 2, 2009, at 12:22, Alaa Mohsen wrote:
> Hello All,
> What's the status of BVAL-90 (Stop using a properties file for
> built-in constraints and move to a list in Java)? I'm thinking of
> implementing it using a static map that's get filled on class
> loading. I wanted to have a clean implementation using reflection,
> but can't find a clean solution to get the classes within a
> package. I'm also thinking of using an enum instead of a map. What
> do you think?
>
> Regards,
> Alaa Nassef
> _______________________________________________
> hibernate-dev mailing list
> hibernate-dev(a)lists.jboss.org
> https://lists.jboss.org/mailman/listinfo/hibernate-dev
_______________________________________________
hibernate-dev mailing list
hibernate-dev(a)lists.jboss.org
https://lists.jboss.org/mailman/listinfo/hibernate-dev
7:01 a.m.
OK
On Mon, Feb 2, 2009 at 1:31 PM, Emmanuel Bernard <emmanuel(a)hibernate.org>wrote:
Actually I am sure now, you have to store the list in a Map at the
ValidatorFactory level because the list of validators can be overridden in
XML.
On Feb 2, 2009, at 12:28, Emmanuel Bernard wrote:
I don't see the need for reflection. Just add them to the map, period.
>
> You might want to store the map in the ValidatorFactory instead of a
> static, not sure.
>
> On Feb 2, 2009, at 12:22, Alaa Mohsen wrote:
>
> Hello All,
>> What's the status of BVAL-90 (Stop using a properties file for
>> built-in constraints and move to a list in Java)? I'm thinking of
>> implementing it using a static map that's get filled on class loading. I
>> wanted to have a clean implementation using reflection, but can't find a
>> clean solution to get the classes within a package. I'm also thinking of
>> using an enum instead of a map. What do you think?
>>
>> Regards,
>> Alaa Nassef
>> _______________________________________________
>> hibernate-dev mailing list
>> hibernate-dev(a)lists.jboss.org
>> https://lists.jboss.org/mailman/listinfo/hibernate-dev
>>
>
> _______________________________________________
> hibernate-dev mailing list
> hibernate-dev(a)lists.jboss.org
> https://lists.jboss.org/mailman/listinfo/hibernate-dev
>
8:32 a.m.
I have a question. When you said to add the map at the ValidatorFactory
level, did you mean to add it to ValidatorFactoryImpl? As I can see, getting
the validators of built in constraints happens in ConstraintDescriptorImpl,
which is used only by the BeanMetaDataImpl. Do I put the map in
ConstraintDescriptorImpl, or shall I put it somewhere else?
Regards,
Alaa Nassef
On Mon, Feb 2, 2009 at 1:31 PM, Emmanuel Bernard <emmanuel(a)hibernate.org>wrote:
Actually I am sure now, you have to store the list in a Map at the
ValidatorFactory level because the list of validators can be overridden in
XML.
On Feb 2, 2009, at 12:28, Emmanuel Bernard wrote:
I don't see the need for reflection. Just add them to the map, period.
>
> You might want to store the map in the ValidatorFactory instead of a
> static, not sure.
>
> On Feb 2, 2009, at 12:22, Alaa Mohsen wrote:
>
> Hello All,
>> What's the status of BVAL-90 (Stop using a properties file for
>> built-in constraints and move to a list in Java)? I'm thinking of
>> implementing it using a static map that's get filled on class loading. I
>> wanted to have a clean implementation using reflection, but can't find a
>> clean solution to get the classes within a package. I'm also thinking of
>> using an enum instead of a map. What do you think?
>>
>> Regards,
>> Alaa Nassef
>> _______________________________________________
>> hibernate-dev mailing list
>> hibernate-dev(a)lists.jboss.org
>> https://lists.jboss.org/mailman/listinfo/hibernate-dev
>>
>
> _______________________________________________
> hibernate-dev mailing list
> hibernate-dev(a)lists.jboss.org
> https://lists.jboss.org/mailman/listinfo/hibernate-dev
>
8:50 a.m.
Hi,
I am actually implementing this as we speak. I need it in order to
implement
BVAL-99. And yes, it ends up to be a static map.
--Hardy
What's the status of BVAL-90 (Stop using a properties file
for
built-in
constraints and move to a list in Java)? I'm thinking of implementing it
using a static map that's get filled on class loading. I wanted to have a
clean implementation using reflection, but can't find a clean solution to
get the classes within a package. I'm also thinking of using an enum
instead
of a map. What do you think?
Regards,
Alaa Nassef
9:05 a.m.
OK. So no need for me to implement it then. Got a couple of meetings, then
I'll look at what I can do in the RI
Regards,
Alaa Nassef
On Mon, Feb 2, 2009 at 3:50 PM, Hardy Ferentschik
<hibernate(a)ferentschik.de>wrote:
Hi,
I am actually implementing this as we speak. I need it in order to
implement
BVAL-99. And yes, it ends up to be a static map.
--Hardy
What's the status of BVAL-90 (Stop using a properties file for
> built-in
> constraints and move to a list in Java)? I'm thinking of implementing it
> using a static map that's get filled on class loading. I wanted to have a
> clean implementation using reflection, but can't find a clean solution to
> get the classes within a package. I'm also thinking of using an enum
> instead
> of a map. What do you think?
>
> Regards,
> Alaa Nassef
>
9:13 a.m.
Great.
Just to make sure that we don't work on the same things - could you
contact the asignee in case you want to work
on on an already assigned task? In many cases the person is more than
happy to drop a task, but just has to know ;-)
In case you start working on an unassinged task make sure to assign it to
yourself so that the others know
that you are working on it.
--Hardy
On Mon, 02 Feb 2009 15:05:11 +0100, Alaa Mohsen <alaa.mohsen(a)egyptdc.com>
wrote:
OK. So no need for me to implement it then. Got a couple of meetings,
then
I'll look at what I can do in the RI
5560
days inactive
5560
days old
7 comments
3 participants
participants (3)
-
Alaa Mohsen -
Emmanuel Bernard -
Hardy Ferentschik