9:02 a.m.
Hi all,
It's been a long time since the last release of JPA modelgen and we
fixed a couple of annoying bugs, namely:
https://hibernate.atlassian.net/browse/METAGEN-81
https://hibernate.atlassian.net/browse/METAGEN-82
And this one was a work in progress a long time ago and I should
probably go back to work on it to provide some feedback to Hardy:
https://hibernate.atlassian.net/browse/METAGEN-85
Is there any plan for a new release and if so we should probably
define which tickets we want to resolve before the release?
Personnally, I think even publishing the current code as is without
fixing anything more would be a good idea.
Thanks for your feedback.
--
Guillaume
10:10 a.m.
On 5 Jan 2013, at 4:02 PM, Guillaume Smet <guillaume.smet(a)gmail.com> wrote:
It's been a long time since the last release of JPA modelgen and
we
fixed a couple of annoying bugs, namely:
https://hibernate.atlassian.net/browse/METAGEN-81
https://hibernate.atlassian.net/browse/METAGEN-82
+1 We really need to get a release out. As you say we have a couple of things which are
actually resolved
and just need a release, but I also think at the very least we need to look at
METAGEN-92.
Basically we need to get the tool JPA 2.1 compliant.
And this one was a work in progress a long time ago and I should
probably go back to work on it to provide some feedback to Hardy:
https://hibernate.atlassian.net/browse/METAGEN-85
Right, I still have not been able to reproduce this one (but it has been quite some time
since I tried)
Is there any plan for a new release and if so we should probably
define which tickets we want to resolve before the release?
I have been putting up the release for too long now. I would love to get a release out by
end of the
week, but I won't promise it.
--Hardy
10:23 a.m.
On Mon, Aug 5, 2013 at 5:10 PM, Hardy Ferentschik <hardy(a)hibernate.org> wrote:
> And this one was a work in progress a long time ago and I should
> probably go back to work on it to provide some feedback to Hardy:
> https://hibernate.atlassian.net/browse/METAGEN-85
Right, I still have not been able to reproduce this one (but it has been quite some time
since I tried)
OK. I'll take another look at this one before the end of the week to
see if we can get it fixed.
--
Guillaume
10:31 a.m.
I think I could help with doing with the release, if you, Hardy, don't get
to it (assuming it's a common Maven release process as e.g. in HV).
Btw. there seems to be an issue with one failing test on master as per the
CI job: http://ci.hibernate.org/job/hibernate-metamodelgen-master/ (I just
triggered it).
--Gunnar
2013/8/5 Guillaume Smet <guillaume.smet(a)gmail.com>
On Mon, Aug 5, 2013 at 5:10 PM, Hardy Ferentschik
<hardy(a)hibernate.org>
wrote:
>> And this one was a work in progress a long time ago and I should
>> probably go back to work on it to provide some feedback to Hardy:
>> https://hibernate.atlassian.net/browse/METAGEN-85
>
> Right, I still have not been able to reproduce this one (but it has been
quite some time since I tried)
OK. I'll take another look at this one before the end of the week to
see if we can get it fixed.
--
Guillaume
_______________________________________________
hibernate-dev mailing list
hibernate-dev(a)lists.jboss.org
https://lists.jboss.org/mailman/listinfo/hibernate-dev
11:47 a.m.
On 5 Jan 2013, at 5:31 PM, Gunnar Morling <gunnar(a)hibernate.org> wrote:
I think I could help with doing with the release, if you, Hardy,
don't get to it (assuming it's a common Maven release process as e.g. in HV).
Awesome. Let's sync tomorrow.
Btw. there seems to be an issue with one failing test on master as
per the CI job: http://ci.hibernate.org/job/hibernate-metamodelgen-master/ (I just
triggered it).
I've never configured this job. I'll take a look.
--Hardy
11:09 a.m.
Hi,
On Mon, Aug 5, 2013 at 5:10 PM, Hardy Ferentschik <hardy(a)hibernate.org> wrote:
+1 We really need to get a release out. As you say we have a couple
of things which are actually resolved
and just need a release, but I also think at the very least we need to look at
METAGEN-92.
Basically we need to get the tool JPA 2.1 compliant.
I took a look at the current 1.3.0 roadmap:
https://hibernate.atlassian.net/browse/METAGEN-89?jql=project%20%3D%20MET...
.
I think we should move to .Next:
- METAGEN-72 - Generate attributes for @Transient columns : it might
be nice to have but it's definitely not something required (there are
a lot of other binding generators out there like bindgen)
- METAGEN-46 - Add ability to specify a desired package : definitely accessory
- METAGEN-89 - generated model misses <T> : if really wanted, I think
it probably requires more work than reasonable for 1.3.0
--
Guillaume
11:38 a.m.
On 6 Jan 2013, at 6:09 PM, Guillaume Smet <guillaume.smet(a)gmail.com> wrote:
I took a look at the current 1.3.0 roadmap:
https://hibernate.atlassian.net/browse/METAGEN-89?jql=project%20%3D%20MET...
Awesome. I moved some issues into 1.3.0 knowing they won't make it, especially since
some of them
are questionable and I wanted to discuss them first. See below
I think we should move to .Next:
- METAGEN-72 - Generate attributes for @Transient columns : it might
be nice to have but it's definitely not something required (there are
a lot of other binding generators out there like bindgen)
I am not even sure if we should do this at all. Should the static metamodel really contain
transient properties?
The meta model is primarily there to write type safe criteria queries and you cannot
target transient fields there.
So I am actually tempted to reject this one.
- METAGEN-46 - Add ability to specify a desired package : definitely
accessory
Right. Personally I don't see even a point in this. Happy to move this one
- METAGEN-89 - generated model misses <T> : if really wanted, I
think
it probably requires more work than reasonable for 1.3.0
This is another one, I am not even sure about whether it would be correct. I need to think
more about this one.
If you see any value in iet me know :-)
Personally I started looking at METAGEN-92. It proves more complicated than expected,
since the xsd namespace
has changed between JAP 2.0 and 2.1. We will need to add some XML magic there.
Gunnar is looking at the OS based test failures. Basically the code was dependent on the
order classes got processed
which could vary depending on the OS.
If you want to help out feel free to look at remaining issues, for example METAGEN-86
(even so we need to first assess
whether we can fix that for this release).
Thanks for your help.
--Hardy
12:08 p.m.
On Tue, Aug 6, 2013 at 6:38 PM, Hardy Ferentschik <hardy(a)hibernate.org> wrote:
> I think we should move to .Next:
> - METAGEN-72 - Generate attributes for @Transient columns : it might
> be nice to have but it's definitely not something required (there are
> a lot of other binding generators out there like bindgen)
I am not even sure if we should do this at all. Should the static metamodel really
contain transient properties?
The meta model is primarily there to write type safe criteria queries and you cannot
target transient fields there.
So I am actually tempted to reject this one.
+1
> - METAGEN-46 - Add ability to specify a desired package :
definitely accessory
Right. Personally I don't see even a point in this. Happy to move this one
+1
> - METAGEN-89 - generated model misses <T> : if really
wanted, I think
> it probably requires more work than reasonable for 1.3.0
This is another one, I am not even sure about whether it would be correct. I need to
think more about this one.
If you see any value in iet me know :-)
Not really but I'm not a heavy user of the metamodel. We mostly use
QueryDSL to write our queries now.
If you want to help out feel free to look at remaining issues, for
example METAGEN-86 (even so we need to first assess
whether we can fix that for this release).
I took a look at them this afternoon (thus my previous email) and I
don't think I'm a good choice to fix the remaining ones as they are
really on parts of jpamodelgen/Hibernate I don't use or know. I want
to work on some Hibernate Search stuff in the next few days so I don't
think I'll be able to help more on this front.
I updated the Maven versions in this pull request this afternoon as I
thought it might be useful:
https://github.com/hibernate/hibernate-metamodelgen/pull/7 .
HTH
--
Guillaume
4212
days inactive
4213
days old
7 comments
3 participants
participants (3)
-
Guillaume Smet -
Gunnar Morling -
Hardy Ferentschik