Hi Emmanuel, maybe you could spare some time to do some planning on Search? There are so many needed fixes here :D Also my current task is in wait for feedback. From the forums it appears that many have already upgraded to Lucene 2.9 wo checking compatibility - just assuming it would work - and are waiting or having trouble. And it's quite likely people are going to use Core 3.5 now, having Search unreleased is annoying. below a quick overview, I actually believe that you could cut a new beta in short time: Urgently needed stuff ============================ HSEARCH-484 Building documentation fails Unassigned HSEARCH-476 Work queue contains the same operation multiple times and some add/delete operations have null primary keys Emmanuel Bernard * you probably fixed this already, to give it another look; maybe I can add some additional tests in next days HSEARCH-421 Exceptions happening in backend are unnoticed Unassigned * Amin is working on it, he should be close HSEARCH-425 Reimplement support for compressed fields (support removed in Lucene3) Sanne Grinovero * I'm waiting for feedback, we need to talk about this - I'm also open to remove it HSEARCH-428 Update the Getting Started section of the documentation Hardy Ferentschik HSEARCH-483 update readme.txt Emmanuel Bernard Other things which could be moved on ============================ Refactoring can wait, and others are related to bugs we did postpone many other times as we can't reproduce, or are actually fixed already but need to be checked; stress tests would be nice, but I'm not going to make them soon : HSEARCH-346 Setup hudson job testing Search against several databases Juraci Paixao Krohling HSEARCH-318 Extend IndexWriterSetting to take additional constructor argument Unassigned HSEARCH-467 publish Maven artifacts containing the testsuite Hardy Ferentschik HSEARCH-468 Refactor build to have a module setup Hardy Ferentschik HSEARCH-444 Search fails to start when core uses XML mappings making use of entity-name attribute Emmanuel Bernard HSEARCH-393 unit test of the NotSharedReaderPerfTest hangs on with some database Emmanuel Bernard HSEARCH-320 Hibernate Search conflicts with Spring's class path scanning Hardy Ferentschik HSEARCH-228 Write a reliability test under stress Hardy Ferentschik HSEARCH-314 ThreadLocal in ContextHolder causes memory leak when deployed in a web container Unassigned HSEARCH-333 Remove or improve log warning in DocumentBuilderContainedEntity.checkDocumentId Hardy Ferentschik HSEARCH-371 Refactor DocumentBuilder and introduce abstract base class Hardy Ferentschik Cheers, Sanne

I've reviewed the list of bugs you've sent as well as all the bugs assigned to 3.2 I think the right thing to do is: - cut a 3.2 CR1 based on what is labeled 3.2 beta2 - move 3.2 beta3 and co to 3.3 That would mean delay the use of Lucene 3 to HSearch 3.3. I think most issues are in control for CR1, the big one is Amin's work on exceptions. Sanne, let's try and chat by IM, I have a couple of questions on beta3's bugs related to what you've done. Aside from that, let's try and target CR1 for end of next week (I'm likely busy till Wed and free afterwards). Amin do you think you can get HSEARCH0-421 done by that time? Emmanuel On 1 avr. 2010, at 19:51, Emmanuel Bernard wrote: > IM me tomorrow. > > On 1 avr. 2010, at 19:46, Sanne Grinovero wrote: > >> Hi Emmanuel, >> maybe you could spare some time to do some planning on Search? There >> are so many needed fixes here :D >> Also my current task is in wait for feedback. >> >> From the forums it appears that many have already upgraded to Lucene >> 2.9 wo checking compatibility - just assuming it would work - and are >> waiting or having trouble. >> And it's quite likely people are going to use Core 3.5 now, having >> Search unreleased is annoying. >> >> below a quick overview, I actually believe that you could cut a new >> beta in short time: >> >> Urgently needed stuff >> ============================ >> >> HSEARCH-484 Building documentation fails Unassigned >> >> HSEARCH-476 Work queue contains the same operation multiple times and >> some add/delete operations have null primary keys Emmanuel Bernard >> * you probably fixed this already, to give it another look; maybe I >> can add some additional tests in next days >> >> HSEARCH-421 Exceptions happening in backend are unnoticed Unassigned >> * Amin is working on it, he should be close >> >> HSEARCH-425 Reimplement support for compressed fields (support >> removed in Lucene3) Sanne Grinovero >> * I'm waiting for feedback, we need to talk about this - I'm also >> open to remove it >> >> HSEARCH-428 Update the Getting Started section of the documentation >> Hardy Ferentschik >> HSEARCH-483 update readme.txt Emmanuel Bernard >> >> Other things which could be moved on >> ============================ >> Refactoring can wait, and others are related to bugs we did postpone >> many other times as we can't reproduce, or are actually fixed already >> but need to be checked; >> stress tests would be nice, but I'm not going to make them soon : >> >> HSEARCH-346 Setup hudson job testing Search against several databases >> Juraci Paixao Krohling >> HSEARCH-318 Extend IndexWriterSetting to take additional constructor >> argument Unassigned >> HSEARCH-467 publish Maven artifacts containing the testsuite Hardy >> Ferentschik >> HSEARCH-468 Refactor build to have a module setup Hardy Ferentschik >> HSEARCH-444 Search fails to start when core uses XML mappings making >> use of entity-name attribute Emmanuel Bernard >> HSEARCH-393 unit test of the NotSharedReaderPerfTest hangs on with >> some database Emmanuel Bernard >> HSEARCH-320 Hibernate Search conflicts with Spring's class path >> scanning Hardy Ferentschik >> HSEARCH-228 Write a reliability test under stress Hardy Ferentschik >> HSEARCH-314 ThreadLocal in ContextHolder causes memory leak when >> deployed in a web container Unassigned >> HSEARCH-333 Remove or improve log warning in >> DocumentBuilderContainedEntity.checkDocumentId Hardy Ferentschik >> HSEARCH-371 Refactor DocumentBuilder and introduce abstract base >> class Hardy Ferentschik >> >> Cheers, >> Sanne > > _______________________________________________ > hibernate-dev mailing list > hibernate-dev(a)lists.jboss.org > https://lists.jboss.org/mailman/listinfo/hibernate-dev

Ah cool, we are getting there :) Looking at it quickly, can you use tabs, not space for indentation? That's our coding conventions. One open question I had last time was one error handler for sync and async, vs one for sync and one for async. What was decided? What was the reasoning?

Emmanuel, I'm applying the latest patch from Amin, the patch is fine but thinking more on the async/sync I realized we forgot the other implementation, so I added an ErrorHandler implementation which will rethrow the exception up to the thread which committed the transaction, and another test for this. Could you check it, especially the configuration option key and names for the two error handlers? To close the issue, I'll wait for Amin to write a little documentation patch. Sanne 2010/4/3 Sanne Grinovero <sanne.grinovero(a)gmail.com&gt;: > 2010/4/3 Emmanuel Bernard <emmanuel(a)hibernate.org&gt;: >> Ah cool, we are getting there :) >> Looking at it quickly, can you use tabs, not space for indentation? That's our coding conventions. >> >> One open question I had last time was one error handler for sync and async, vs one for sync and one for async. What was decided? What was the reasoning? >> > > Initially we thought that that would be needed, but doesn't appear to > be the case. Latest Amin's work did remove the duality, sync and async > are using the same methods now. >

Ah right, I nearly forgot that - overconfidence from my incomplete test. Shall I completely remove the implementation or just comment on it and remove it from being a default? Sanne 2010/4/5 Emmanuel Bernard <emmanuel(a)hibernate.org&gt;: > The problem with the exception impl is that it does not work today because Core's Synch does swallow exceptions. See "Exceptions thrown in a tx synchronization are eaten". > I am not sure we should put it in until this is resolved. > > On 4 avr. 2010, at 18:34, Sanne Grinovero wrote: > >> Emmanuel, >> I'm applying the latest patch from Amin, the patch is fine but >> thinking more on the async/sync I realized we forgot the other >> implementation, so I added an ErrorHandler implementation which will >> rethrow the exception up to the thread which committed the >> transaction, and another test for this. >> >> Could you check it, especially the configuration option key and names >> for the two error handlers? >> >> To close the issue, I'll wait for Amin to write a little documentation patch. >> >> Sanne >> >> 2010/4/3 Sanne Grinovero <sanne.grinovero(a)gmail.com&gt;: >>> 2010/4/3 Emmanuel Bernard <emmanuel(a)hibernate.org&gt;: >>>> Ah cool, we are getting there :) >>>> Looking at it quickly, can you use tabs, not space for indentation? That's our coding conventions. >>>> >>>> One open question I had last time was one error handler for sync and async, vs one for sync and one for async. What was decided? What was the reasoning? >>>> >>> >>> Initially we thought that that would be needed, but doesn't appear to >>> be the case. Latest Amin's work did remove the duality, sync and async >>> are using the same methods now. >>> > >

Hi I'll create a patch for the documentation to minor this. The current documentation patch talks about the rethrow. Cheers Amin Sent from my iPhone On 6 Apr 2010, at 09:31, Emmanuel Bernard <emmanuel(a)hibernate.org&gt; wrote: > Let's remove it for now. > Re-throw should never be the default even when we have that fixed: > database first, index optional is the best default. > > On 5 avr. 2010, at 17:17, Sanne Grinovero wrote: > >> Ah right, I nearly forgot that - overconfidence from my incomplete test. >> Shall I completely remove the implementation or just comment on it and >> remove it from being a default? >> >> Sanne >> >> 2010/4/5 Emmanuel Bernard <emmanuel(a)hibernate.org&gt;: >>> >>> The problem with the exception impl is that it does not work today >>> because Core's Synch does swallow exceptions. See "Exceptions thrown in a tx >>> synchronization are eaten". >>> I am not sure we should put it in until this is resolved. >>> >>> On 4 avr. 2010, at 18:34, Sanne Grinovero wrote: >>> >>>> Emmanuel, >>>> I'm applying the latest patch from Amin, the patch is fine but >>>> thinking more on the async/sync I realized we forgot the other >>>> implementation, so I added an ErrorHandler implementation which will >>>> rethrow the exception up to the thread which committed the >>>> transaction, and another test for this. >>>> >>>> Could you check it, especially the configuration option key and names >>>> for the two error handlers? >>>> >>>> To close the issue, I'll wait for Amin to write a little documentation >>>> patch. >>>> >>>> Sanne >>>> >>>> 2010/4/3 Sanne Grinovero <sanne.grinovero(a)gmail.com&gt;: >>>>> >>>>> 2010/4/3 Emmanuel Bernard <emmanuel(a)hibernate.org&gt;: >>>>>> >>>>>> Ah cool, we are getting there :) >>>>>> Looking at it quickly, can you use tabs, not space for indentation? >>>>>> That's our coding conventions. >>>>>> >>>>>> One open question I had last time was one error handler for sync and >>>>>> async, vs one for sync and one for async. What was decided? What was the >>>>>> reasoning? >>>>>> >>>>> >>>>> Initially we thought that that would be needed, but doesn't appear to >>>>> be the case. Latest Amin's work did remove the duality, sync and async >>>>> are using the same methods now. >>>>> >>> >>> >

Hi Amin, I updated your patch and attached it to HSEARCH-421, hope you've seen it and are able to look into it, especially the PerDPQueueProcessor needs some more thoughts. Also I was going to ask you to prepare a test as I couldn't really figure it all out by reading the code, but as it's quite tricky to test this and because I wasn't sure it would be possible I wrote it myself to find out. The test is almost complete but some lines are commented out, as exact implementation depends on how you're going to implement the changes needed in PerDPQueueProcessor. Cheers, Sanne 2010/4/2 Amin Mohammed-Coleman <aminmc(a)gmail.com&gt;: > Hi > > I attached a patch for HSearch 421 yesterday which Sanne is reviewing (there 3 changes that I believe he wanted to make). If Sanne is happy with the patch I can work on the documentation side of things tomorrow and hopefully get something on Sunday/Monday. > > > Thanks > Amin > > > > On 2 Apr 2010, at 15:35, Emmanuel Bernard wrote: > >> I've reviewed the list of bugs you've sent as well as all the bugs assigned to 3.2 >> >> I think the right thing to do is: >> - cut a 3.2 CR1 based on what is labeled 3.2 beta2 >> - move 3.2 beta3 and co to 3.3 >> >> That would mean delay the use of Lucene 3 to HSearch 3.3. I think most issues are in control for CR1, the big one is Amin's work on exceptions. >> >> Sanne, let's try and chat by IM, I have a couple of questions on beta3's bugs related to what you've done. Aside from that, let's try and target CR1 for end of next week (I'm likely busy till Wed and free afterwards). Amin do you think you can get HSEARCH0-421 done by that time? >> >> Emmanuel >> >> On 1 avr. 2010, at 19:51, Emmanuel Bernard wrote: >> >>> IM me tomorrow. >>> >>> On 1 avr. 2010, at 19:46, Sanne Grinovero wrote: >>> >>>> Hi Emmanuel, >>>> maybe you could spare some time to do some planning on Search? There >>>> are so many needed fixes here :D >>>> Also my current task is in wait for feedback. >>>> >>>> From the forums it appears that many have already upgraded to Lucene >>>> 2.9 wo checking compatibility - just assuming it would work - and are >>>> waiting or having trouble. >>>> And it's quite likely people are going to use Core 3.5 now, having >>>> Search unreleased is annoying. >>>> >>>> below a quick overview, I actually believe that you could cut a new >>>> beta in short time: >>>> >>>> Urgently needed stuff >>>> ============================ >>>> >>>> HSEARCH-484 Building documentation fails Unassigned >>>> >>>> HSEARCH-476 Work queue contains the same operation multiple times and >>>> some add/delete operations have null primary keys Emmanuel Bernard >>>> * you probably fixed this already, to give it another look; maybe I >>>> can add some additional tests in next days >>>> >>>> HSEARCH-421 Exceptions happening in backend are unnoticed Unassigned >>>> * Amin is working on it, he should be close >>>> >>>> HSEARCH-425 Reimplement support for compressed fields (support >>>> removed in Lucene3) Sanne Grinovero >>>> * I'm waiting for feedback, we need to talk about this - I'm also >>>> open to remove it >>>> >>>> HSEARCH-428 Update the Getting Started section of the documentation >>>> Hardy Ferentschik >>>> HSEARCH-483 update readme.txt Emmanuel Bernard >>>> >>>> Other things which could be moved on >>>> ============================ >>>> Refactoring can wait, and others are related to bugs we did postpone >>>> many other times as we can't reproduce, or are actually fixed already >>>> but need to be checked; >>>> stress tests would be nice, but I'm not going to make them soon : >>>> >>>> HSEARCH-346 Setup hudson job testing Search against several databases >>>> Juraci Paixao Krohling >>>> HSEARCH-318 Extend IndexWriterSetting to take additional constructor >>>> argument Unassigned >>>> HSEARCH-467 publish Maven artifacts containing the testsuite Hardy >>>> Ferentschik >>>> HSEARCH-468 Refactor build to have a module setup Hardy Ferentschik >>>> HSEARCH-444 Search fails to start when core uses XML mappings making >>>> use of entity-name attribute Emmanuel Bernard >>>> HSEARCH-393 unit test of the NotSharedReaderPerfTest hangs on with >>>> some database Emmanuel Bernard >>>> HSEARCH-320 Hibernate Search conflicts with Spring's class path >>>> scanning Hardy Ferentschik >>>> HSEARCH-228 Write a reliability test under stress Hardy Ferentschik >>>> HSEARCH-314 ThreadLocal in ContextHolder causes memory leak when >>>> deployed in a web container Unassigned >>>> HSEARCH-333 Remove or improve log warning in >>>> DocumentBuilderContainedEntity.checkDocumentId Hardy Ferentschik >>>> HSEARCH-371 Refactor DocumentBuilder and introduce abstract base >>>> class Hardy Ferentschik >>>> >>>> Cheers, >>>> Sanne >>> >>> _______________________________________________ >>> hibernate-dev mailing list >>> hibernate-dev(a)lists.jboss.org >>> https://lists.jboss.org/mailman/listinfo/hibernate-dev >> > >