March 2010 - jboss-dev-forums - Jboss List Archives

[JBoss Microcontainer Development] - Making JavassistTypeInfo serializable

by Kabir Khan

Kabir Khan [http://community.jboss.org/people/kabir.khan%40jboss.com] created the discussion "Making JavassistTypeInfo serializable" To view the discussion, visit: http://community.jboss.org/message/534718#534718 -------------------------------------------------------------- Looking at https://jira.jboss.org/jira/browse/JBREFLECT-16 https://jira.jboss.org/jira/browse/JBREFLECT-16 I wanted to do the same as I did to make the reflect flavour properly serializable, which was simply to add this to ClassInfo, as mentioned here http://community.jboss.org/message/534270#534270: http://community.jboss.org/message/534270#534270: protected Object writeReplace() { return new MarshalledClassInfo(getType()); } public static class MarshalledClassInfo implements Serializable { private static final long serialVersionUID = 1L; Class<?> type; public MarshalledClassInfo(Class<?> type) { this.type = type; } protected Object readResolve() { TypeInfoFactory tif = new IntrospectionTypeInfoFactory(); return tif.getTypeInfo(type); } } If I do the same for JavassistTypeInfo, then that will load the class. Is that a bad thing? Probably... The alternative for this simple implementation to work is to save the name and the classloader, and classloaders are not serializable. Or am I missing something? When deserializing a class should that happen in the same classloader (or one with access to similar classes if serialized out of the vm) as the one that serialized it in the first place? If the answer is yes, then I can go forward with this. -------------------------------------------------------------- Reply to this message by going to Community [http://community.jboss.org/message/534718#534718] Start a new discussion in JBoss Microcontainer Development at Community [http://community.jboss.org/choose-container!input.jspa?contentType=1&cont...]

14 years, 9 months

1
0
0 / 0

Re: [jboss-dev-forums] [JBoss Microcontainer Development] - Issues using Javassist TypeInfoFactory in other projects

by Kabir Khan

Kabir Khan [http://community.jboss.org/people/kabir.khan%40jboss.com] replied to the discussion "Issues using Javassist TypeInfoFactory in other projects" To view the discussion, visit: http://community.jboss.org/message/534713#534713 -------------------------------------------------------------- https://jira.jboss.org/jira/browse/JBREFLECT-112 https://jira.jboss.org/jira/browse/JBREFLECT-112 for the proxy stuff https://jira.jboss.org/jira/browse/JBKERNEL-115 https://jira.jboss.org/jira/browse/JBKERNEL-115 for the StaticInjector stuff The kernel/kernel tests all pass now using the Javassist version of jboss-reflect :-) I'll move on to the other modules in kernel, before looking at classloader, deployers etc. -------------------------------------------------------------- Reply to this message by going to Community [http://community.jboss.org/message/534713#534713] Start a new discussion in JBoss Microcontainer Development at Community [http://community.jboss.org/choose-container!input.jspa?contentType=1&cont...]

14 years, 9 months

1
0
0 / 0

Re: [jboss-dev-forums] [JBoss Microcontainer Development] - Issues using Javassist TypeInfoFactory in other projects

by Kabir Khan

Kabir Khan [http://community.jboss.org/people/kabir.khan%40jboss.com] replied to the discussion "Issues using Javassist TypeInfoFactory in other projects" To view the discussion, visit: http://community.jboss.org/message/534708#534708 -------------------------------------------------------------- > Kabir Khan wrote: > > Another issue is that dynamically created classes are not found in the classpools. Rather than all the fancy BytecodeRecorder stuff, I am simply delegating to the IntrospectionTypeInfoFactory if the class can not be found in the classpool: [kabir ~/sourcecontrol/jboss-reflect/trunk/jboss-reflect] $svn diff Index: src/main/java/org/jboss/reflect/plugins/javassist/JavassistTypeInfoFactoryImpl.java =================================================================== --- src/main/java/org/jboss/reflect/plugins/javassist/JavassistTypeInfoFactoryImpl.java (revision 103127) +++ src/main/java/org/jboss/reflect/plugins/javassist/JavassistTypeInfoFactoryImpl.java (working copy) @@ -49,6 +49,7 @@ import org.jboss.reflect.plugins.AnnotationValueImpl; import org.jboss.reflect.plugins.EnumConstantInfoImpl; import org.jboss.reflect.plugins.GenericsUtil; +import org.jboss.reflect.plugins.introspection.IntrospectionTypeInfoFactory; import org.jboss.reflect.plugins.javassist.classpool.ClassPoolFactory; import org.jboss.reflect.plugins.javassist.classpool.DefaultClassPoolFactory; import org.jboss.reflect.spi.AnnotationInfo; @@ -284,11 +285,33 @@ } catch(NotFoundException nfe) { - throw new ClassNotFoundException(nfe.getMessage()); + return delegateToIntrospectionImplementation(cl, name); } } /** + * Proxies, whether + * <ul> + * <li>JDK dynamic proxies</li> + * <li>javassist ProxyFactory proxies - created by calling ClassLoader.defineClass()</li> + * </ul> + * are not visible to the javassist classpools, and neither will classes generated by cglib or other + * frameworks, so try to load up the class from the reflect implementation. + * + * @param cl the classloader + * @param name the name of the class + * @return the info + * @throws ClassNotFoundException when the class cannot be found + */ + private TypeInfo delegateToIntrospectionImplementation(ClassLoader cl, String name) throws ClassNotFoundException + { + //Check the class has been loaded + cl.loadClass(name); + IntrospectionTypeInfoFactory factory = new IntrospectionTypeInfoFactory(); + return factory.getTypeInfo(name, cl); + } + + /** -------------------------------------------------------------- Reply to this message by going to Community [http://community.jboss.org/message/534708#534708] Start a new discussion in JBoss Microcontainer Development at Community [http://community.jboss.org/choose-container!input.jspa?contentType=1&cont...]

14 years, 9 months

1
0
0 / 0

Re: [jboss-dev-forums] [JBoss Transactions Development] - beanifying the config

by Jonathan Halliday

Jonathan Halliday [http://community.jboss.org/people/jhalliday] replied to the discussion "beanifying the config" To view the discussion, visit: http://community.jboss.org/message/534687#534687 -------------------------------------------------------------- I think it's about time for another round... Many of the remaining static initializers are concerned with taking a property value from an EnvironmentBean and using it to instantiate a class or classes e.g. String checkedActionFactory = arjPropertyManager.getCoordinatorEnvironmentBean().getCheckedActionFactory(); Class factory = Thread.currentThread().getContextClassLoader().loadClass(checkedActionFactory); CheckedActionFactory _checkedActionFactory = (CheckedActionFactory) factory.newInstance(); I'd like something that gives better control over a) dynamic changes - it should not be necessary to reload the class (which basically means restarting the server) to change the effective value. Actually this is not just an issue for Class type properties and should probably be discussed separately. b) type safety - ideally we'd detect problems at the point setCheckedActionFactory was called c) class loading, particularly with regard to availability of the class and supply of any parameters it may need. I'm mulling over a few alternatives, such as adding a typed version of the getter to the EnvironmentBean CheckedActionFactory _checkedActionFactory = arjPropertyManager.getCoordinatorEnvironmentBean().getCheckedActionFactoryInstance(); and having some form of update synchronization between that and the setCheckedActionFactory(String) method. That may be sync on write i.e. instantiate the class at the point its stringified name is supplied, or it may be lazy. It may also be desirable to add a typed setter to the EnvironmentBean: public class CoordinatorEnvironmentBean { public void setCheckedActionFactoryInstance(CheckedActionFactory instance) {...} although then we have also to tackle the reverse update of the String value from the class. However, it would allow for better beans wiring by DI frameworks compared to the current situation. In particular, the CheckedActionFactory impl could require ctor params and have those wired by the DI farmework, which is not possible with the current loading mechanism. Anybody care to venture an opinion before I pick an implementation alternative at random? -------------------------------------------------------------- Reply to this message by going to Community [http://community.jboss.org/message/534687#534687] Start a new discussion in JBoss Transactions Development at Community [http://community.jboss.org/choose-container!input.jspa?contentType=1&cont...]

14 years, 9 months

1
0
0 / 0

Re: [jboss-dev-forums] [JBoss Microcontainer Development] - Issues using Javassist TypeInfoFactory in other projects

by Kabir Khan

Kabir Khan [http://community.jboss.org/people/kabir.khan%40jboss.com] replied to the discussion "Issues using Javassist TypeInfoFactory in other projects" To view the discussion, visit: http://community.jboss.org/message/534679#534679 -------------------------------------------------------------- It looks like ReflectMethodImpl.setMethod() and ReflectFieldImpl.setField() do that already: RMI: public void setMethod(Method method) { boolean isDeclaringClassPublic = true; if (method != null) { accessCheck(Modifier.isPublic(method.getModifiers())); isDeclaringClassPublic = isDeclaringClassPublic(method); accessCheck(isDeclaringClassPublic); } this.method = method; if (method != null && (isPublic() == false || isDeclaringClassPublic == false)) setAccessible(); } RFI: public void setField(Field field) { if (field != null) accessCheck(Modifier.isPublic(field.getModifiers())); this.field = field; if (isPublic() == false && field != null) setAccessible(); } Commenting out the whole block which threw the exception for JavassistMethodInfo, and setAccessible=true for ReflectMethodInfoImpl, works with both modes org.jboss.test.kernel.deployment.support.StaticInjector: private void injectToMethod(Class<?> clazz, String method, Object value, Class<?> signature, boolean isPublic) throws Throwable { ClassInfo classInfo = configurator.getClassInfo(clazz); MethodInfo mi = Config.findMethodInfo(classInfo, method, new String[]{signature.getName()}, true, isPublic); // if (isPublic == false) // { // // TODO - move this into Reflection? // if (mi instanceof ReflectMethodInfoImpl) // { // ReflectMethodInfoImpl rmi = (ReflectMethodInfoImpl)mi; // Method m = rmi.getMethod(); // m.setAccessible(true); // } // else // throw new IllegalArgumentException("Cannot set accessible on method info: " + mi); // } mi.invoke(null, new Object[]{value}); } -------------------------------------------------------------- Reply to this message by going to Community [http://community.jboss.org/message/534679#534679] Start a new discussion in JBoss Microcontainer Development at Community [http://community.jboss.org/choose-container!input.jspa?contentType=1&cont...]

14 years, 9 months

1
0
0 / 0

Re: [jboss-dev-forums] [JBoss Profiler Development] - jboss-profiler-2.0.0 Configuration Issue.

by Ankita Malviya

Ankita Malviya [http://community.jboss.org/people/ankitamalviya] replied to the discussion "jboss-profiler-2.0.0 Configuration Issue." To view the discussion, visit: http://community.jboss.org/message/534669#534669 -------------------------------------------------------------- I am using jboss. I want to view the profiling. Is there any profiler that can be used with jboss. and if yes How? -------------------------------------------------------------- Reply to this message by going to Community [http://community.jboss.org/message/534669#534669] Start a new discussion in JBoss Profiler Development at Community [http://community.jboss.org/choose-container!input.jspa?contentType=1&cont...]

14 years, 9 months

1
0
0 / 0

Re: [jboss-dev-forums] [JCA Development] - JcaXAResourceRecovery

by Jesper Pedersen

Jesper Pedersen [http://community.jboss.org/people/jesper.pedersen] replied to the discussion "JcaXAResourceRecovery" To view the discussion, visit: http://community.jboss.org/message/534661#534661 -------------------------------------------------------------- Ok, we will go with the current test cases you have for now. But I think it would be a good idea to see if we can get the test automatted as part of the main AS test suite - without depending on the Red Hat network. Code location git@github.com:jesperpedersen/eap.git on branch "xaresourcerecovery". We will move back to svn.jboss.org once the branch is open. -------------------------------------------------------------- Reply to this message by going to Community [http://community.jboss.org/message/534661#534661] Start a new discussion in JCA Development at Community [http://community.jboss.org/choose-container!input.jspa?contentType=1&cont...]

14 years, 9 months

1
0
0 / 0

Re: [jboss-dev-forums] [JBoss Microcontainer Development] - On demand resolution

by Ales Justin

Ales Justin [http://community.jboss.org/people/alesj] replied to the discussion "On demand resolution" To view the discussion, visit: http://community.jboss.org/message/534633#534633 -------------------------------------------------------------- > I guess for this one it's not too late to be moved there -- as it's been only introduced in 2.2.0.AlphaX? https://jira.jboss.org/jira/browse/JBDEPLOY-255 https://jira.jboss.org/jira/browse/JBDEPLOY-255 -------------------------------------------------------------- Reply to this message by going to Community [http://community.jboss.org/message/534633#534633] Start a new discussion in JBoss Microcontainer Development at Community [http://community.jboss.org/choose-container!input.jspa?contentType=1&cont...]

14 years, 9 months

1
0
0 / 0

Re: [jboss-dev-forums] [JBoss Microcontainer Development] - Issues using Javassist TypeInfoFactory in other projects

by Ales Justin

Ales Justin [http://community.jboss.org/people/alesj] replied to the discussion "Issues using Javassist TypeInfoFactory in other projects" To view the discussion, visit: http://community.jboss.org/message/534628#534628 -------------------------------------------------------------- > > If we moved the setAccessible() stuff to jboss-reflect as indicated in the comment, we could manage the accessibility of members there? This was a hack to get private method injection working -- use case for some EJB sandbox/prototype. Dunno if this is still needed, perhaps just check if BeanAccessMode.ALL already does this on top of BeanInfo. I know it does for private method/fields, just not sure about any method. If not, then we can simply extend this notion of ALL to methods as well. -------------------------------------------------------------- Reply to this message by going to Community [http://community.jboss.org/message/534628#534628] Start a new discussion in JBoss Microcontainer Development at Community [http://community.jboss.org/choose-container!input.jspa?contentType=1&cont...]

14 years, 9 months

1
0
0 / 0

Re: [jboss-dev-forums] [JBoss Microcontainer Development] - On demand resolution

by Ales Justin

Ales Justin [http://community.jboss.org/people/alesj] replied to the discussion "On demand resolution" To view the discussion, visit: http://community.jboss.org/message/534616#534616 -------------------------------------------------------------- > Adrian Brock wrote: > > > Adrian Brock wrote: > > I've committed the following patch which makes it work using Ales's DeploymentMetaData > > <snip/> > > +import org.jboss.deployers.plugins.classloading.DeploymentMetaData; > P.S.2 Shouldn't this metadata be in the spi? I guess for this one it's not too late to be moved there -- as it's been only introduced in 2.2.0.AlphaX? (dunno why I put it there in the first place, might be same stupid reason as DepenenciesMD) What about DependenciesMetaData -- which is also in impl/plugins? Since this one has been around longer. :-( -------------------------------------------------------------- Reply to this message by going to Community [http://community.jboss.org/message/534616#534616] Start a new discussion in JBoss Microcontainer Development at Community [http://community.jboss.org/choose-container!input.jspa?contentType=1&cont...]

14 years, 9 months

1
0
0 / 0

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

jboss-dev-forums March 2010