CORE PROFILE SERVICE
As far as the core profile api goes this doesn't look too bad.
It still has the VFSDeployment and DeploymentPhase stuff in there,
I think we can live with that (its a bit too close to the implementation details for my
liking).
The part that I think is missing is the ability to add/remove profiles.
My original idea for profiles was that the profile could be implemented how you like
(picking from existing implementations or writing your own).
The current api only allows you to create/remove implementations dictated by the
profile service itself.
You can see this problem in the way the farming stuff done by Brian is using
the DeploymentManager of the profile service rather than adding his own sub-profile.
But you can also see it in that there is no current support for sub-profiles at all
really
or activation/deactivation of these (the deployment phase was originally
done as a hack until sub-profiles were implemented).
The one part that really does look broken to me is the following method
on the Profile interface.
VirtualFile getRootFile(DeploymentPhase phase) throws Exception;
This has no meaning when there are multiple roots.
Since its use seems to be a location where template
deployments get constructed this also looks broken if the profile is
"read-only"
by which I mean only admin overrides in the local repository are allowed
not modification of the original source location.
View the original post :
http://www.jboss.com/index.html?module=bb&op=viewtopic&p=4192163#...
Reply to the post :
http://www.jboss.com/index.html?module=bb&op=posting&mode=reply&a...