[jboss-dev-forums] [Design of POJO Server] - Re: Profile Service api

REPOSITORY API This is a lot worse. It's actually ok as it currently stands in princple since all of this is actually hidden as implementation details within the org.jboss.system.server.profileservice.repository.ProfileServiceImpl But where this doesn't work is that some of those implementation details have been promoted to spi when they clearly are nothing of the sort. e.g. org.jboss.profileservice.spi.DeploymentRepository This looks far too close to the implementation details to be done in any other way. Even to the extent of exposing locking methods. The AbstractAttachmentStore is probably closer to what people would really want to use in terms of changing behaviour. But this is not spi. But both contain incorrect assumptions like the repository and source of the profile come from the same integration point. These two things are seperate concerns. That should not be mixed. My guess is that a proper seperation would make the spi(s) for these a lot simpler. Just trying to read the source code for this is very hard. I found it difficult to understand which parts were referring to server/default/deploy or data/attachments/... The assumption that server/default/deploy is a file/directory is just broken and so are the names given to files in data/attachments (not unique enough). I'll conclude as I started. If it were possible to implement the (sub-)profile how you like, the current state of Repository API would not be an issue. View the original post : http://www.jboss.com/index.html?module=bb&op=viewtopic&p=4192175#... Reply to the post : http://www.jboss.com/index.html?module=bb&op=posting&mode=reply&a...