[Design of JBossCache] - Re: JBCACHE-1154 - Introduce ability to mark nodes as reside
by manik.surtani@jboss.com
"genman" wrote :
| 1. The internal code looks like crap. I don't know why you didn't opt for a boolean flag like everything else, but so be it.
|
See Mircea's answer.
"genman" wrote :
| 2. You added new methods to an interface that's potentially designed for clients to implement. Or, is this interface supposed to get 2 new methods every point release? Adrian Brock "yelled" at me for doing something like this on a fairly obscure internal interface, and I don't and didn't work for JBoss. Hasn't he knocked a few times wondering what's going on?
|
|
1) This isn't an external interface that clients implement
2) This isn't a point-release.
"genman" wrote :
| The main point was never to "aggregate booleans", it would just have been a nice side-effect. Saving memory is certainly nice, but next time I won't bring it up since it seems to just confuse people.
|
Nothing to confuse, we just opted for code readability over potentially saving a few bytes.
Storing such metadata in a Properties object does make sense, but until we can implement sufficient internal changes to replicate and persist such metadata, it is pointless.
View the original post : http://www.jboss.com/index.html?module=bb&op=viewtopic&p=4090140#4090140
Reply to the post : http://www.jboss.com/index.html?module=bb&op=posting&mode=reply&p=4090140
17 years, 2 months