October 2008 - jboss-dev-forums - Jboss List Archives

[Design the new POJO MicroContainer] - Abstractions, reuse and bad examples

by adrian＠jboss.org

Here's an example of a bad abstraction I found by accident. This is actually from the tests so its not too bad, but see below. This could obviously be made more useful to others with the following changes; | public class SearchDeployer extends AbstractDeployer | { | private URL[] urls; | | + private String prefix; | | + private String suffix; | | public SearchDeployer() | { | setStage(DeploymentStages.REAL); | } | | public String getPrefix() | { | return prefix; | } | | public void setPrefix(String prefix) | { | this.prefix = prefix; | } | | public String getSuffix() | { | return suffix; | } | | public void setSuffix(String suffix) | { | this.suffix = suffix; | } | | public void deploy(DeploymentUnit unit) throws DeploymentException | { | try | { | - urls = Classpath.search(unit.getClassLoader(), "META-INF/", ".taglib.xml"); | + urls = Classpath.search(unit.getClassLoader(), prefix, suffix); | } | catch (IOException e) | { | - DeploymentException.rethrowAsDeploymentException("Error doing facelets search", e); | + DeploymentException.rethrowAsDeploymentException("Error doing search prefix=" + prefix + " suffix=" + suffix, e); | } | } | | public void undeploy(DeploymentUnit unit) | { | urls = null; | } | | public URL[] getUrls() | { | return urls; | } | } | That way the facelets deployer (which is obviously where this comes from?) can extend this SearchDeployer and reuse generic tested code. This argument is further enhanced because if you look at what ClassPath.search() it is wrong, it isn't making reference to the ClassLoadingMetaData/Module so it will ignore any filters. Has this code been copied somewhere else? It's generally a bad idea to show the wrong way to do things in tests because people copy what they find thinking that's the way it is supposed to work. :-) View the original post : http://www.jboss.com/index.html?module=bb&op=viewtopic&p=4180248#4180248 Reply to the post : http://www.jboss.com/index.html?module=bb&op=posting&mode=reply&p=4180248

15 years, 7 months

1
0
0 / 0

[Design of POJO Server] - Re: Testing Bootstrap Dependencies

by istudens＠redhat.com

Finally, I got full access to the svn. So I've committed the tests and reported a new issue about ejb3 session beans (https://jira.jboss.org/jira/browse/JBAS-6028). View the original post : http://www.jboss.com/index.html?module=bb&op=viewtopic&p=4180242#4180242 Reply to the post : http://www.jboss.com/index.html?module=bb&op=posting&mode=reply&p=4180242

15 years, 7 months

1
0
0 / 0

[Design the new POJO MicroContainer] - Re: 2.0.0.CR2?

by kabir.khan＠jboss.com

I'll be releasing another AOP CR today, and update AS + MC to use that View the original post : http://www.jboss.com/index.html?module=bb&op=viewtopic&p=4180230#4180230 Reply to the post : http://www.jboss.com/index.html?module=bb&op=posting&mode=reply&p=4180230

15 years, 7 months

1
0
0 / 0

[Design of Messaging on JBoss (Messaging/JBoss)] - Re: Some thoughts on large messages and message chunking

by timfox

Ok please commit on a different branch so we can see it before it goes on trunk. View the original post : http://www.jboss.com/index.html?module=bb&op=viewtopic&p=4180214#4180214 Reply to the post : http://www.jboss.com/index.html?module=bb&op=posting&mode=reply&p=4180214

15 years, 7 months

1
0
0 / 0

[Design of Messaging on JBoss (Messaging/JBoss)] - Re: Some thoughts on large messages and message chunking

by clebert.suconic＠jboss.com

"Tim Fox" wrote : When sending a message, we simply check if message size is greater than ml. If false then message sending and delivery proceeds exactly as normal. If true, then we send a standard SendMessage packet, followed by n MessageContinuation packets which contains the rest of the message split into each packet. | I'm doing this with a slightly variant. SessionSendMessage creates the ServerMessageImpl, and decode/encodes directly from the Buffer to avoid copy and get some performance. As SessionSendMessage is the class responsible for creating the MessageImpl, I was have a little difficult on instantiating the ServerMessage that will store the body on a file. Because of that, when using LargeMessages I'm using another PacketType to deal with Large Messages. With that the regular use case would be optimized avoiding extra non necessary copies. I will commit it tomorrow (on trunk or another branch) and it will be easier to talk about this later when I have some code to show the differences. View the original post : http://www.jboss.com/index.html?module=bb&op=viewtopic&p=4180171#4180171 Reply to the post : http://www.jboss.com/index.html?module=bb&op=posting&mode=reply&p=4180171

15 years, 7 months

1
0
0 / 0

[Design of Messaging on JBoss (Messaging/JBoss)] - Re: Message Scheduling

by clebert.suconic＠jboss.com

"timfox" wrote : Scheduled time is store on the reference level, not the message level, so it needs to be a separate update record in the journal. Hmm... Ok.. then Andy was right about adding the field on PageMessage. It should be a simple change. View the original post : http://www.jboss.com/index.html?module=bb&op=viewtopic&p=4180115#4180115 Reply to the post : http://www.jboss.com/index.html?module=bb&op=posting&mode=reply&p=4180115

15 years, 7 months

1
0
0 / 0

[Design of Messaging on JBoss (Messaging/JBoss)] - Re: Message Scheduling

by timfox

Scheduled time is store on the reference level, not the message level, so it needs to be a separate update record in the journal. View the original post : http://www.jboss.com/index.html?module=bb&op=viewtopic&p=4180103#4180103 Reply to the post : http://www.jboss.com/index.html?module=bb&op=posting&mode=reply&p=4180103

15 years, 7 months

1
0
0 / 0

[Design of Messaging on JBoss (Messaging/JBoss)] - Re: Message Scheduling

by clebert.suconic＠jboss.com

If you could avoid a different Packet it would be better, as we would need also to deal with that also later on LargeMessage IMO If you put the scheduledTime somehow on MessageImpl or ClientMessageImpl anyway you want, it would solve the problem on Paging + Remoting + Journal with a single shot. View the original post : http://www.jboss.com/index.html?module=bb&op=viewtopic&p=4180102#4180102 Reply to the post : http://www.jboss.com/index.html?module=bb&op=posting&mode=reply&p=4180102

15 years, 7 months

1
0
0 / 0

[Design the new POJO MicroContainer] - Re: 2.0.0.CR2?

by alesj

"scott.stark(a)jboss.org" wrote : When is 2.0.0.CR2 planned? Nothing planned. I'll check tomorrow what all needs porting to 2_0 branch. And eventually cut new releases. View the original post : http://www.jboss.com/index.html?module=bb&op=viewtopic&p=4180097#4180097 Reply to the post : http://www.jboss.com/index.html?module=bb&op=posting&mode=reply&p=4180097

15 years, 7 months

1
0
0 / 0

[Design of the JBoss EJB Container] - Re: Exploded deployment EJB problem

by tamilsmani

Cause for the problem was jdk mismatch in JBOSS and the workspace. Watch this link for more info. http://www.jboss.com/index.html?module=bb&op=viewtopic&t=143173 Regards Tamil Selvan. View the original post : http://www.jboss.com/index.html?module=bb&op=viewtopic&p=4180096#4180096 Reply to the post : http://www.jboss.com/index.html?module=bb&op=posting&mode=reply&p=4180096

15 years, 7 months

1
0
0 / 0

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

jboss-dev-forums October 2008