March 2008 - jboss-dev-forums - Jboss List Archives

[Design of OSGi Integration] - Re: Why Class.forName sucks!

by adrian＠jboss.org

It doesn't just suck, it is evil. It caches things it shouldn't. We were forced into it for java6 array problem. But its only really required if the classname looks like an array class. You changed too much for this. e.g. you changed all the classloader stuff, even though the entry point loadClass() already has the checking. | if (classNameLooksLikeAnError) | useClassForName(); | else | loadClassFromClassLoaderNormally(); | But you can't rely on our classloader being the entry point all the time, so a helper class that does this would be ok. i.e. invoke the helper doing the code above instead of Class.forName() directly. Another workaround would be to byte code weave all classes using Class.forName() to our helper using a Transformer on the classloader. The ironic part is that Java6 on Sun has a rewritten constraint checker that is much faster. ;-) View the original post : http://www.jboss.com/index.html?module=bb&op=viewtopic&p=4133925#4133925 Reply to the post : http://www.jboss.com/index.html?module=bb&op=posting&mode=reply&p=4133925

16 years, 3 months

1
0
0 / 0

[Design the new POJO MicroContainer] - Re: aop-mc-int tests failing on annotation parsing

by alesj

"adrian(a)jboss.org" wrote : | I don't really understand this? The test was added at the same time as a change | to the AOPConstructorJoinpoint (so it must have worked at some point unless | I'm stupid? :-) | | The test hasn't changed since, but the joinpoint factory has changed a lot. | | Choose one of: | * the test only worked by fluke and later fixes found the problem - so it started failing | and nobody raised an issue | * or the test never worked - and its been failing for 14 months without comment | I have no idea how this ever worked - with AOP enabled. :-) Since it does exactly what I wrote. I don't see where you could pull out non-null MetaData, after you mask it in the AOPConstructorJoinpoint, and all you have is | public static void peekMetaData() | { | peekedMetaData = MetaDataStack.peek(); | } | in AbstractMetaDataTest. Who's only usage is in TestClassAnnotation constructor. View the original post : http://www.jboss.com/index.html?module=bb&op=viewtopic&p=4133924#4133924 Reply to the post : http://www.jboss.com/index.html?module=bb&op=posting&mode=reply&p=4133924

16 years, 3 months

1
0
0 / 0

[Design of OSGi Integration] - Why Class.forName sucks!

by alesj

Is this something we need to be concerned: - http://www.eclipsecon.org/2008/index.php?page=sub/&id=377 Since we just recently changed all the Class 'lookup' to this. :-) View the original post : http://www.jboss.com/index.html?module=bb&op=viewtopic&p=4133921#4133921 Reply to the post : http://www.jboss.com/index.html?module=bb&op=posting&mode=reply&p=4133921

16 years, 3 months

1
0
0 / 0

[Design the new POJO MicroContainer] - Re: aop-mc-int tests failing on annotation parsing

by adrian＠jboss.org

"alesj" wrote : "alesj" wrote : | | "adrian(a)jboss.org" wrote : | | | It's strange that these are all annotation tests????? | | | | | Yup, looks like my fault. :-) | And this one - ClassAnnotationTestCase - is all yours. :-) | | You are peeking MetaData in the TestClassAnnotation constructor. | And in the test you expect this MetaData not to be null - assertPeekedMetaData. | But the AOPConstructorJoinpoint masks the MetaData just before it creates the instance. | I don't really understand this? The test was added at the same time as a change to the AOPConstructorJoinpoint (so it must have worked at some point unless I'm stupid? :-) The test hasn't changed since, but the joinpoint factory has changed a lot. Choose one of: * the test only worked by fluke and later fixes found the problem - so it started failing and nobody raised an issue * or the test never worked - and its been failing for 14 months without comment Either way, it doesn't fill me confidence. ;-( It's a stupid test anyway. The purpose is to make sure the metadata is populated properly from the class/xml It uses the push of the metadata (for AOP to pickup under the wire) to get this information. It would be the same if it just did: ControllerContext context = .assertInstalledContext("name"); ScopeKey scope = context.getScopeInfo()...; MetaData md = repository.getMetaData(scope); View the original post : http://www.jboss.com/index.html?module=bb&op=viewtopic&p=4133919#4133919 Reply to the post : http://www.jboss.com/index.html?module=bb&op=posting&mode=reply&p=4133919

16 years, 3 months

1
0
0 / 0

[Design of JBoss Tools (dev)] - Re: Bug in the HTML editor using RIchfaces

by max.andersen＠jboss.com

start by reporting it in jira with enough info to understand what the bug (if it is not a feature?) is about... View the original post : http://www.jboss.com/index.html?module=bb&op=viewtopic&p=4133915#4133915 Reply to the post : http://www.jboss.com/index.html?module=bb&op=posting&mode=reply&p=4133915

16 years, 3 months

1
0
0 / 0

[Design the new POJO MicroContainer] - Re: aop-mc-int tests failing on annotation parsing

by alesj

The last one testKernelControllerContextAware(org.jboss.test.kernel.dependency.test.KernelControllerContextAwareAnnotationTestCase) Time elapsed: 0.044 sec <<< FAILURE! is the same problem as the previous mentioned - delegate vs. proxy. View the original post : http://www.jboss.com/index.html?module=bb&op=viewtopic&p=4133911#4133911 Reply to the post : http://www.jboss.com/index.html?module=bb&op=posting&mode=reply&p=4133911

16 years, 3 months

1
0
0 / 0

[Design the new POJO MicroContainer] - Re: aop-mc-int tests failing on annotation parsing

by alesj

"alesj" wrote : | "adrian(a)jboss.org" wrote : | | It's strange that these are all annotation tests????? | | | Yup, looks like my fault. :-) And this one - ClassAnnotationTestCase - is all yours. :-) You are peeking MetaData in the TestClassAnnotation constructor. And in the test you expect this MetaData not to be null - assertPeekedMetaData. But the AOPConstructorJoinpoint masks the MetaData just before it creates the instance. View the original post : http://www.jboss.com/index.html?module=bb&op=viewtopic&p=4133905#4133905 Reply to the post : http://www.jboss.com/index.html?module=bb&op=posting&mode=reply&p=4133905

16 years, 3 months

1
0
0 / 0

[Design of JBoss jBPM] - Re: jBPM Classloading

by tom.baeyens＠jboss.com

koen, can you monitor this and take it in ? View the original post : http://www.jboss.com/index.html?module=bb&op=viewtopic&p=4133902#4133902 Reply to the post : http://www.jboss.com/index.html?module=bb&op=posting&mode=reply&p=4133902

16 years, 3 months

1
0
0 / 0

[Design of JBoss jBPM] - Re: jBPM Classloading

by tom.baeyens＠jboss.com

good solution, but the configuration mechanism proposed is not in sync with the jbpm configuration. please propose the same kind of configuration but based on JbpmConfiguration.Configs.getProperty (or something like that. i don't remember it by heart) and verify that the test suite still works. then we can take it in. View the original post : http://www.jboss.com/index.html?module=bb&op=viewtopic&p=4133901#4133901 Reply to the post : http://www.jboss.com/index.html?module=bb&op=posting&mode=reply&p=4133901

16 years, 3 months

1
0
0 / 0

[Design the new POJO MicroContainer] - Re: aop-mc-int tests failing on annotation parsing

by alesj

"adrian(a)jboss.org" wrote : | Do you want to raise a bug report telling what you found and assign it to Kabir. | Sure. Just waiting to catch him on the IM. "adrian(a)jboss.org" wrote : | It's strange that these are all annotation tests????? | Yup, looks like my fault. :-) But I don't do anything extraordinary. There is always just a simple super class that overrides some of the behavior of the actual class that holds the variables. e.g overriding create method to add @Create annotation, instead of doing that via xml "adrian(a)jboss.org" wrote : | If its passed the arguments to the target then it isn't an MC or test issue | (unless you are somehow checking the wrong target). How could I check the wrong target? My target is ControllerContext.getTarget(), which is, when AOP-MC-int is present, a proxy created by AOPConstructorJoinpoint. View the original post : http://www.jboss.com/index.html?module=bb&op=viewtopic&p=4133899#4133899 Reply to the post : http://www.jboss.com/index.html?module=bb&op=posting&mode=reply&p=4133899

16 years, 3 months

1
0
0 / 0

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

jboss-dev-forums March 2008