[jboss-dev-forums] [Design of JBoss internal QA (Test Suite)] - Re: Updating the server task to detect OutOfMemoryErrors

Looking at your code attached to the JIRA, it looks like the right approach (nice job), I just have a few comments: - If a server is low on memory, the exception thrown should indicate *which* server was low. - The package for your new classes should be org.jboss.tools.ant.taskdefs not org.apache.tools.ant.taskdefs - Are you following JBoss code convetions? http://docs.jboss.org/process-guide/en/html/coding.html - You add this in the jboss-test project here: https://svn.jboss.org/repos/jbossas/projects/test/trunk/ - Testing - There should be a "test-mem-check-runner" in the jboss-test project. This target should test the following scenarios: - two servers with plenty of memory - two servers: one low, one normal - two servers: both low - Have someone else reproduce your test results after committing to thee test project. Deployment - Once the tests pass and someone has reviewed it, commit it to /trunk. Once it has been in /trunk for a week, we can talk about deployment to other branches. View the original post : http://www.jboss.com/index.html?module=bb&op=viewtopic&p=4031879#... Reply to the post : http://www.jboss.com/index.html?module=bb&op=posting&mode=reply&a...