[JBoss JIRA] (DROOLS-2530) DMN Decision Table - wrong evaluation of parameter named "product"
by David Le Moing (Jira)
[ https://issues.jboss.org/browse/DROOLS-2530?page=com.atlassian.jira.plugi... ]
David Le Moing closed DROOLS-2530.
----------------------------------
> DMN Decision Table - wrong evaluation of parameter named "product"
> ------------------------------------------------------------------
>
> Key: DROOLS-2530
> URL: https://issues.jboss.org/browse/DROOLS-2530
> Project: Drools
> Issue Type: Bug
> Components: dmn engine
> Affects Versions: 7.5.0.Final, 7.6.0.Final, 7.7.0.Final
> Reporter: David Le Moing
> Assignee: Fedor Gavrilov
> Priority: Critical
> Fix For: 7.8.0.Final
>
> Attachments: product_issue.dmn
>
>
> We have an input named "product" that is used in a decision table.
> We upgraded to Drools 7.7.0.Final and noticed that now, what was evaluated was not the object passed as parameter, but an object of type ProductFunction.
> The same issue is present in version 7.5.0.Final and 7.6.0.Final. It was working fine previously.
> I think the issue is coming from the method getAllValues() of EvaluationContextImpl. Maybe the stack should be reversed before iterating over it and putting the values in the map.
--
This message was sent by Atlassian Jira
(v7.12.1#712002)
7 years, 6 months
[JBoss JIRA] (DROOLS-3514) [DMN Designer] Feel autocomplete, syntax highlighting and type checking.
by Michael Anstis (Jira)
[ https://issues.jboss.org/browse/DROOLS-3514?page=com.atlassian.jira.plugi... ]
Michael Anstis updated DROOLS-3514:
-----------------------------------
Summary: [DMN Designer] Feel autocomplete, syntax highlighting and type checking. (was: [DMN Designer] Feel autocomplete, sintax highlighting and type checking.)
> [DMN Designer] Feel autocomplete, syntax highlighting and type checking.
> ------------------------------------------------------------------------
>
> Key: DROOLS-3514
> URL: https://issues.jboss.org/browse/DROOLS-3514
> Project: Drools
> Issue Type: Feature Request
> Components: DMN Editor
> Affects Versions: 7.15.0.Final
> Reporter: Thomas Mantegazzi
> Assignee: Michael Anstis
> Priority: Major
> Labels: drools-tools
> Attachments: image-2019-01-14-09-16-09-474.png, image-2019-01-14-09-16-30-813.png, image-2019-01-14-09-17-20-451.png
>
>
> When trying to write decisions, it would be nice to have some sintax highlighting, and autocomplete based on the inputs provided to the decision in the DRG.
> DRG:
> !image-2019-01-14-09-16-09-474.png|thumbnail!
> Data type:
> !image-2019-01-14-09-16-30-813.png|thumbnail!
> Feel expression:
> !image-2019-01-14-09-17-20-451.png|thumbnail!
> In this case, it would be nice that when we write "p" we get the suggestion "person".
> It would also be nice to get type checking, so that if we declare a DMN decision to have output of type : "number" we can not write a literal expression that outputs a String.
--
This message was sent by Atlassian Jira
(v7.12.1#712002)
7 years, 6 months
[JBoss JIRA] (DROOLS-3373) [DMN Designer] Need Palette glyph/icon and Canvas shape for Decision Service
by Michael Anstis (Jira)
[ https://issues.jboss.org/browse/DROOLS-3373?page=com.atlassian.jira.plugi... ]
Michael Anstis commented on DROOLS-3373:
----------------------------------------
[~bdellasc] Good question... and it led me to change the SVG from a Path to a Rectangle.
Stunner scales Paths when the node is resized so the original image (I've now deleted) had the stroke width (and corners) scaled too and it looked bad.
Stunner however is a little more clever when a Rectangle is resized and it is able to maintain the stroke width and corner radius.
I've attached a new screen shot that, IMO, looks much better.
> [DMN Designer] Need Palette glyph/icon and Canvas shape for Decision Service
> ----------------------------------------------------------------------------
>
> Key: DROOLS-3373
> URL: https://issues.jboss.org/browse/DROOLS-3373
> Project: Drools
> Issue Type: Feature Request
> Components: DMN Editor
> Affects Versions: 7.15.0.Final
> Reporter: Michael Anstis
> Assignee: Michael Anstis
> Priority: Major
> Labels: VisualDesign, drools-tools, ux_needed, visualdesign
> Attachments: DMN_palette_icons.png, DecisionService-insitu.png, Screenshot from 2019-01-14 10-48-32.png, decision-service.svg, decision.svg, decision_palette.svg, decision_service_expanded_palette.svg, decision_service_palette.svg
>
>
> We need a new "Palette" icon and Canvas shape for "Decision Services".
> See Table 1: DRD components in the [DMN 1.2 Specification|https://www.omg.org/spec/DMN/1.2/Beta1/PDF].
> See also 6.2.5 Decision service for some narrative regarding the shape.
> {quote}
> A Decision Service is represented in a DRD as rectangle with rounded corners, drawn with a heavy solid border.... the Decision Service SHALL be divided into two parts with a straight solid line.
> {quote}
> We are currently adding support for the _expanded_ form however we will also require (at some stage) a Palette glyph/icon and Canvas shape for the _collapsed_ form too.
--
This message was sent by Atlassian Jira
(v7.12.1#712002)
7 years, 6 months
[JBoss JIRA] (DROOLS-3373) [DMN Designer] Need Palette glyph/icon and Canvas shape for Decision Service
by Michael Anstis (Jira)
[ https://issues.jboss.org/browse/DROOLS-3373?page=com.atlassian.jira.plugi... ]
Michael Anstis updated DROOLS-3373:
-----------------------------------
Attachment: Screenshot from 2019-01-14 10-48-32.png
> [DMN Designer] Need Palette glyph/icon and Canvas shape for Decision Service
> ----------------------------------------------------------------------------
>
> Key: DROOLS-3373
> URL: https://issues.jboss.org/browse/DROOLS-3373
> Project: Drools
> Issue Type: Feature Request
> Components: DMN Editor
> Affects Versions: 7.15.0.Final
> Reporter: Michael Anstis
> Assignee: Michael Anstis
> Priority: Major
> Labels: VisualDesign, drools-tools, ux_needed, visualdesign
> Attachments: DMN_palette_icons.png, DecisionService-insitu.png, Screenshot from 2019-01-14 10-48-32.png, decision-service.svg, decision.svg, decision_palette.svg, decision_service_expanded_palette.svg, decision_service_palette.svg
>
>
> We need a new "Palette" icon and Canvas shape for "Decision Services".
> See Table 1: DRD components in the [DMN 1.2 Specification|https://www.omg.org/spec/DMN/1.2/Beta1/PDF].
> See also 6.2.5 Decision service for some narrative regarding the shape.
> {quote}
> A Decision Service is represented in a DRD as rectangle with rounded corners, drawn with a heavy solid border.... the Decision Service SHALL be divided into two parts with a straight solid line.
> {quote}
> We are currently adding support for the _expanded_ form however we will also require (at some stage) a Palette glyph/icon and Canvas shape for the _collapsed_ form too.
--
This message was sent by Atlassian Jira
(v7.12.1#712002)
7 years, 6 months
[JBoss JIRA] (DROOLS-3373) [DMN Designer] Need Palette glyph/icon and Canvas shape for Decision Service
by Michael Anstis (Jira)
[ https://issues.jboss.org/browse/DROOLS-3373?page=com.atlassian.jira.plugi... ]
Michael Anstis updated DROOLS-3373:
-----------------------------------
Attachment: (was: Screenshot from 2019-01-11 12-37-52.png)
> [DMN Designer] Need Palette glyph/icon and Canvas shape for Decision Service
> ----------------------------------------------------------------------------
>
> Key: DROOLS-3373
> URL: https://issues.jboss.org/browse/DROOLS-3373
> Project: Drools
> Issue Type: Feature Request
> Components: DMN Editor
> Affects Versions: 7.15.0.Final
> Reporter: Michael Anstis
> Assignee: Michael Anstis
> Priority: Major
> Labels: VisualDesign, drools-tools, ux_needed, visualdesign
> Attachments: DMN_palette_icons.png, DecisionService-insitu.png, decision-service.svg, decision.svg, decision_palette.svg, decision_service_expanded_palette.svg, decision_service_palette.svg
>
>
> We need a new "Palette" icon and Canvas shape for "Decision Services".
> See Table 1: DRD components in the [DMN 1.2 Specification|https://www.omg.org/spec/DMN/1.2/Beta1/PDF].
> See also 6.2.5 Decision service for some narrative regarding the shape.
> {quote}
> A Decision Service is represented in a DRD as rectangle with rounded corners, drawn with a heavy solid border.... the Decision Service SHALL be divided into two parts with a straight solid line.
> {quote}
> We are currently adding support for the _expanded_ form however we will also require (at some stage) a Palette glyph/icon and Canvas shape for the _collapsed_ form too.
--
This message was sent by Atlassian Jira
(v7.12.1#712002)
7 years, 6 months
[JBoss JIRA] (WFCORE-4276) Audit and if possible eliminate overrides of SimpleResourceDefinition.registerCapabilities
by Jeff Mesnil (Jira)
[ https://issues.jboss.org/browse/WFCORE-4276?page=com.atlassian.jira.plugi... ]
Jeff Mesnil moved WFLY-11589 to WFCORE-4276:
--------------------------------------------
Project: WildFly Core (was: WildFly)
Key: WFCORE-4276 (was: WFLY-11589)
Component/s: Management
(was: Management)
> Audit and if possible eliminate overrides of SimpleResourceDefinition.registerCapabilities
> ------------------------------------------------------------------------------------------
>
> Key: WFCORE-4276
> URL: https://issues.jboss.org/browse/WFCORE-4276
> Project: WildFly Core
> Issue Type: Task
> Components: Management
> Reporter: Brian Stansberry
> Assignee: Jeff Mesnil
> Priority: Major
>
> Overriding SimpleResourceDefinition.registerCapabilities is risky because if the superclass impl is not called, any caps registered in any Parameters object passed to the constructor will not be registered. Since we are tending to move using Parameters, leaving custom overrides around is a potential bug source. This is what happened with WFLY-11587.
> In many cases the registerCapabilities override is just doing what using Parameters would have done, so this task is basically to upgrade this code. If there's some specific reason why an override is still needed in some class, that's ok, but then consideration should be given to also calling the superclass impl, if it's not already being done.
--
This message was sent by Atlassian Jira
(v7.12.1#712002)
7 years, 6 months
[JBoss JIRA] (WFLY-11589) Audit and if possible eliminate overrides of SimpleResourceDefinition.registerCapabilities
by Jeff Mesnil (Jira)
Jeff Mesnil created WFLY-11589:
----------------------------------
Summary: Audit and if possible eliminate overrides of SimpleResourceDefinition.registerCapabilities
Key: WFLY-11589
URL: https://issues.jboss.org/browse/WFLY-11589
Project: WildFly
Issue Type: Task
Components: Management
Reporter: Brian Stansberry
Assignee: Jeff Mesnil
Overriding SimpleResourceDefinition.registerCapabilities is risky because if the superclass impl is not called, any caps registered in any Parameters object passed to the constructor will not be registered. Since we are tending to move using Parameters, leaving custom overrides around is a potential bug source. This is what happened with WFLY-11587.
In many cases the registerCapabilities override is just doing what using Parameters would have done, so this task is basically to upgrade this code. If there's some specific reason why an override is still needed in some class, that's ok, but then consideration should be given to also calling the superclass impl, if it's not already being done.
--
This message was sent by Atlassian Jira
(v7.12.1#712002)
7 years, 6 months
[JBoss JIRA] (JBRULES-3484) Redundancy check option not working in Drools Verifier
by Toni Rikkola (Jira)
[ https://issues.jboss.org/browse/JBRULES-3484?page=com.atlassian.jira.plug... ]
Toni Rikkola closed JBRULES-3484.
---------------------------------
Resolution: Out of Date
> Redundancy check option not working in Drools Verifier
> ------------------------------------------------------
>
> Key: JBRULES-3484
> URL: https://issues.jboss.org/browse/JBRULES-3484
> Project: JBRULES
> Issue Type: Bug
> Components: drools-verifier
> Affects Versions: 5.3.0.Final
> Environment: Apache Tomcat 7.0, Windows 7
> Reporter: Prasanna Venkataraman
> Assignee: Toni Rikkola
> Priority: Major
> Labels: new_and_noteworthy, not, verifier
>
> I am using Drools-Verifier to validate the rules for any redundancy. I have explicitly given the redundant rule to test it. But I didn t get any warning stated that there are duplicate rules.
> I did some research and found that the dependent rules "Find Literal restriction" and "Find Variable restriction" are being removed (file org/drools/redundancy/restriction.drl).
> Kindly fix the issue so that we can continue with Drools-Verifier.
> Thanks,
> Prasanna.
--
This message was sent by Atlassian Jira
(v7.12.1#712002)
7 years, 6 months