[JBoss JIRA] (DROOLS-1791) ConditionInspectors for guided DT editor don't do checks for all allowed operators
by Toni Rikkola (Jira)
[ https://issues.jboss.org/browse/DROOLS-1791?page=com.atlassian.jira.plugi... ]
Toni Rikkola closed DROOLS-1791.
--------------------------------
Resolution: Won't Do
> ConditionInspectors for guided DT editor don't do checks for all allowed operators
> ----------------------------------------------------------------------------------
>
> Key: DROOLS-1791
> URL: https://issues.jboss.org/browse/DROOLS-1791
> Project: Drools
> Issue Type: Enhancement
> Components: Guided Decision Table Editor
> Reporter: Zuzka Krejčová
> Assignee: Toni Rikkola
> Priority: Minor
> Labels: reported-by-qe, verifier
>
> For String fields, guided DT editor allows the following operators:
> ==, !=, <, >, <=, >=, matches, soundslike, == null, != null, in, not in
> StringConditionInspector pretty much only checks if the operator is ==, != or 'in'.
> This means that some issues won't be detected (Validation and Verification for Decision Tables). E.g. for rules/conditions like 'str > "a"' and 'str > "c"', the subsumption won't be detected (but a fact instance with str == "x" will fire both rules).
> ComparableConditionInspector checks for ==, !=, <, >, <=, >= ops, but:
> for Dates, guided DT editor allows:
> ==, !=, <, >, <=, >=, == null, != null, in, not in, after, before, coincides
> for numerical types, guided DT editor allows:
> ==, !=, <, >, <=, >=, == null, != null, in, not in
--
This message was sent by Atlassian Jira
(v7.12.1#712002)
7 years, 6 months
[JBoss JIRA] (DROOLS-1791) ConditionInspectors for guided DT editor don't do checks for all allowed operators
by Toni Rikkola (Jira)
[ https://issues.jboss.org/browse/DROOLS-1791?page=com.atlassian.jira.plugi... ]
Toni Rikkola updated DROOLS-1791:
---------------------------------
Issue Type: Enhancement (was: Bug)
> ConditionInspectors for guided DT editor don't do checks for all allowed operators
> ----------------------------------------------------------------------------------
>
> Key: DROOLS-1791
> URL: https://issues.jboss.org/browse/DROOLS-1791
> Project: Drools
> Issue Type: Enhancement
> Components: Guided Decision Table Editor
> Reporter: Zuzka Krejčová
> Assignee: Toni Rikkola
> Priority: Minor
> Labels: reported-by-qe, verifier
>
> For String fields, guided DT editor allows the following operators:
> ==, !=, <, >, <=, >=, matches, soundslike, == null, != null, in, not in
> StringConditionInspector pretty much only checks if the operator is ==, != or 'in'.
> This means that some issues won't be detected (Validation and Verification for Decision Tables). E.g. for rules/conditions like 'str > "a"' and 'str > "c"', the subsumption won't be detected (but a fact instance with str == "x" will fire both rules).
> ComparableConditionInspector checks for ==, !=, <, >, <=, >= ops, but:
> for Dates, guided DT editor allows:
> ==, !=, <, >, <=, >=, == null, != null, in, not in, after, before, coincides
> for numerical types, guided DT editor allows:
> ==, !=, <, >, <=, >=, == null, != null, in, not in
--
This message was sent by Atlassian Jira
(v7.12.1#712002)
7 years, 6 months
[JBoss JIRA] (DROOLS-1818) Guided Decision Table V&V reporting - Analysis panel visual improvements
by Toni Rikkola (Jira)
[ https://issues.jboss.org/browse/DROOLS-1818?page=com.atlassian.jira.plugi... ]
Toni Rikkola closed DROOLS-1818.
--------------------------------
Resolution: Won't Do
> Guided Decision Table V&V reporting - Analysis panel visual improvements
> ------------------------------------------------------------------------
>
> Key: DROOLS-1818
> URL: https://issues.jboss.org/browse/DROOLS-1818
> Project: Drools
> Issue Type: Enhancement
> Components: Guided Decision Table Editor
> Reporter: Zuzka Krejčová
> Assignee: Toni Rikkola
> Priority: Major
> Labels: reported-by-qe, verifier
>
> The part of the panel with the issue description has a 60px padding - this is a bit too much. It leaves less space for the actual text, which then often has to be scrolled.
> There is also an unusual line-height of 30px for a font-size of 18px. This makes the text hog even more space, quite unnecessarily.
> The 'Affected rows' line blends in with the description itself. It could do with a pixel or two (or 5) more of space underneath - together with the removal the 30px line-height, this could set it nicely apart without disrupting anything else.
> There are only 5 rows of issues displayed in the top part of the Analysis panel, but even in small guided DTs, there can easily be many more issues. Giving this part more space should be easier after resolving the points above.
--
This message was sent by Atlassian Jira
(v7.12.1#712002)
7 years, 6 months
[JBoss JIRA] (DROOLS-1794) GDTable V&V reporting not working with numeric (optional) value lists
by Toni Rikkola (Jira)
[ https://issues.jboss.org/browse/DROOLS-1794?page=com.atlassian.jira.plugi... ]
Toni Rikkola commented on DROOLS-1794:
--------------------------------------
[~jomarko] Not sure if this is still an issue.
> GDTable V&V reporting not working with numeric (optional) value lists
> ---------------------------------------------------------------------
>
> Key: DROOLS-1794
> URL: https://issues.jboss.org/browse/DROOLS-1794
> Project: Drools
> Issue Type: Bug
> Components: Guided Decision Table Editor
> Reporter: Zuzka Krejčová
> Assignee: Toni Rikkola
> Priority: Major
> Labels: reported-by-qe, verifier
>
> If a column uses (optional) value list to restrict possible _numeric_ values, some issues won't be reported, others are "wonky".
> My guess is the values in the (optional) value list are interpreted as String rather than the correct field type (e.g. int).
> (See 'Steps to Reproduce' for more detailed info.)
--
This message was sent by Atlassian Jira
(v7.12.1#712002)
7 years, 6 months
[JBoss JIRA] (WFCORE-4275) SuspendOnSoftKillTestCase fails sometimes
by Yeray Borges (Jira)
[ https://issues.jboss.org/browse/WFCORE-4275?page=com.atlassian.jira.plugi... ]
Yeray Borges reassigned WFCORE-4275:
------------------------------------
Assignee: Yeray Borges
> SuspendOnSoftKillTestCase fails sometimes
> -----------------------------------------
>
> Key: WFCORE-4275
> URL: https://issues.jboss.org/browse/WFCORE-4275
> Project: WildFly Core
> Issue Type: Bug
> Components: Test Suite
> Affects Versions: 8.0.0.Beta2
> Reporter: Richard Opalka
> Assignee: Yeray Borges
> Priority: Major
> Fix For: 8.0.0.Beta3
>
>
> [INFO] Running org.jboss.as.test.manualmode.suspend.SuspendOnSoftKillTestCase
> [ERROR] Tests run: 2, Failures: 1, Errors: 0, Skipped: 0, Time elapsed: 19.685 s <<< FAILURE! - in org.jboss.as.test.manualmode.suspend.SuspendOnSoftKillTestCase
> [ERROR] testSuspendOnSoftKillNegativeTimeout(org.jboss.as.test.manualmode.suspend.SuspendOnSoftKillTestCase) Time elapsed: 5.144 s <<< FAILURE!
> org.junit.ComparisonFailure: expected:<SUSPEND[ED]> but was:<SUSPEND[ING]>
> at org.junit.Assert.assertEquals(Assert.java:115)
> at org.junit.Assert.assertEquals(Assert.java:144)
> at org.jboss.as.test.manualmode.suspend.SuspendOnSoftKillTestCase.suspendOnSoftKillTest(SuspendOnSoftKillTestCase.java:228)
> at org.jboss.as.test.manualmode.suspend.SuspendOnSoftKillTestCase.testSuspendOnSoftKillNegativeTimeout(SuspendOnSoftKillTestCase.java:126)
> at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
> at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
> at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
> at java.lang.reflect.Method.invoke(Method.java:498)
> at org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(FrameworkMethod.java:50)
> at org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:12)
> at org.junit.runners.model.FrameworkMethod.invokeExplosively(FrameworkMethod.java:47)
> at org.junit.internal.runners.statements.InvokeMethod.evaluate(InvokeMethod.java:17)
> at org.junit.internal.runners.statements.RunAfters.evaluate(RunAfters.java:27)
> at org.junit.runners.ParentRunner.runLeaf(ParentRunner.java:325)
> at org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:78)
> at org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:57)
> at org.junit.runners.ParentRunner$3.run(ParentRunner.java:290)
> at org.junit.runners.ParentRunner$1.schedule(ParentRunner.java:71)
> at org.junit.runners.ParentRunner.runChildren(ParentRunner.java:288)
> at org.junit.runners.ParentRunner.access$000(ParentRunner.java:58)
> at org.junit.runners.ParentRunner$2.evaluate(ParentRunner.java:268)
> at org.junit.internal.runners.statements.RunAfters.evaluate(RunAfters.java:27)
> at org.junit.runners.ParentRunner.run(ParentRunner.java:363)
> at org.wildfly.core.testrunner.WildflyTestRunner.run(WildflyTestRunner.java:109)
> at org.junit.runners.Suite.runChild(Suite.java:128)
> at org.junit.runners.Suite.runChild(Suite.java:27)
> at org.junit.runners.ParentRunner$3.run(ParentRunner.java:290)
> at org.junit.runners.ParentRunner$1.schedule(ParentRunner.java:71)
> at org.junit.runners.ParentRunner.runChildren(ParentRunner.java:288)
> at org.junit.runners.ParentRunner.access$000(ParentRunner.java:58)
> at org.junit.runners.ParentRunner$2.evaluate(ParentRunner.java:268)
> at org.junit.runners.ParentRunner.run(ParentRunner.java:363)
> at org.apache.maven.surefire.junitcore.JUnitCore.run(JUnitCore.java:55)
> at org.apache.maven.surefire.junitcore.JUnitCoreWrapper.createRequestAndRun(JUnitCoreWrapper.java:137)
> at org.apache.maven.surefire.junitcore.JUnitCoreWrapper.executeEager(JUnitCoreWrapper.java:107)
> at org.apache.maven.surefire.junitcore.JUnitCoreWrapper.execute(JUnitCoreWrapper.java:83)
> at org.apache.maven.surefire.junitcore.JUnitCoreWrapper.execute(JUnitCoreWrapper.java:75)
> at org.apache.maven.surefire.junitcore.JUnitCoreProvider.invoke(JUnitCoreProvider.java:158)
> at org.apache.maven.surefire.booter.ForkedBooter.invokeProviderInSameClassLoader(ForkedBooter.java:383)
> at org.apache.maven.surefire.booter.ForkedBooter.runSuitesInProcess(ForkedBooter.java:344)
> at org.apache.maven.surefire.booter.ForkedBooter.execute(ForkedBooter.java:125)
> at org.apache.maven.surefire.booter.ForkedBooter.main(ForkedBooter.java:417)
--
This message was sent by Atlassian Jira
(v7.12.1#712002)
7 years, 6 months
[JBoss JIRA] (DROOLS-1794) GDTable V&V reporting not working with numeric (optional) value lists
by Toni Rikkola (Jira)
[ https://issues.jboss.org/browse/DROOLS-1794?page=com.atlassian.jira.plugi... ]
Toni Rikkola updated DROOLS-1794:
---------------------------------
Priority: Critical (was: Major)
> GDTable V&V reporting not working with numeric (optional) value lists
> ---------------------------------------------------------------------
>
> Key: DROOLS-1794
> URL: https://issues.jboss.org/browse/DROOLS-1794
> Project: Drools
> Issue Type: Bug
> Components: Guided Decision Table Editor
> Reporter: Zuzka Krejčová
> Assignee: Toni Rikkola
> Priority: Critical
> Labels: reported-by-qe, verifier
>
> If a column uses (optional) value list to restrict possible _numeric_ values, some issues won't be reported, others are "wonky".
> My guess is the values in the (optional) value list are interpreted as String rather than the correct field type (e.g. int).
> (See 'Steps to Reproduce' for more detailed info.)
--
This message was sent by Atlassian Jira
(v7.12.1#712002)
7 years, 6 months
[JBoss JIRA] (DROOLS-1814) Guided Decision Table V&V reporting - detect redundancy for rows differing only in bound vars
by Toni Rikkola (Jira)
[ https://issues.jboss.org/browse/DROOLS-1814?page=com.atlassian.jira.plugi... ]
Toni Rikkola closed DROOLS-1814.
--------------------------------
Resolution: Won't Do
> Guided Decision Table V&V reporting - detect redundancy for rows differing only in bound vars
> ---------------------------------------------------------------------------------------------
>
> Key: DROOLS-1814
> URL: https://issues.jboss.org/browse/DROOLS-1814
> Project: Drools
> Issue Type: Enhancement
> Components: Guided Decision Table Editor
> Reporter: Zuzka Krejčová
> Assignee: Toni Rikkola
> Priority: Minor
> Labels: reported-by-qe, verifier
>
> The following 2 rows/rules from one GDT are redundant but not detected as such. The reason is that one operates with a fact bound to variable 'p', the other binds the same fact to variable 'q'. It would be nice, if things like this were detected as well.
> rule "Row 1 asd"
> when
> p : Person( age > 0 )
> then
> p.setSth( 0 );
> end
> rule "Row 2 asd"
> when
> q : Person( age > 0 )
> then
> q.setSth( 0 );
> end
--
This message was sent by Atlassian Jira
(v7.12.1#712002)
7 years, 6 months