[JBoss JIRA] (DROOLS-1800) Verification & Validation: Subsumption not picked up correctly
by Toni Rikkola (Jira)
[ https://issues.jboss.org/browse/DROOLS-1800?page=com.atlassian.jira.plugi... ]
Toni Rikkola closed DROOLS-1800.
--------------------------------
Resolution: Won't Do
> Verification & Validation: Subsumption not picked up correctly
> --------------------------------------------------------------
>
> Key: DROOLS-1800
> URL: https://issues.jboss.org/browse/DROOLS-1800
> Project: Drools
> Issue Type: Bug
> Components: Guided Decision Table Editor
> Reporter: Toni Rikkola
> Assignee: Toni Rikkola
> Priority: Major
> Labels: verifier
>
> Example 1
> Rule1: when (attr1 == 'value11' , att2 == 'value22') then <something>
> Rule2: when (attr1 == 'value11' , att2 == 'value22') then <something>
> it will throw an error saying conflicting rules but when we have a attr like age where we want to match minAge and maxAge it dosen't detect a conflict properly.
> Example 2
> Rule1: when (minAge > '18' , maxAge < '50') then <something>
> Rule2: when (minAge > '25' , maxAge < '35') then <something>
> In the above example 2 age 30 will match both the rules but there is no conflict detected
--
This message was sent by Atlassian Jira
(v7.12.1#712002)
7 years, 6 months
[JBoss JIRA] (DROOLS-1807) Verification & Validation: Add three states for running the validation
by Toni Rikkola (Jira)
[ https://issues.jboss.org/browse/DROOLS-1807?page=com.atlassian.jira.plugi... ]
Toni Rikkola updated DROOLS-1807:
---------------------------------
Sprint: 2019 Week 02-04
> Verification & Validation: Add three states for running the validation
> -----------------------------------------------------------------------
>
> Key: DROOLS-1807
> URL: https://issues.jboss.org/browse/DROOLS-1807
> Project: Drools
> Issue Type: Enhancement
> Components: Guided Decision Table Editor
> Reporter: Anton Giertli
> Assignee: Toni Rikkola
> Priority: Major
> Labels: drools-tools, verifier
>
> The statuses would be managed with system properties and extend the current on/off switch we have.
> It will be possible to change the status for each validation check type. Check types are for example redundancy, range, missing columns.
>
> * Reactive
> The "normal way" you make a change and the verification runs instantly
> * Off
> Verification is disabled
> * On demand
> Verification only runs when requested. Can be useful for large dtables where you for example change every value in a column and just really care about the verification status after all the changes.
> Few ideas to think about:
> # Might be worth it to also store the state per dtable.
> # If V&V runs for over X amount of seconds. Ask if the user wants to change the setting from "Reactive" to "On Demand" for this table.
--
This message was sent by Atlassian Jira
(v7.12.1#712002)
7 years, 6 months
[JBoss JIRA] (DROOLS-1826) Guided Decision Table V&V: Overlaps
by Toni Rikkola (Jira)
[ https://issues.jboss.org/browse/DROOLS-1826?page=com.atlassian.jira.plugi... ]
Toni Rikkola updated DROOLS-1826:
---------------------------------
Priority: Optional (was: Major)
> Guided Decision Table V&V: Overlaps
> -----------------------------------
>
> Key: DROOLS-1826
> URL: https://issues.jboss.org/browse/DROOLS-1826
> Project: Drools
> Issue Type: Enhancement
> Components: Guided Decision Table Editor
> Reporter: Toni Rikkola
> Assignee: Toni Rikkola
> Priority: Optional
> Labels: verifier
>
> This will be needed by Unique hit to resolve if table is in fact Unique Singe hit.
> We already resolve subsumption. Meaning all the possible values that row A can take also satisfy B.
> Subsumption does not cover overlapping rows. Where a set of given values that fire A also fire B, but both rules have a range of given values that only fire A or B.
> h6. For example
> || Person.age || Application.approve ||
> | 0 - 50 | yes |
> | 40 - 100 | no |
> If age is between 40 and 50 both rules fire and it is impossible to say if the rule is approved or not.
--
This message was sent by Atlassian Jira
(v7.12.1#712002)
7 years, 6 months
[JBoss JIRA] (DROOLS-1824) Guided Decision Table V&V - Make the V&V pick up salience & activation-group
by Jozef Marko (Jira)
[ https://issues.jboss.org/browse/DROOLS-1824?page=com.atlassian.jira.plugi... ]
Jozef Marko updated DROOLS-1824:
--------------------------------
Tester: Jozef Marko
> Guided Decision Table V&V - Make the V&V pick up salience & activation-group
> ----------------------------------------------------------------------------
>
> Key: DROOLS-1824
> URL: https://issues.jboss.org/browse/DROOLS-1824
> Project: Drools
> Issue Type: Enhancement
> Components: Guided Decision Table Editor
> Reporter: Toni Rikkola
> Assignee: Toni Rikkola
> Priority: Optional
> Labels: verifier
>
> Either the one set in the table or the ones added with code generation based on Hit Policy.
> Made the ticket, but not sure if salience changes anything with what we resolve at the moment. It does affect loop detection, but we do not handle that at the moment
> * If two rules are subsumptant. The order of the rows does not matter, they are still subsumptant
> * If two rules are in conflict. The order does not matter.
> Saliance with activation-group however does change things.
> * If a rule's LHS with a higher priority subsumes a rule with a lower priority. The lower row never fires.
> * We do not care about conflicting rows in activation-group
> Due to PHREAK, we always have top to down salience or a salience set by the user.
--
This message was sent by Atlassian Jira
(v7.12.1#712002)
7 years, 6 months
[JBoss JIRA] (DROOLS-1826) Guided Decision Table V&V: Overlaps
by Toni Rikkola (Jira)
[ https://issues.jboss.org/browse/DROOLS-1826?page=com.atlassian.jira.plugi... ]
Toni Rikkola closed DROOLS-1826.
--------------------------------
Resolution: Won't Do
> Guided Decision Table V&V: Overlaps
> -----------------------------------
>
> Key: DROOLS-1826
> URL: https://issues.jboss.org/browse/DROOLS-1826
> Project: Drools
> Issue Type: Enhancement
> Components: Guided Decision Table Editor
> Reporter: Toni Rikkola
> Assignee: Toni Rikkola
> Priority: Optional
> Labels: verifier
>
> This will be needed by Unique hit to resolve if table is in fact Unique Singe hit.
> We already resolve subsumption. Meaning all the possible values that row A can take also satisfy B.
> Subsumption does not cover overlapping rows. Where a set of given values that fire A also fire B, but both rules have a range of given values that only fire A or B.
> h6. For example
> || Person.age || Application.approve ||
> | 0 - 50 | yes |
> | 40 - 100 | no |
> If age is between 40 and 50 both rules fire and it is impossible to say if the rule is approved or not.
--
This message was sent by Atlassian Jira
(v7.12.1#712002)
7 years, 6 months
[JBoss JIRA] (DROOLS-1824) Guided Decision Table V&V - Make the V&V pick up salience & activation-group
by Toni Rikkola (Jira)
[ https://issues.jboss.org/browse/DROOLS-1824?page=com.atlassian.jira.plugi... ]
Toni Rikkola updated DROOLS-1824:
---------------------------------
Priority: Optional (was: Major)
> Guided Decision Table V&V - Make the V&V pick up salience & activation-group
> ----------------------------------------------------------------------------
>
> Key: DROOLS-1824
> URL: https://issues.jboss.org/browse/DROOLS-1824
> Project: Drools
> Issue Type: Enhancement
> Components: Guided Decision Table Editor
> Reporter: Toni Rikkola
> Assignee: Toni Rikkola
> Priority: Optional
> Labels: verifier
>
> Either the one set in the table or the ones added with code generation based on Hit Policy.
> Made the ticket, but not sure if salience changes anything with what we resolve at the moment. It does affect loop detection, but we do not handle that at the moment
> * If two rules are subsumptant. The order of the rows does not matter, they are still subsumptant
> * If two rules are in conflict. The order does not matter.
> Saliance with activation-group however does change things.
> * If a rule's LHS with a higher priority subsumes a rule with a lower priority. The lower row never fires.
> * We do not care about conflicting rows in activation-group
> Due to PHREAK, we always have top to down salience or a salience set by the user.
--
This message was sent by Atlassian Jira
(v7.12.1#712002)
7 years, 6 months
[JBoss JIRA] (DROOLS-1868) [Guided Decision Table] Empty Row message erases some other
by Toni Rikkola (Jira)
[ https://issues.jboss.org/browse/DROOLS-1868?page=com.atlassian.jira.plugi... ]
Toni Rikkola commented on DROOLS-1868:
--------------------------------------
[~jomarko] The question here does the last line generate MockObject() in DRL or not. If it does then that pattern covers all the ranges.
> [Guided Decision Table] Empty Row message erases some other
> -----------------------------------------------------------
>
> Key: DROOLS-1868
> URL: https://issues.jboss.org/browse/DROOLS-1868
> Project: Drools
> Issue Type: Sub-task
> Components: Guided Decision Table Editor
> Affects Versions: 7.0.0.Beta6
> Reporter: Jozef Marko
> Assignee: Toni Rikkola
> Priority: Minor
> Labels: dtable_testday_preparation, qe-test-day, reported-by-qe, verifier
> Attachments: attachment1.png, attachment2.png
>
>
> Occurrence of "Rule is Empty" validation messages erases others. For example "Missing Range" is erased from validation messages if "Rule is Empty" occurs.
> Steps for reproduce:
> # Create new decision table that will contain "Missing Range" validation messages
> ** see the attachment1
> # Add new row into the table
> ** see the attachment2
--
This message was sent by Atlassian Jira
(v7.12.1#712002)
7 years, 6 months
[JBoss JIRA] (DROOLS-3514) [DMN Designer] Feel autocomplete, sintax highlighting and type checking.
by Thomas Mantegazzi (Jira)
[ https://issues.jboss.org/browse/DROOLS-3514?page=com.atlassian.jira.plugi... ]
Thomas Mantegazzi commented on DROOLS-3514:
-------------------------------------------
Do you already know a rough "timeline"? Do you have a "Story" or "epic" that I can follow to know the status of this? If yes we can close this issue.
> [DMN Designer] Feel autocomplete, sintax highlighting and type checking.
> ------------------------------------------------------------------------
>
> Key: DROOLS-3514
> URL: https://issues.jboss.org/browse/DROOLS-3514
> Project: Drools
> Issue Type: Feature Request
> Components: DMN Editor
> Affects Versions: 7.15.0.Final
> Reporter: Thomas Mantegazzi
> Assignee: Michael Anstis
> Priority: Major
> Labels: drools-tools
> Attachments: image-2019-01-14-09-16-09-474.png, image-2019-01-14-09-16-30-813.png, image-2019-01-14-09-17-20-451.png
>
>
> When trying to write decisions, it would be nice to have some sintax highlighting, and autocomplete based on the inputs provided to the decision in the DRG.
> DRG:
> !image-2019-01-14-09-16-09-474.png|thumbnail!
> Data type:
> !image-2019-01-14-09-16-30-813.png|thumbnail!
> Feel expression:
> !image-2019-01-14-09-17-20-451.png|thumbnail!
> In this case, it would be nice that when we write "p" we get the suggestion "person".
> It would also be nice to get type checking, so that if we declare a DMN decision to have output of type : "number" we can not write a literal expression that outputs a String.
--
This message was sent by Atlassian Jira
(v7.12.1#712002)
7 years, 6 months