January 2019 - jboss-jira - Jboss List Archives

[JBoss JIRA] (DROOLS-2227) Verifier should manage predicate columns properly

by Toni Rikkola (Jira)

[ https://issues.jboss.org/browse/DROOLS-2227?page=com.atlassian.jira.plugi... ] Toni Rikkola closed DROOLS-2227. -------------------------------- Resolution: Explained > Verifier should manage predicate columns properly > ------------------------------------------------- > > Key: DROOLS-2227 > URL: https://issues.jboss.org/browse/DROOLS-2227 > Project: Drools > Issue Type: Enhancement > Components: Guided Decision Table Editor > Reporter: Toni Rikkola > Assignee: Toni Rikkola > Priority: Minor > Labels: verifier > > < Rikkola> for dtables, string comparison is probably enough, > prooobably > < Rikkola> and when I type that nope > < Rikkola> eval( 1+1) and eval( 0+2) are the same, but no way to know > < Rikkola> maybe a warning when columns like this are used, the V&V might > not pick everything up -- This message was sent by Atlassian Jira (v7.12.1#712002)

7 years, 6 months

1
0
0 / 0

[JBoss JIRA] (DROOLS-2227) Verifier should manage predicate columns properly

by Toni Rikkola (Jira)

[ https://issues.jboss.org/browse/DROOLS-2227?page=com.atlassian.jira.plugi... ] Toni Rikkola commented on DROOLS-2227: -------------------------------------- This makes to actually run the rules to get this done. > Verifier should manage predicate columns properly > ------------------------------------------------- > > Key: DROOLS-2227 > URL: https://issues.jboss.org/browse/DROOLS-2227 > Project: Drools > Issue Type: Enhancement > Components: Guided Decision Table Editor > Reporter: Toni Rikkola > Assignee: Toni Rikkola > Priority: Minor > Labels: verifier > > < Rikkola> for dtables, string comparison is probably enough, > prooobably > < Rikkola> and when I type that nope > < Rikkola> eval( 1+1) and eval( 0+2) are the same, but no way to know > < Rikkola> maybe a warning when columns like this are used, the V&V might > not pick everything up -- This message was sent by Atlassian Jira (v7.12.1#712002)

7 years, 6 months

1
0
0 / 0

[JBoss JIRA] (DROOLS-2227) Verifier should manage predicate columns properly

by Toni Rikkola (Jira)

[ https://issues.jboss.org/browse/DROOLS-2227?page=com.atlassian.jira.plugi... ] Toni Rikkola updated DROOLS-2227: --------------------------------- Priority: Minor (was: Major) > Verifier should manage predicate columns properly > ------------------------------------------------- > > Key: DROOLS-2227 > URL: https://issues.jboss.org/browse/DROOLS-2227 > Project: Drools > Issue Type: Enhancement > Components: Guided Decision Table Editor > Reporter: Toni Rikkola > Assignee: Toni Rikkola > Priority: Minor > Labels: verifier > > < Rikkola> for dtables, string comparison is probably enough, > prooobably > < Rikkola> and when I type that nope > < Rikkola> eval( 1+1) and eval( 0+2) are the same, but no way to know > < Rikkola> maybe a warning when columns like this are used, the V&V might > not pick everything up -- This message was sent by Atlassian Jira (v7.12.1#712002)

7 years, 6 months

1
0
0 / 0

[JBoss JIRA] (DROOLS-2492) Analysis right panel doesn't close after exiting guided decision table asset view

by Toni Rikkola (Jira)

[ https://issues.jboss.org/browse/DROOLS-2492?page=com.atlassian.jira.plugi... ] Toni Rikkola commented on DROOLS-2492: -------------------------------------- Also broken on DMN and Scesim editors in the same scenario. Probably a bug in libary, appformer level > Analysis right panel doesn't close after exiting guided decision table asset view > --------------------------------------------------------------------------------- > > Key: DROOLS-2492 > URL: https://issues.jboss.org/browse/DROOLS-2492 > Project: Drools > Issue Type: Bug > Components: Guided Decision Table Editor > Reporter: Sree Hitha Gudimella > Assignee: Toni Rikkola > Priority: Major > Labels: verifier > Attachments: Screen Shot 2018-04-23 at 10.35.20 AM.png, Screen Shot 2018-04-23 at 10.35.34 AM.png > > > Analysis panel that appears on the right while editing a guided decision table asset doesn't close by default after navigating to assets list view. -- This message was sent by Atlassian Jira (v7.12.1#712002)

7 years, 6 months

1
0
0 / 0

[JBoss JIRA] (WFLY-11587) org.jboss.as.weld has optional dependency on org.jboss.as.security which causes regression

by Matej Novotny (Jira)

[ https://issues.jboss.org/browse/WFLY-11587?page=com.atlassian.jira.plugin... ] Matej Novotny commented on WFLY-11587: -------------------------------------- bq. Adding 'optional="true"' to the module.xml files is not likely the issue. Yea, sorry I wasn't thorough in issue description, this alone wasn't the cause indeed. bq. Matej Novotny https://github.com/wildfly/wildfly/pull/11996 is a likely fix, ... Yes, I can confirm this fixes the issue. > org.jboss.as.weld has optional dependency on org.jboss.as.security which causes regression > ------------------------------------------------------------------------------------------ > > Key: WFLY-11587 > URL: https://issues.jboss.org/browse/WFLY-11587 > Project: WildFly > Issue Type: Bug > Components: CDI / Weld, Security > Affects Versions: 15.0.1.Final > Reporter: Matej Novotny > Assignee: Matej Novotny > Priority: Major > Fix For: 16.0.0.Beta1 > > > This is originally reported on forums, see [this|https://developer.jboss.org/thread/279444] link. > The post contains a nice reproducer (which should be turned into automated test) along with steps to reproduce. > The original cause is WFLY-11125 where Weld's dependency on {{org.jboss.as.security}} changed from mandatory to optional. This causes failures when using {{@Inject Principal}}. -- This message was sent by Atlassian Jira (v7.12.1#712002)

7 years, 6 months

1
0
0 / 0

[JBoss JIRA] (DROOLS-2751) Workbench does not show correct message for DecisionTables with variables out of range

by Jozef Marko (Jira)

[ https://issues.jboss.org/browse/DROOLS-2751?page=com.atlassian.jira.plugi... ] Jozef Marko updated DROOLS-2751: -------------------------------- Tester: Jozef Marko > Workbench does not show correct message for DecisionTables with variables out of range > -------------------------------------------------------------------------------------- > > Key: DROOLS-2751 > URL: https://issues.jboss.org/browse/DROOLS-2751 > Project: Drools > Issue Type: Bug > Components: decision tables, Guided Decision Table Editor > Affects Versions: 7.8.0.Final > Reporter: Alessandro Lazarotti > Assignee: Toni Rikkola > Priority: Critical > Labels: verifier > Attachments: 1-decision-table.png, 2-dt-source.png, 3-workbench-message.png, Applicant Annual Income.png, MortgageDecisionTable.gdst, Property.png > > > When it is defined a Decision Table with rows don't covering all possible ranges, the message reported by workbench isn't clear, in fact it is a wrong message: > "Deficient row. > Affected rows:1 > "Deficient rule has *actions which conflict with another rule* and conditions that do not overlap with the other rule." > "Since *the deficient rule can fire at the same time as an another rule*, it is impossible to know which actions end up activating last. This causes the rule set to be inconsistent. To fix this, please either remove the deficient rule or make the conditions more strict." > The message above seems generic for cases that two rules can fire while it is expect them to be exclusive, but it is confuse for rows out-of-range. > See attachments. -- This message was sent by Atlassian Jira (v7.12.1#712002)

7 years, 6 months

1
0
0 / 0

[JBoss JIRA] (DROOLS-2751) Workbench does not show correct message for DecisionTables with variables out of range

by Toni Rikkola (Jira)

[ https://issues.jboss.org/browse/DROOLS-2751?page=com.atlassian.jira.plugi... ] Toni Rikkola updated DROOLS-2751: --------------------------------- Priority: Critical (was: Major) > Workbench does not show correct message for DecisionTables with variables out of range > -------------------------------------------------------------------------------------- > > Key: DROOLS-2751 > URL: https://issues.jboss.org/browse/DROOLS-2751 > Project: Drools > Issue Type: Bug > Components: decision tables, Guided Decision Table Editor > Affects Versions: 7.8.0.Final > Reporter: Alessandro Lazarotti > Assignee: Toni Rikkola > Priority: Critical > Labels: verifier > Attachments: 1-decision-table.png, 2-dt-source.png, 3-workbench-message.png, Applicant Annual Income.png, MortgageDecisionTable.gdst, Property.png > > > When it is defined a Decision Table with rows don't covering all possible ranges, the message reported by workbench isn't clear, in fact it is a wrong message: > "Deficient row. > Affected rows:1 > "Deficient rule has *actions which conflict with another rule* and conditions that do not overlap with the other rule." > "Since *the deficient rule can fire at the same time as an another rule*, it is impossible to know which actions end up activating last. This causes the rule set to be inconsistent. To fix this, please either remove the deficient rule or make the conditions more strict." > The message above seems generic for cases that two rules can fire while it is expect them to be exclusive, but it is confuse for rows out-of-range. > See attachments. -- This message was sent by Atlassian Jira (v7.12.1#712002)

7 years, 6 months

1
0
0 / 0

[JBoss JIRA] (DROOLS-2845) Extend the existing verifier to support DMN tables

by Toni Rikkola (Jira)

[ https://issues.jboss.org/browse/DROOLS-2845?page=com.atlassian.jira.plugi... ] Toni Rikkola commented on DROOLS-2845: -------------------------------------- [~tarilabs] Is there a BPAL jira for this or any DMN verifier work? > Extend the existing verifier to support DMN tables > -------------------------------------------------- > > Key: DROOLS-2845 > URL: https://issues.jboss.org/browse/DROOLS-2845 > Project: Drools > Issue Type: Epic > Components: DMN Editor, verifier > Reporter: Toni Rikkola > Assignee: Toni Rikkola > Priority: Optional > Labels: UX, drools-tools, verifier > > h1. Goal > Reuse the V&V created for Guided Decision Tables on the DMN tables. > h1. Workload divided to steps > I propose the work goes in the following steps. After each step I should be able to merge into master. > Steps: > # Move Verifier core to kie-wb-common > # Move V&V reporting UI to kie-wb-common > # Make the web worker connector reusable for different V&V types > # Make a servlet module for DMN that allows the download of the Web Worker. > # Create an adapter for DMN tables > # Add support for ranges ( these are given in DMN so no need to use JSR303 ) > # Duplicate i18n of the V&V for DMN or unify the reports so that the terms make sense > h1. Time and risks > h2. #1, #2, #3, #4 and #7 moving, copying code or doing refactoring > Most of the work items are just about moving, copying code or doing refactoring. These are easy to estimate and I think they are doable in one sprint along with everything else I do. Already started few of these so it is easier for me to estimate how long they take. > h2. 5. Create an adapter for DMN tables > Adapters job is to take the model ( DMN or dtable ) and tear it down into smaller bits that the Verifier actually inspects. The core Verifier basically only sees rules or rows as collections of conditions and actions. This is why I feel once the adapter is done, the verifier will automatically work for DMN tables. This adapter also keeps track of the cell to action/condition connections. > This area is where most of the work is that is hard to estimate, since there is some unknowns here. In theory DMN adapter is a lot easier to do than the DTable adapter was. Due to the unknown I will have to say 3 weeks. > h2. 6. Add support for ranges > Mario helped to get the range checks in order. The V&V now works with unlimited ranges, but adding known range limitation is in a way just about adding in the data of a mock rule that checks for the area that is outside of the range. I’ll play it safe here and say one week, but at the moment this feels really easy. > h1. Just to make it clear > This work only targets the DMN table in the similar format that it is in the Guided Decision Table. So it does not cover a Verification of the entire DMN diagram that can have several tables that possibly complete each other. We have the same situation if we have multiple DRL Tables in a ksession. -- This message was sent by Atlassian Jira (v7.12.1#712002)

7 years, 6 months

1
0
0 / 0

[JBoss JIRA] (DROOLS-2845) Extend the existing verifier to support DMN tables

by Toni Rikkola (Jira)

[ https://issues.jboss.org/browse/DROOLS-2845?page=com.atlassian.jira.plugi... ] Toni Rikkola updated DROOLS-2845: --------------------------------- Priority: Optional (was: Major) > Extend the existing verifier to support DMN tables > -------------------------------------------------- > > Key: DROOLS-2845 > URL: https://issues.jboss.org/browse/DROOLS-2845 > Project: Drools > Issue Type: Epic > Components: DMN Editor, verifier > Reporter: Toni Rikkola > Assignee: Toni Rikkola > Priority: Optional > Labels: UX, drools-tools, verifier > > h1. Goal > Reuse the V&V created for Guided Decision Tables on the DMN tables. > h1. Workload divided to steps > I propose the work goes in the following steps. After each step I should be able to merge into master. > Steps: > # Move Verifier core to kie-wb-common > # Move V&V reporting UI to kie-wb-common > # Make the web worker connector reusable for different V&V types > # Make a servlet module for DMN that allows the download of the Web Worker. > # Create an adapter for DMN tables > # Add support for ranges ( these are given in DMN so no need to use JSR303 ) > # Duplicate i18n of the V&V for DMN or unify the reports so that the terms make sense > h1. Time and risks > h2. #1, #2, #3, #4 and #7 moving, copying code or doing refactoring > Most of the work items are just about moving, copying code or doing refactoring. These are easy to estimate and I think they are doable in one sprint along with everything else I do. Already started few of these so it is easier for me to estimate how long they take. > h2. 5. Create an adapter for DMN tables > Adapters job is to take the model ( DMN or dtable ) and tear it down into smaller bits that the Verifier actually inspects. The core Verifier basically only sees rules or rows as collections of conditions and actions. This is why I feel once the adapter is done, the verifier will automatically work for DMN tables. This adapter also keeps track of the cell to action/condition connections. > This area is where most of the work is that is hard to estimate, since there is some unknowns here. In theory DMN adapter is a lot easier to do than the DTable adapter was. Due to the unknown I will have to say 3 weeks. > h2. 6. Add support for ranges > Mario helped to get the range checks in order. The V&V now works with unlimited ranges, but adding known range limitation is in a way just about adding in the data of a mock rule that checks for the area that is outside of the range. I’ll play it safe here and say one week, but at the moment this feels really easy. > h1. Just to make it clear > This work only targets the DMN table in the similar format that it is in the Guided Decision Table. So it does not cover a Verification of the entire DMN diagram that can have several tables that possibly complete each other. We have the same situation if we have multiple DRL Tables in a ksession. -- This message was sent by Atlassian Jira (v7.12.1#712002)

7 years, 6 months

1
0
0 / 0

[JBoss JIRA] (DROOLS-2852) Duplicate i18n of the V&V for DMN or unify the reports so that the terms make sense

by Toni Rikkola (Jira)

[ https://issues.jboss.org/browse/DROOLS-2852?page=com.atlassian.jira.plugi... ] Toni Rikkola updated DROOLS-2852: --------------------------------- Priority: Optional (was: Major) > Duplicate i18n of the V&V for DMN or unify the reports so that the terms make sense > ----------------------------------------------------------------------------------- > > Key: DROOLS-2852 > URL: https://issues.jboss.org/browse/DROOLS-2852 > Project: Drools > Issue Type: Feature Request > Components: DMN Editor, verifier > Reporter: Toni Rikkola > Assignee: Toni Rikkola > Priority: Optional > Labels: drools-tools, verifier > -- This message was sent by Atlassian Jira (v7.12.1#712002)

7 years, 6 months

1
0
0 / 0

2026

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

jboss-jira January 2019